linux-toradex.git/fs/hfsplus/btree.c, branch v3.5-rc1

hfsplus: over 80 character lines clean-up

2010-12-16T17:08:45+00:00

Match coding style line length limitation where checkpatch.pl
reported over-80-character-line warnings.

Signed-off-by: Anton Salikhmetov 
Signed-off-by: Christoph Hellwig

hfsplus: silence a few debug printks

2010-11-23T13:37:40+00:00

Turn a few noisy debug printks that show up during xfstests into
complied out debug print statements.

Signed-off-by: Christoph Hellwig

hfsplus: validate btree flags

2010-10-14T13:54:23+00:00

Signed-off-by: Christoph Hellwig

hfsplus: handle more on-disk corruptions without oopsing

2010-10-14T13:53:48+00:00

hfs seems prone to bad things when it encounters on disk corruption.  Many
values are read from disk, and used as lengths to memcpy, as an example.
This patch fixes up several of these problematic cases.

o sanity check the on-disk maximum key lengths on mount
  (these are set to a defined value at mkfs time and shouldn't differ)
o check on-disk node keylens against the maximum key length for each tree
o fix hfs_btree_open so that going out via free_tree: doesn't wind
  up in hfs_releasepage, which wants to follow the very pointer
  we were trying to set up:
	HFS_SB(sb)->cat_tree = hfs_btree_open()
    .
  failure gets to hfs_releasepage and tries to follow HFS_SB(sb)->cat_tree

Tested with the fsfuzzer; it survives more than it used to.

[hch: ported of commit cf0594625083111ae522496dc1c256f7476939c2 from hfs]
[hch: added the fixes from 5581d018ed3493d226e7a4d645d9c8a5af6c36b]

Signed-off-by: Eric Sandeen 
Signed-off-by: Christoph Hellwig

hfsplus: fix oops on mount with corrupted btree extent records

2010-10-14T13:53:37+00:00

A particular fsfuzzer run caused an hfs file system to crash on mount. This
is due to a corrupted MDB extent record causing a miscalculation of
HFSPLUS_I(inode)->first_blocks for the extent tree. If the extent records
are zereod out, then it won't trigger the first_blocks special case and
instead falls through to the extent code, which we're in the middle
of initializing.

This patch catches the 0 size extent records, reports the corruption,
and fails the mount.

[hch: ported of commit 47f365eb575735c6b2edf5d08e0d16d26a9c23bd from hfs]

Reported-by: Ramon de Carvalho Valle 
Signed-off-by: Jeff Mahoney 
Signed-off-by: Christoph Hellwig

hfsplus: convert tree_lock to mutex

2010-10-01T03:46:52+00:00

tree_lock is used as mutex so make it a mutex.

Signed-off-by: Thomas Gleixner 
Signed-off-by: Christoph Hellwig

hfsplus: use atomic bitops for the superblock flags

2010-10-01T03:45:20+00:00

The flags in the HFS+-specific superlock do get modified during runtime,
use atomic bitops to make the modifications SMP safe.

Signed-off-by: Christoph Hellwig

hfsplus: fix HFSPLUS_I calling convention

2010-10-01T03:43:31+00:00

HFSPLUS_I doesn't return a pointer to the hfsplus-specific inode
information like all other FOO_I macros, but dereference the pointer in a way
that made it look like a direct struct derefence.  This only works as long
as the HFSPLUS_I macro is used directly and prevents us from keepig a local
hfsplus_inode_info pointer.  Fix the calling convention and introduce a local
hip variable in all functions that use it constantly.

Signed-off-by: Christoph Hellwig

hfsplus: fix HFSPLUS_SB calling convention

2010-10-01T03:42:59+00:00

HFSPLUS_SB doesn't return a pointer to the hfsplus-specific superblock
information like all other FOO_SB macros, but dereference the pointer in a way
that made it look like a direct struct derefence.  This only works as long
as the HFSPLUS_SB macro is used directly and prevents us from keepig a local
hfsplus_sb_info pointer.  Fix the calling convention and introduce a local
sbi variable in all functions that use it constantly.

Signed-off-by: Christoph Hellwig

hfsplus: fix warning with 64k PAGE_SIZE

2008-04-30T15:29:52+00:00

fs/hfsplus/btree.c: In function 'hfsplus_bmap_alloc':
fs/hfsplus/btree.c:239: warning: comparison is always false due to limited range of data type

But this might hide a real bug?

Cc: Roman Zippel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds