linux-toradex.git/fs/hfsplus/extents.c, branch v3.4

hfsplus: Add error propagation for hfsplus_ext_write_extent_locked

2011-07-07T15:45:46+00:00

Implement error propagation through the callers of
hfsplus_ext_write_extent_locked().

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Christoph Hellwig

hfsplus: add error checking for hfs_find_init()

2011-07-07T15:45:46+00:00

hfs_find_init() may fail with ENOMEM, but there are places, where
the returned value is not checked. The consequences can be very
unpleasant, e.g. kfree uninitialized pointer and
inappropriate mutex unlocking.

The patch adds checks for errors in hfs_find_init().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Christoph Hellwig

hfsplus: fix overflow in hfsplus_get_block

2011-06-30T11:40:58+00:00

For filesystems larger than 2TB the final sector number passed to
map_bh might overflow the range representable in a 32-bit data type.
Make sure we use a sector_t for it and the arithmetics calculating it.

Signed-off-by: Christoph Hellwig

hfsplus: fix up a comparism in hfsplus_file_extend

2011-02-03T23:34:18+00:00

Revert an incorrect hunk from commit b2837fcf4994e699a4def002e26f274d95b387c1,

	"hfsplus: %L-to-%ll, macro correction, and remove unneeded braces"

revert a pointless change of comparism operation argument order, which turned
out to not even be equivalent.

Reported-by: Joe Perches 
Signed-off-by: Christoph Hellwig

hfsplus: %L-to-%ll, macro correction, and remove unneeded braces

2010-12-16T17:08:46+00:00

Clean-up based on checkpatch.pl report against unnecessary braces
(`{' and `}'), non-standard format option %Lu (%llu recommended)
as well as one trailing statement in a macro definition which
should have been on the next line.

Signed-off-by: Anton Salikhmetov 
Signed-off-by: Christoph Hellwig

hfsplus: C99 comments clean-up

2010-12-16T17:08:46+00:00

Match coding style restriction against C99 comments where
checkpatch.pl reported errors about their usage.

Signed-off-by: Anton Salikhmetov 
Signed-off-by: Christoph Hellwig

hfsplus: over 80 character lines clean-up

2010-12-16T17:08:45+00:00

Match coding style line length limitation where checkpatch.pl
reported over-80-character-line warnings.

Signed-off-by: Anton Salikhmetov 
Signed-off-by: Christoph Hellwig

hfsplus: optimize fsync

2010-11-23T13:38:15+00:00

Avoid doing unessecary work in fsync.  Do nothing unless the inode
was marked dirty, and only write the various metadata inodes out if
they contain any dirty state from this inode.  This is archived by
adding three new dirty bits to the hfsplus-specific inode which are
set in the correct places.

Signed-off-by: Christoph Hellwig

hfsplus: split up inode flags

2010-11-23T13:38:13+00:00

Split the flags field in the hfsplus inode into an extent_state
flag that is locked by the extent_lock, and a new flags field
that uses atomic bitops.  The second will grow more flags in the
next patch.

Signed-off-by: Christoph Hellwig

hfsplus: add missing extent locking in hfsplus_write_inode

2010-10-01T03:46:31+00:00

Most of the extent handling code already does proper SMP locking, but
hfsplus_write_inode was calling into hfsplus_ext_write_extent without
taking the extents_lock.  Fix this by splitting hfsplus_ext_write_extent
into an internal helper that expects the lock, and a public interface
that first acquires it.

Also add a few locking asserts and document the locking rules in
hfsplus_fs.h.

Signed-off-by: Christoph Hellwig