linux-toradex.git/fs/hfsplus/wrapper.c, branch v3.0.74

hfsplus: fix overflow in sector calculations in hfsplus_submit_bio

2012-06-22T18:34:14+00:00

commit a6dc8c04218eb752ff79cdc24a995cf51866caed upstream.

The variable io_size was unsigned int, which caused the wrong sector number
to be calculated after aligning it. This then caused mount to fail with big
volumes, as backup volume header information was searched from a
wrong sector.

Signed-off-by: Janne Kalliomäki 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

hfsplus: Fix kfree of wrong pointers in hfsplus_fill_super() error path

2011-10-25T05:10:17+00:00

commit f588c960fcaa6fa8bf82930bb819c9aca4eb9347 upstream.

Commit 6596528e391a ("hfsplus: ensure bio requests are not smaller than
the hardware sectors") changed the pointers used for volume header
allocations but failed to free the correct pointers in the error path
path of hfsplus_fill_super() and hfsplus_read_wrapper.

The second hunk came from a separate patch by Pavel Ivanov.

Reported-by: Pavel Ivanov 
Signed-off-by: Seth Forshee 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

hfsplus: ensure bio requests are not smaller than the hardware sectors

2011-10-25T05:10:15+00:00

commit 6596528e391ad978a6a120142cba97a1d7324cb6 upstream.

Currently all bio requests are 512 bytes, which may fail for media
whose physical sector size is larger than this. Ensure these
requests are not smaller than the block device logical block size.

BugLink: http://bugs.launchpad.net/bugs/734883
Signed-off-by: Seth Forshee 
Signed-off-by: Christoph Hellwig 
Cc: Josh Boyer 
Signed-off-by: Greg Kroah-Hartman

hfsplus: add missing call to bio_put()

2011-06-30T11:28:32+00:00

hfsplus leaks bio objects by failing to call bio_put() on the bios
it allocates. Add the missing call to fix the leak.

Signed-off-by: Seth Forshee 
Cc:  # .38.x, .39.x
Signed-off-by: Christoph Hellwig

hfsplus: fix two memory leaks in wrapper.c

2011-02-03T23:34:11+00:00

Signed-Off-By: Chuck Ebbert 
Signed-off-by: Christoph Hellwig

hfsplus: over 80 character lines clean-up

2010-12-16T17:08:45+00:00

Match coding style line length limitation where checkpatch.pl
reported over-80-character-line warnings.

Signed-off-by: Anton Salikhmetov 
Signed-off-by: Christoph Hellwig

hfsplus: use raw bio access for the volume headers

2010-11-23T13:37:47+00:00

The hfsplus backup volume header is located two blocks from the end of
the device.  In case of device sizes that are not 4k aligned this means
we can't access it using buffer_heads when using the default 4k block
size.

Switch to using raw bios to read/write all buffer headers.  We were not
relying on any caching behaviour of the buffer heads anyway.  Additionally
always read in the backup volume header during mount to verify that we
can actually read it.

Signed-off-by: Christoph Hellwig

hfsplus: use atomic bitops for the superblock flags

2010-10-01T03:45:20+00:00

The flags in the HFS+-specific superlock do get modified during runtime,
use atomic bitops to make the modifications SMP safe.

Signed-off-by: Christoph Hellwig

hfsplus: fix HFSPLUS_SB calling convention

2010-10-01T03:42:59+00:00

HFSPLUS_SB doesn't return a pointer to the hfsplus-specific superblock
information like all other FOO_SB macros, but dereference the pointer in a way
that made it look like a direct struct derefence.  This only works as long
as the HFSPLUS_SB macro is used directly and prevents us from keepig a local
hfsplus_sb_info pointer.  Fix the calling convention and introduce a local
sbi variable in all functions that use it constantly.

Signed-off-by: Christoph Hellwig

hfsplus: refuse to mount volumes larger than 2TB

2009-10-29T14:39:27+00:00

As found in , hfsplus is using type u32
rather than sector_t for some sector number calculations.

In particular, hfsplus_get_block() does:

        u32 ablock, dblock, mask;
...
        map_bh(bh_result, sb, (dblock << HFSPLUS_SB(sb).fs_shift) + HFSPLUS_SB(sb).blockoffset + (iblock & mask));

I am not confident that I can find and fix all cases where a sector number
may be truncated.  For now, avoid data loss by refusing to mount HFS+
volumes with more than 2^32 sectors (2TB).

[akpm@linux-foundation.org: fix 32 and 64-bit issues]
Signed-off-by: Ben Hutchings 
Cc: Eric Sesterhenn 
Cc: Roman Zippel 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds