linux-toradex.git/fs/hfsplus, branch v3.4.110

hfsplus: fix B-tree corruption after insertion at position 0

2015-06-19T03:40:29+00:00

commit 98cf21c61a7f5419d82f847c4d77bf6e96a76f5f upstream.

Fix B-tree corruption when a new record is inserted at position 0 in the
node in hfs_brec_insert().  In this case a hfs_brec_update_parent() is
called to update the parent index node (if exists) and it is passed
hfs_find_data with a search_key containing a newly inserted key instead
of the key to be updated.  This results in an inconsistent index node.
The bug reproduces on my machine after an extents overflow record for
the catalog file (CNID=4) is inserted into the extents overflow B-tree.
Because of a low (reserved) value of CNID=4, it has to become the first
record in the first leaf node.

The resulting first leaf node is correct:

  ----------------------------------------------------
  | key0.CNID=4 | key1.CNID=123 | key2.CNID=456, ... |
  ----------------------------------------------------

But the parent index key0 still contains the previous key CNID=123:

  -----------------------
  | key0.CNID=123 | ... |
  -----------------------

A change in hfs_brec_insert() makes hfs_brec_update_parent() work
correctly by preventing it from getting fd->record=-1 value from
__hfs_brec_find().

Along the way, I removed duplicate code with unification of the if
condition.  The resulting code is equivalent to the original code
because node is never 0.

Also hfs_brec_update_parent() will now return an error after getting a
negative fd->record value.  However, the return value of
hfs_brec_update_parent() is not checked anywhere in the file and I'm
leaving it unchanged by this patch.  brec.c lacks error checking after
some other calls too, but this issue is of less importance than the one
being fixed by this patch.

Signed-off-by: Sergei Antonov 
Cc: Joe Perches 
Reviewed-by: Vyacheslav Dubeyko 
Acked-by: Hin-Tak Leung 
Cc: Anton Altaparmakov 
Cc: Al Viro 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
[lizf: Backported to 3.4: adjust context]
Signed-off-by: Zefan Li

hfsplus: fix potential overflow in hfsplus_file_truncate()

2013-04-26T04:19:54+00:00

commit 12f267a20aecf8b84a2a9069b9011f1661c779b4 upstream.

Change a u32 to loff_t hfsplus_file_truncate().

Signed-off-by: Vyacheslav Dubeyko 
Cc: Christoph Hellwig 
Cc: Al Viro 
Cc: Hin-Tak Leung 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

hfsplus: fix bless ioctl when used with hardlinks

2012-06-22T18:36:57+00:00

commit 7dea9665fee828fb56db3bae5b9685d9fa006d33 upstream.

HFS+ doesn't really implement hard links - instead, hardlinks are indicated
by a magic file type which refers to an indirect node in a hidden
directory. The spec indicates that stat() should return the inode number
of the indirect node, but it turns out that this doesn't satisfy the
firmware when it's looking for a bootloader - it wants the catalog ID of
the hardlink file instead. Fix up this case.

Signed-off-by: Matthew Garrett 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

hfsplus: fix overflow in sector calculations in hfsplus_submit_bio

2012-06-22T18:36:57+00:00

commit a6dc8c04218eb752ff79cdc24a995cf51866caed upstream.

The variable io_size was unsigned int, which caused the wrong sector number
to be calculated after aligning it. This then caused mount to fail with big
volumes, as backup volume header information was searched from a
wrong sector.

Signed-off-by: Janne Kalliomäki 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

hfsplus: Fix potential buffer overflows

2012-05-05T00:11:24+00:00

Commit ec81aecb2966 ("hfs: fix a potential buffer overflow") fixed a few
potential buffer overflows in the hfs filesystem.  But as Timo Warns
pointed out, these changes also need to be made on the hfsplus
filesystem as well.

Reported-by: Timo Warns 
Acked-by: WANG Cong 
Cc: Alexey Khoroshilov 
Cc: Miklos Szeredi 
Cc: Sage Weil 
Cc: Eugene Teo 
Cc: Roman Zippel 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Alexey Dobriyan 
Cc: Dave Anderson 
Cc: stable 
Cc: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds

hfsplus: add an ioctl to bless files

2012-03-21T01:29:53+00:00

Making an hfsplus partition bootable requires the ability to "bless" a
file by putting its inode number in the volume header. Doing this from
userspace on a mounted filesystem is impractical since the kernel will
write back the original values on unmount. Add an ioctl to allow userspace
to update the volume header information based on the target file.

Signed-off-by: Matthew Garrett 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

hfsplus: change finder_info to u32

2012-03-21T01:29:52+00:00

The finder_info block in the hfsplus volume header is currently defined as
an array of 8 bit values, but TN1150 defines it as being an array of 32 bit
values. Fix for convenience.

Signed-off-by: Matthew Garrett 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

hfsplus: initialise userflags

2012-03-21T01:29:52+00:00

The userflags field was being written to the filesystem without being
initialised. Make sure it's clear, since otherwise files end up with
garbage attributes.

Signed-off-by: Matthew Garrett 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

hfsplus: switch to d_make_root()

2012-03-21T01:29:36+00:00

Signed-off-by: Al Viro

hfsplus: creation of hidden dir on mount can fail

2012-01-10T22:48:52+00:00

Signed-off-by: Al Viro