linux-toradex.git/fs/jbd2, branch v3.18.4

jbd2: fix regression where we fail to initialize checksum seed when loading

2014-12-02T02:57:06+00:00

When we're enabling journal features, we cannot use the predicate
jbd2_journal_has_csum_v2or3() because we haven't yet set the sb
feature flag fields!  Moreover, we just finished loading the shash
driver, so the test is unnecessary; calculate the seed always.

Without this patch, we fail to initialize the checksum seed the first
time we turn on journal_checksum, which means that all journal blocks
written during that first mount are corrupt.  Transactions written
after the second mount will be fine, since the feature flag will be
set in the journal superblock.  xfstests generic/{034,321,322} are the
regression tests.

(This is important for 3.18.)

Signed-off-by: Darrick J. Wong 
Reported-by: Eric Whitney 
Signed-off-by: Theodore Ts'o

jbd2: use a better hash function for the revoke table

2014-10-30T14:53:17+00:00

The old hash function didn't work well for 64-bit block numbers, and
used undefined (negative) shift right behavior.  Use the generic
64-bit hash function instead.

Signed-off-by: Theodore Ts'o 
Reported-by: Andrey Ryabinin

jbd2: simplify calling convention around __jbd2_journal_clean_checkpoint_list

2014-09-18T04:58:12+00:00

__jbd2_journal_clean_checkpoint_list() returns number of buffers it
freed but noone was using the value so just stop doing that. This
also allows for simplifying the calling convention for
journal_clean_once_cp_list().

Signed-off-by: Jan Kara 
Signed-off-by: Theodore Ts'o

jbd2: avoid pointless scanning of checkpoint lists

2014-09-18T04:42:16+00:00

Yuanhan has reported that when he is running fsync(2) heavy workload
creating new files over ramdisk, significant amount of time is spent in
__jbd2_journal_clean_checkpoint_list() trying to clean old transactions
(but they cannot be cleaned up because flusher hasn't yet checkpointed
those buffers). The workload can be generated by:
  fs_mark -d /fs/ram0/1 -D 2 -N 2560 -n 1000000 -L 1 -S 1 -s 4096

Reduce the amount of scanning by stopping to scan the transaction list
once we find a transaction that cannot be checkpointed. Note that this
way of cleaning is still enough to keep freeing space in the journal
after fully checkpointed transactions.

Reported-and-tested-by: Yuanhan Liu 
Signed-off-by: Jan Kara 
Signed-off-by: Theodore Ts'o

jbd2: jbd2_log_wait_for_space improve error detetcion

2014-09-16T18:50:50+00:00

If EIO happens after we have dropped j_state_lock, we won't notice
that the journal has been aborted.  So it is reasonable to move this
check after we have grabbed the j_checkpoint_mutex and re-grabbed the
j_state_lock.  This patch helps to prevent false positive complain
after EIO.

#DMESG:
__jbd2_log_wait_for_space: needed 8448 blocks and only had 8386 space available
__jbd2_log_wait_for_space: no way to get more journal space in ram1-8
------------[ cut here ]------------
WARNING: CPU: 15 PID: 6739 at fs/jbd2/checkpoint.c:168 __jbd2_log_wait_for_space+0x188/0x200()
Modules linked in: brd iTCO_wdt lpc_ich mfd_core igb ptp dm_mirror dm_region_hash dm_log dm_mod
CPU: 15 PID: 6739 Comm: fsstress Tainted: G        W      3.17.0-rc2-00429-g684de57 #139
Hardware name: Intel Corporation W2600CR/W2600CR, BIOS SE5C600.86B.99.99.x028.061320111235 06/13/2011
 00000000000000a8 ffff88077aaab878 ffffffff815c1a8c 00000000000000a8
 0000000000000000 ffff88077aaab8b8 ffffffff8106ce8c ffff88077aaab898
 ffff8807c57e6000 ffff8807c57e6028 0000000000002100 ffff8807c57e62f0
Call Trace:
 [] dump_stack+0x51/0x6d
 [] warn_slowpath_common+0x8c/0xc0
 [] warn_slowpath_null+0x1a/0x20
 [] __jbd2_log_wait_for_space+0x188/0x200
 [] start_this_handle+0x4da/0x7b0
 [] ? local_clock+0x25/0x30
 [] ? lockdep_init_map+0xe7/0x180
 [] jbd2__journal_start+0xdc/0x1d0
 [] ? __ext4_new_inode+0x7f4/0x1330
 [] __ext4_journal_start_sb+0xf8/0x110
 [] __ext4_new_inode+0x7f4/0x1330
 [] ? lock_release_holdtime+0x29/0x190
 [] ext4_create+0x8b/0x150
 [] vfs_create+0x7b/0xb0
 [] do_last+0x7db/0xcf0
 [] ? inode_permission+0x4d/0x50
 [] path_openat+0x242/0x590
 [] ? __alloc_fd+0x36/0x140
 [] do_filp_open+0x4a/0xb0
 [] ? __alloc_fd+0x121/0x140
 [] do_sys_open+0x170/0x220
 [] SyS_open+0x1e/0x20
 [] SyS_creat+0x16/0x20
 [] system_call_fastpath+0x16/0x1b
---[ end trace cd71c831f82059db ]---

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o

jbd2: free bh when descriptor block checksum fails

2014-09-16T18:43:09+00:00

Free the buffer head if the journal descriptor block fails checksum
verification.

This is the jbd2 port of the e2fsprogs patch "e2fsck: free bh on csum
verify error in do_one_pass".

Signed-off-by: Darrick J. Wong 
Signed-off-by: Theodore Ts'o 
Reviewed-by: Eric Sandeen 
Cc: stable@vger.kernel.org

jbd2: fix journal checksum feature flag handling

2014-09-11T15:38:21+00:00

Clear all three journal checksum feature flags before turning on
whichever journal checksum options we want.  Rearrange the error
checking so that newer flags get complained about first.

Reported-by: TR Reardon 
Signed-off-by: Darrick J. Wong 
Signed-off-by: Theodore Ts'o

jbd/jbd2: use non-movable memory for the jbd superblock

2014-09-05T02:36:35+00:00

Sicne the jbd/jbd2 superblock is not released until the file system is
unmounted, allocate the buffer cache from the non-moveable area to
allow page migration and CMA allocations to more easily succeed.

Signed-off-by: Gioh Kim 
Signed-off-by: Theodore Ts'o 
Reviewed-by: Jan Kara

jbd2: optimize jbd2_log_do_checkpoint() a bit

2014-09-04T22:09:29+00:00

When we discover written out buffer in transaction checkpoint list we
don't have to recheck validity of a transaction. Either this is the
last buffer in a transaction - and then we are done - or this isn't
and then we can just take another buffer from the checkpoint list
without dropping j_list_lock.

Signed-off-by: Jan Kara 
Signed-off-by: Theodore Ts'o

jbd2: don't call get_bh() before calling __jbd2_journal_remove_checkpoint()

2014-09-04T22:09:22+00:00

The __jbd2_journal_remove_checkpoint() doesn't require an elevated
b_count; indeed, until the jh structure gets released by the call to
jbd2_journal_put_journal_head(), the bh's b_count is elevated by
virtue of the existence of the jh structure.

Suggested-by: Jan Kara 
Reviewed-by: Jan Kara 
Signed-off-by: Theodore Ts'o