linux-toradex.git/fs/jffs2/acl.c, branch v2.6.27.27

[PATCH] sanitize ->permission() prototype

2008-07-27T00:53:14+00:00

* kill nameidata * argument; map the 3 bits in ->flags anybody cares
  about to new MAY_... ones and pass with the mask.
* kill redundant gfs2_iop_permission()
* sanitize ecryptfs_permission()
* fix remaining places where ->permission() instances might barf on new
  MAY_... found in mask.

The obvious next target in that direction is permission(9)

folded fix for nfs_permission() breakage from Miklos Szeredi 

Signed-off-by: Al Viro

[JFFS2] Add missing call to posix_acl_release

2008-01-08T07:48:58+00:00

posix_acl_clone does a memory allocation and sets a reference count, so
posix_acl_release is needed afterwards to free it.

The problem was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)

// 
@@
type T;
identifier E;
expression E1, E2;
int ret;
statement S;
@@

  T E;
  <+...
(
  E = \(posix_acl_clone\|posix_acl_alloc\|posix_acl_dup\)(...);
  if (E == NULL) S
|
  if ((E = \(posix_acl_clone\|posix_acl_alloc\|posix_acl_dup\)(...)) == NULL) S
)
  ... when != E2 = E
      when strict
(
  posix_acl_release(E);
|
  E1 = E;
|
+ posix_acl_release(E);
  return;
|
+ posix_acl_release(E);
  return ret;
)
  ...+>
// 

Signed-off-by: Julia Lawall 
Acked-by: KaiGai Kohei 
Signed-off-by: David Woodhouse

[JFFS2] make jffs2_get_acl() static

2007-11-06T08:36:49+00:00

jffs2_get_acl() can now become static again.

Signed-off-by: Adrian Bunk 
Acked-by: KaiGai Kohei 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse

[JFFS2] Prevent return of initialised variable in jffs2_init_acl_post()

2007-10-27T14:36:44+00:00

Spotted by the Coverity checker, and pointed out by Adrian Bunk.

Signed-off-by: David Woodhouse

[JFFS2] Tidy up fix for ACL/permissions problem.

2007-10-20T13:10:54+00:00

[In commit 9ed437c50d89eabae763dd422579f73fdebf288d we fixed a problem 
with standard permissions on newly-created inodes, when POSIX ACLs are 
enabled. This cleans it up...]

The attached patch separate jffs2_init_acl() into two parts.

The one is jffs2_init_acl_pre() called from jffs2_new_inode().
It compute ACL oriented inode->i_mode bits, and allocate in-memory ACL
objects associated with the new inode just before when inode meta
infomation is written to the medium.

The other is jffs2_init_acl_post() called from jffs2_symlink(),
jffs2_mkdir(), jffs2_mknod() and jffs2_do_create().
It actually writes in-memory ACL objects into the medium next to
the success of writing meta-information.

In the current implementation, we have to write a same inode meta
infomation twice when inode->i_mode is updated by the default ACL.
However, we can avoid the behavior by putting an updated i_mode
before it is written at first, as jffs2_init_acl_pre() doing.

Signed-off-by: KaiGai Kohei 
Signed-off-by: David Woodhouse

[JFFS2] Fix ACL vs. mode handling.

2007-08-22T11:39:19+00:00

When POSIX ACL support was enabled, we weren't writing correct
legacy modes to the medium on inode creation, or when the ACL was set.
This meant that the permissions would be incorrect after the file system
was remounted.

Signed-off-by: David Woodhouse

Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check

2007-07-17T19:00:03+00:00

Introduce is_owner_or_cap() macro in fs.h, and convert over relevant
users to it. This is done because we want to avoid bugs in the future
where we check for only effective fsuid of the current task against a
file's owning uid, without simultaneously checking for CAP_FOWNER as
well, thus violating its semantics.
[ XFS uses special macros and structures, and in general looked ...
untouchable, so we leave it alone -- but it has been looked over. ]

The (current->fsuid != inode->i_uid) check in generic_permission() and
exec_permission_lite() is left alone, because those operations are
covered by CAP_DAC_OVERRIDE and CAP_DAC_READ_SEARCH. Similarly operations
falling under the purview of CAP_CHOWN and CAP_LEASE are also left alone.

Signed-off-by: Satyam Sharma 
Cc: Al Viro 
Acked-by: Serge E. Hallyn 
Signed-off-by: Linus Torvalds

[JFFS2] Tidy up licensing/copyright boilerplate.

2007-04-25T13:16:47+00:00

In particular, remove the bit in the LICENCE file about contacting
Red Hat for alternative arrangements. Their errant IS department broke
that arrangement a long time ago -- the policy of collecting copyright
assignments from contributors came to an end when the plug was pulled on
the servers hosting the project, without notice or reason.

We do still dual-license it for use with eCos, with the GPL+exception
licence approved by the FSF as being GPL-compatible. It's just that nobody
has the right to license it differently.

Signed-off-by: David Woodhouse

[PATCH] severing fs.h, radix-tree.h -> sched.h

2006-12-04T07:00:24+00:00

Signed-off-by: Al Viro

[JFFS2][XATTR] Fix memory leak in POSIX-ACL support

2006-07-02T14:13:46+00:00

jffs2_clear_acl() which releases acl caches allocated by kmalloc()
was defined but it was never called. Thus, we faced to the risk
of memory leaking.

This patch plugs jffs2_clear_acl() into jffs2_do_clear_inode().
It ensures to release acl cache when inode is cleared.

Signed-off-by: KaiGai Kohei 
Signed-off-by: David Woodhouse