linux-toradex.git/fs/jffs2/background.c, branch v4.5

signal: remove jffs2_garbage_collect_thread()->allow_signal(SIGCONT)

2015-11-07T01:50:42+00:00

jffs2_garbage_collect_thread() does allow_signal(SIGCONT) for no reason,
SIGCONT will wake a stopped task up even if it is ignored.

Signed-off-by: Oleg Nesterov 
Reviewed-by: Tejun Heo 
Cc: David Woodhouse 
Cc: Felipe Balbi 
Cc: Markus Pargmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

signal: introduce kernel_signal_stop() to fix jffs2_garbage_collect_thread()

2015-11-07T01:50:42+00:00

jffs2_garbage_collect_thread() can race with SIGCONT and sleep in
TASK_STOPPED state after it was already sent. Add the new helper,
kernel_signal_stop(), which does this correctly.

Signed-off-by: Oleg Nesterov 
Reviewed-by: Tejun Heo 
Cc: David Woodhouse 
Cc: Felipe Balbi 
Cc: Markus Pargmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

signal: turn dequeue_signal_lock() into kernel_dequeue_signal()

2015-11-07T01:50:42+00:00

1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This
   matches another "for kthreads only" kernel_sigaction() helper.

2. Remove the "tsk" and "mask" arguments, they are always current
   and current->blocked. And it is simply wrong if tsk != current.

3. We could also remove the 3rd "siginfo_t *info" arg but it looks
   potentially useful. However we can simplify the callers if we
   change kernel_dequeue_signal() to accept info => NULL.

4. Remove _irqsave, it is never called from atomic context.

Signed-off-by: Oleg Nesterov 
Reviewed-by: Tejun Heo 
Cc: David Woodhouse 
Cc: Felipe Balbi 
Cc: Markus Pargmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

signals: jffs2: fix the wrong usage of disallow_signal()

2014-06-06T23:08:11+00:00

jffs2_garbage_collect_thread() does disallow_signal(SIGHUP) around
jffs2_garbage_collect_pass() and the comment says "We don't want SIGHUP
to interrupt us".

But disallow_signal() can't ensure that jffs2_garbage_collect_pass()
won't be interrupted by SIGHUP, the problem is that SIGHUP can be
already pending when disallow_signal() is called, and in this case any
interruptible sleep won't block.

Note: this is in fact because disallow_signal() is buggy and should be
fixed, see the next changes.

But there is another reason why disallow_signal() is wrong: SIG_IGN set
by disallow_signal() silently discards any SIGHUP which can be sent
before the next allow_signal(SIGHUP).

Change this code to use sigprocmask(SIG_UNBLOCK/SIG_BLOCK, SIGHUP).
This even matches the old (and wrong) semantics allow/disallow had when
this logic was written.

Signed-off-by: Oleg Nesterov 
Cc: Peter Zijlstra 
Cc: Al Viro 
Cc: David Woodhouse 
Cc: Frederic Weisbecker 
Cc: Geert Uytterhoeven 
Cc: Ingo Molnar 
Cc: Mathieu Desnoyers 
Cc: Richard Weinberger 
Cc: Steven Rostedt 
Cc: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

jffs2: Use pr_fmt and remove jffs: from formats

2012-03-26T23:40:19+00:00

Use pr_fmt to prefix KBUILD_MODNAME to appropriate logging messages.

Remove now unnecessary internal prefixes from formats.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: Convert printks to pr_

2012-03-26T23:39:40+00:00

Use the more current logging style.

Coalesce formats, align arguments.
Convert uses of embedded function names to %s, __func__.

A couple of long line checkpatch errors I don't care about exist.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: Convert most D1/D2 macros to jffs2_dbg

2012-03-26T23:39:24+00:00

D1 and D2 macros are mostly uses to emit debugging messages.

Convert the logging uses of D1 & D2 to jffs2_dbg(level, fmt, ...)
to be a bit more consistent style with the rest of the kernel.

All jffs2_dbg output is now at KERN_DEBUG where some of
the previous uses were emitted at various KERN_s.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: Update copyright notices

2010-08-08T13:15:22+00:00

Signed-off-by: David Woodhouse

jffs2: Require jffs2_garbage_collect_trigger() to be called with lock held

2010-05-19T16:10:22+00:00

We're about to call this from a bunch of places which already hold
c->erase_completion_lock, so add an assertion and change its existing
callers to do the same.

Signed-off-by: David Woodhouse

jffs2: move jffs2_gcd_mtd threads to the new kthread API

2009-09-04T08:53:35+00:00

Move the jffs2 garbage collecting thread to the new kthread API.

Signed-off-by: Gerard Lledo 
Signed-off-by: Andrew Morton 
Signed-off-by: David Woodhouse