linux-toradex.git/fs/jffs2/gc.c, branch v2.6.32.26

jffs2: Fix long-standing bug with symlink garbage collection.

2009-12-18T22:05:52+00:00

commit 2e16cfca6e17ae37ae21feca080a6f2eca9087dc upstream.

Ever since jffs2_garbage_collect_metadata() was first half-written in
February 2001, it's been broken on architectures where 'char' is signed.
When garbage collecting a symlink with target length above 127, the payload
length would end up negative, causing interesting and bad things to happen.

Signed-off-by: David Woodhouse 
Signed-off-by: Greg Kroah-Hartman

[JFFS2] Track parent inode for directories (for NFS export)

2008-05-01T17:47:17+00:00

To support NFS export, we need to know the parent inode of directories.
Rather than growing the jffs2_inode_cache structure, share space with
the nlink field -- which was always set to 1 for directories anyway.

Signed-off-by: David Woodhouse

[JFFS2] Invert last argument of jffs2_gc_fetch_inode(), make it boolean.

2008-05-01T16:24:28+00:00

We don't actually care about nlink; we only care whether the inode in
question is unlinked or not.

Signed-off-by: David Woodhouse

[JFFS2] Fix jffs2_reserve_space() when all blocks are pending erasure.

2008-04-23T15:01:37+00:00

When _all_ the blocks were on the erase_pending_list, we could't find a
block to GC from but there was no _actually_ free space, and
jffs2_reserve_space() would get a little unhappy.

Handle this case by returning -EAGAIN from jffs2_garbage_collect_pass().
There are two callers of that function -- jffs2_flush_wbuf_gc(), which
will interpret it as an error and flush the writebuffer by other means,
and jffs2_reserve_space(), which we modify to respond to -EAGAIN with an
immediate call to jffs2_erase_pending_blocks() and another run round the
loop.

Signed-off-by: David Woodhouse

[JFFS2] semaphore->mutex conversion

2008-04-22T14:13:40+00:00

Signed-off-by: David Woodhouse

[JFFS2] fix sparse warnings in gc.c

2008-04-22T11:35:47+00:00

fs/jffs2/gc.c:1147:29: warning: symbol 'jeb' shadows an earlier one
fs/jffs2/gc.c:1084:89: originally declared here
fs/jffs2/gc.c:1197:29: warning: symbol 'jeb' shadows an earlier one
fs/jffs2/gc.c:1084:89: originally declared here

Rename the unused 'jeb' argument to avoid this. We could potentially
remove the argument, but GCC should be doing that anyway.

Signed-off-by: David Woodhouse

[JFFS2] Remove stray debugging printk

2007-10-13T13:29:39+00:00

Signed-off-by: David Woodhouse

[JFFS2] Handle dirents on the flash with embedded zero bytes in names.

2007-10-13T10:35:58+00:00

In three places: summary scan, normal scan, REF_PRISTINE GC.

Just truncate at the NUL, since that was the correct thing to do in the
only case where this (inexplicable) breakage has been seen.

Signed-off-by: David Woodhouse

[JFFS2] Check whether garbage-collection actually obsoleted its victim.

2007-10-13T10:31:23+00:00

In OLPC trac #4184 we found a case where a corrupted node didn't
actually get obsoleted when we tried to garbage-collect it. So we wrote
out many million copies of it, in repeated attempts to obsolete it,
until the flash became full. Don't Do That.

Signed-off-by: David Woodhouse

[JFFS2] Whitespace cleanups.

2007-07-10T09:01:22+00:00

Convert many spaces to tabs; one or two other minor cosmetic fixes.

Signed-off-by: David Woodhouse