linux-toradex.git/fs/jffs2/readinode.c, branch v6.12

jffs2: Fix GC exit abnormally

2020-12-13T20:55:39+00:00

The log of this problem is:
jffs2: Error garbage collecting node at 0x***!
jffs2: No space for garbage collection. Aborting GC thread

This is because GC believe that it do nothing, so it abort.

After going over the image of jffs2, I find a scene that
can trigger this problem stably.
The scene is: there is a normal dirent node at summary-area,
but abnormal at corresponding not-summary-area with error
name_crc.

The reason that GC exit abnormally is because it find that
abnormal dirent node to GC, but when it goes to function
jffs2_add_fd_to_list, it cannot meet the condition listed
below:

if ((*prev)->nhash == new->nhash && !strcmp((*prev)->name, new->name))

So no node is marked obsolete, statistical information of
erase_block do not change, which cause GC exit abnormally.

The root cause of this problem is: we do not check the
name_crc of the abnormal dirent node with summary is enabled.

Noticed that in function jffs2_scan_dirent_node, we use
function jffs2_scan_dirty_space to deal with the dirent
node with error name_crc. So this patch add a checking
code in function read_direntry to ensure the correctness
of dirent node. If checked failed, the dirent node will
be marked obsolete so GC will pass this node and this
problem will be fixed.

Cc: 
Signed-off-by: Zhe Li 
Signed-off-by: Richard Weinberger

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

jffs2: fix use-after-free on symlink traversal

2019-04-01T04:31:02+00:00

free the symlink body after the same RCU delay we have for freeing the
struct inode itself, so that traversal during RCU pathwalk wouldn't step
into freed memory.

Signed-off-by: Al Viro

jffs2: fix spelling mistake: "requestied" -> "requested"

2017-04-19T18:35:55+00:00

trivial fix to spelling mistake in JFFS2_ERROR message

Signed-off-by: Colin Ian King 
[Brian: also fix 'an' -> 'a']
Signed-off-by: Brian Norris

vfs: make the string hashes salt the hash

2016-06-11T03:21:46+00:00

We always mixed in the parent pointer into the dentry name hash, but we
did it late at lookup time.  It turns out that we can simplify that
lookup-time action by salting the hash with the parent pointer early
instead of late.

A few other users of our string hashes also wanted to mix in their own
pointers into the hash, and those are updated to use the same mechanism.

Hash users that don't have any particular initial salt can just use the
NULL pointer as a no-salt.

Cc: Vegard Nossum 
Cc: George Spelvin 
Cc: Al Viro 
Signed-off-by: Linus Torvalds

jffs2: fix a memleak in read_direntry()

2015-10-04T21:30:50+00:00

Need to free the memory allocated for 'fd' if failed to read all
of the remainder name.

Signed-off-by: Wei Fang 
Signed-off-by: Brian Norris

jffs2: fix unbalanced locking

2015-05-07T23:20:53+00:00

Li Zefan reported an unbalanced locking issue, found by his
internal debugging feature on runtime. The particular case he was
looking at doesn't lead to a deadlock, as the structure that this lock
is embedded in is freed on error. But we should straighten out the error
handling.

Because several callers of jffs2_do_read_inode_internal() /
jffs2_do_read_inode() already handle the locking/unlocking and inode
clearing at their own level, let's just push any unlocks/clearing down
to the caller. This consistency is much easier to verify.

Reported-by: Li Zefan 
Cc: David Woodhouse 
Cc: Artem Bityutskiy 
Cc: Andrew Morton 
Signed-off-by: Brian Norris

jffs2: Drop bogus if in comment

2014-11-29T02:23:44+00:00

Signed-off-by: Geert Uytterhoeven 
Cc: David Woodhouse 
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Brian Norris

fs/jffs2: use rbtree postorder iteration helper instead of opencoding

2014-01-24T00:37:03+00:00

Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead
of opencoding an alternate postorder iteration that modifies the tree

Signed-off-by: Cody P Schafer 
Cc: Michel Lespinasse 
Cc: Jan Kara 
Cc: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rbtree: move some implementation details from rbtree.h to rbtree.c

2012-10-09T07:22:32+00:00

rbtree users must use the documented APIs to manipulate the tree
structure.  Low-level helpers to manipulate node colors and parenthood are
not part of that API, so move them to lib/rbtree.c

[dwmw2@infradead.org: fix jffs2 build issue due to renamed __rb_parent_color field]
Signed-off-by: Michel Lespinasse 
Cc: Andrea Arcangeli 
Acked-by: David Woodhouse 
Cc: Rik van Riel 
Cc: Peter Zijlstra 
Cc: Daniel Santos 
Cc: Jens Axboe 
Cc: "Eric W. Biederman" 
Signed-off-by: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds