linux-toradex.git/fs/lockd/host.c, branch v3.4.16

Lockd: shutdown NLM hosts in network namespace context

2012-02-15T05:19:48+00:00

Lockd now managed in network namespace context. And this patch introduces
network namespace related NLM hosts shutdown in case of releasing per-net Lockd
resources.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

LockD: make nlm hosts network namespace aware

2012-02-15T05:19:48+00:00

This object depends on RPC client, and thus on network namespace.
So let's make it's allocation and lookup in network namespace context.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: Replace svc_addr_u by sockaddr_storage

2011-09-14T12:21:48+00:00

For IPv6 local address, lockd can not callback to client for
missing scope id when binding address at inet6_bind:

 324       if (addr_type & IPV6_ADDR_LINKLOCAL) {
 325               if (addr_len >= sizeof(struct sockaddr_in6) &&
 326                   addr->sin6_scope_id) {
 327                       /* Override any existing binding, if another one
 328                        * is supplied by user.
 329                        */
 330                       sk->sk_bound_dev_if = addr->sin6_scope_id;
 331               }
 332
 333               /* Binding to link-local address requires an interface */
 334               if (!sk->sk_bound_dev_if) {
 335                       err = -EINVAL;
 336                       goto out_unlock;
 337               }

Replacing svc_addr_u by sockaddr_storage, let rqstp->rq_daddr contains more info
besides address.

Reviewed-by: Jeff Layton 
Reviewed-by: Chuck Lever 
Signed-off-by: Mi Jinlong 
Signed-off-by: J. Bruce Fields

NLM: Fix "kernel BUG at fs/lockd/host.c:417!" or ".../host.c:283!"

2011-01-25T20:24:47+00:00

Nick Bowler  reports:

> We were just having some NFS server troubles, and my client machine
> running 2.6.38-rc1+ (specifically, commit 2b1caf6ed7b888c95) crashed
> hard (syslog output appended to this mail).
>
> I'm not sure what the exact timeline was or how to reproduce this,
> but the server was rebooted during all this.  Since I've never seen
> this happen before, it is possibly a regression from previous kernel
> releases.  However, I recently updated my nfs-utils (on the client) to
> version 1.2.3, so that might be related as well.

  [ BUG output redacted ]

When done searching, the for_each_host loop in next_host_state() falls
through and returns the final host on the host chain without bumping
it's reference count.

Since the host's ref count is only one at that point, releasing the
host in nlm_host_rebooted() attempts to destroy the host prematurely,
and therefore hits a BUG().

Likely, the original intent of the for_each_host behavior in
next_host_state() was to handle the case when the host chain is empty.
Searching the chain and finding no suitable host to return needs to be
handled as well.

Defensively restructure next_host_state() always to return NULL when
the loop falls through.

Introduced by commit b10e30f6 "lockd: reorganize nlm_host_rebooted".

Cc: J. Bruce Fields 
Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

lockd: double unlock in next_host_state()

2011-01-04T18:10:37+00:00

We unlock again after we goto out.

Signed-off-by: Dan Carpenter 
Signed-off-by: Trond Myklebust

lockd: Remove src_sap and src_len from nlm_lookup_host_info struct

2010-12-16T17:37:27+00:00

Clean up.

The contents of the src_sap field is not used in nlm_alloc_host().

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

lockd: Remove nlm_lookup_host()

2010-12-16T17:37:27+00:00

Clean up.

Remove the now unused helper nlm_lookup_host().

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

lockd: Make nrhosts an unsigned long

2010-12-16T17:37:27+00:00

Clean up.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

lockd: Rename nlm_hosts

2010-12-16T17:37:27+00:00

Clean up.

nlm_hosts now contains only server-side entries.  Rename it to match
convention of client side cache.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

lockd: Clean up nlmsvc_lookup_host()

2010-12-16T17:37:26+00:00

Clean up.

Change nlmsvc_lookup_host() to be purpose-built for server-side
nlm_host management.  This replaces the generic nlm_lookup_host()
helper function, just like on the client side.  The lookup logic is
specialized for server host lookups.

The server side cache also gets its own specialized equivalent of the
nlm_release_host() function.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust