linux-toradex.git/fs/lockd/svc.c, branch v3.15-rc8

lockd: ensure we tear down any live sockets when socket creation fails during lockd_up

2014-03-28T14:43:08+00:00

We had a Fedora ABRT report with a stack trace like this:

kernel BUG at net/sunrpc/svc.c:550!
invalid opcode: 0000 [#1] SMP
[...]
CPU: 2 PID: 913 Comm: rpc.nfsd Not tainted 3.13.6-200.fc20.x86_64 #1
Hardware name: Hewlett-Packard HP ProBook 4740s/1846, BIOS 68IRR Ver. F.40 01/29/2013
task: ffff880146b00000 ti: ffff88003f9b8000 task.ti: ffff88003f9b8000
RIP: 0010:[]  [] svc_destroy+0x128/0x130 [sunrpc]
RSP: 0018:ffff88003f9b9de0  EFLAGS: 00010206
RAX: ffff88003f829628 RBX: ffff88003f829600 RCX: 00000000000041ee
RDX: 0000000000000000 RSI: 0000000000000286 RDI: 0000000000000286
RBP: ffff88003f9b9de8 R08: 0000000000017360 R09: ffff88014fa97360
R10: ffffffff8114ce57 R11: ffffea00051c9c00 R12: ffff88003f829600
R13: 00000000ffffff9e R14: ffffffff81cc7cc0 R15: 0000000000000000
FS:  00007f4fde284840(0000) GS:ffff88014fa80000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f4fdf5192f8 CR3: 00000000a569a000 CR4: 00000000001407e0
Stack:
 ffff88003f792300 ffff88003f9b9e18 ffffffffa02de02a 0000000000000000
 ffffffff81cc7cc0 ffff88003f9cb000 0000000000000008 ffff88003f9b9e60
 ffffffffa033bb35 ffffffff8131c86c ffff88003f9cb000 ffff8800a5715008
Call Trace:
 [] lockd_up+0xaa/0x330 [lockd]
 [] nfsd_svc+0x1b5/0x2f0 [nfsd]
 [] ? simple_strtoull+0x2c/0x50
 [] ? write_pool_threads+0x280/0x280 [nfsd]
 [] write_threads+0x8b/0xf0 [nfsd]
 [] ? __get_free_pages+0x14/0x50
 [] ? get_zeroed_page+0x16/0x20
 [] ? simple_transaction_get+0xb1/0xd0
 [] nfsctl_transaction_write+0x48/0x80 [nfsd]
 [] vfs_write+0xb4/0x1f0
 [] ? putname+0x29/0x40
 [] SyS_write+0x49/0xa0
 [] ? __audit_syscall_exit+0x1f6/0x2a0
 [] system_call_fastpath+0x16/0x1b
Code: 31 c0 e8 82 db 37 e1 e9 2a ff ff ff 48 8b 07 8b 57 14 48 c7 c7 d5 c6 31 a0 48 8b 70 20 31 c0 e8 65 db 37 e1 e9 f4 fe ff ff 0f 0b <0f> 0b 66 0f 1f 44 00 00 0f 1f 44 00 00 55 48 89 e5 41 56 41 55
RIP  [] svc_destroy+0x128/0x130 [sunrpc]
 RSP 

Evidently, we created some lockd sockets and then failed to create
others. make_socks then returned an error and we tried to tear down the
svc, but svc->sv_permsocks was not empty so we ended up tripping over
the BUG() in svc_destroy().

Fix this by ensuring that we tear down any live sockets we created when
socket creation is going to return an error.

Fixes: 786185b5f8abefa (SUNRPC: move per-net operations from...)
Reported-by: Raphos 
Signed-off-by: Jeff Layton 
Reviewed-by: Stanislav Kinsbursky 
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields

drivers: avoid parsing names as kthread_run() format strings

2013-07-03T23:07:41+00:00

Calling kthread_run with a single name parameter causes it to be handled
as a format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents.

Signed-off-by: Kees Cook 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'for-3.7' of git://linux-nfs.org/~bfields/linux

2012-10-13T01:53:54+00:00

Pull nfsd update from J Bruce Fields:
 "Another relatively quiet cycle.  There was some progress on my
  remaining 4.1 todo's, but a couple of them were just of the form
  "check that we do X correctly", so didn't have much affect on the
  code.

  Other than that, a bunch of cleanup and some bugfixes (including an
  annoying NFSv4.0 state leak and a busy-loop in the server that could
  cause it to peg the CPU without making progress)."

* 'for-3.7' of git://linux-nfs.org/~bfields/linux: (46 commits)
  UAPI: (Scripted) Disintegrate include/linux/sunrpc
  UAPI: (Scripted) Disintegrate include/linux/nfsd
  nfsd4: don't allow reclaims of expired clients
  nfsd4: remove redundant callback probe
  nfsd4: expire old client earlier
  nfsd4: separate session allocation and initialization
  nfsd4: clean up session allocation
  nfsd4: minor free_session cleanup
  nfsd4: new_conn_from_crses should only allocate
  nfsd4: separate connection allocation and initialization
  nfsd4: reject bad forechannel attrs earlier
  nfsd4: enforce per-client sessions/no-sessions distinction
  nfsd4: set cl_minorversion at create time
  nfsd4: don't pin clientids to pseudoflavors
  nfsd4: fix bind_conn_to_session xdr comment
  nfsd4: cast readlink() bug argument
  NFSD: pass null terminated buf to kstrtouint()
  nfsd: remove duplicate init in nfsd4_cb_recall
  nfsd4: eliminate redundant nfs4_free_stateid
  fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR
  ...

lockd: per-net NSM client creation and destruction helpers introduced

2012-10-01T22:27:34+00:00

NSM RPC client can be required on NFSv3 umount, when child reaper is dying (and
destroying it's mount namespace). It means, that current nsproxy is set to
NULL already, but creation of RPC client requires UTS namespace for gaining
hostname string.
This patch introduces reference counted NFS RPC clients creation and
destruction helpers (similar to RPCBIND RPC clients).

Signed-off-by: Stanislav Kinsbursky 
Cc: 
Signed-off-by: Trond Myklebust

svcrpc: remove handling of unknown errors from svc_recv

2012-08-21T21:42:00+00:00

svc_recv() returns only -EINTR or -EAGAIN.  If we really want to worry
about the case where it has a bug that causes it to return something
else, we could stick a WARN() in svc_recv.  But it's silly to require
every caller to have all this boilerplate to handle that case.

Signed-off-by: J. Bruce Fields

Lockd: move grace period management from lockd() to per-net functions

2012-07-27T20:49:22+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

LockD: pass actual network namespace to grace period management functions

2012-07-27T20:49:22+00:00

Passed network namespace replaced hard-coded init_net

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

LockD: manage grace list per network namespace

2012-07-27T20:49:22+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

LockD: make lockd manager allocated per network namespace

2012-07-27T20:48:44+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

LockD: manage grace period per network namespace

2012-07-27T20:48:44+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields