linux-toradex.git/fs/lockd/svcproc.c, branch v6.7

lockd: set missing fl_flags field when retrieving args

2022-12-10T16:01:11+00:00

Signed-off-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Parametrize how much of argsize should be zeroed

2022-09-26T18:02:42+00:00

Currently, SUNRPC clears the whole of .pc_argsize before processing
each incoming RPC transaction. Add an extra parameter to struct
svc_procedure to enable upper layers to reduce the amount of each
operation's argument structure that is zeroed by SUNRPC.

The size of struct nfsd4_compoundargs, in particular, is a lot to
clear on each incoming RPC Call. A subsequent patch will cut this
down to something closer to what NFSv2 and NFSv3 uses.

This patch should cause no behavior changes.

Signed-off-by: Chuck Lever

NLM: Defend against file_lock changes after vfs_test_lock()

2022-07-30T00:08:56+00:00

Instead of trusting that struct file_lock returns completely unchanged
after vfs_test_lock() when there's no conflicting lock, stash away our
nlm_lockowner reference so we can properly release it for all cases.

This defends against another file_lock implementation overwriting fl_owner
when the return type is F_UNLCK.

Reported-by: Roberto Bergantinos Corpas 
Tested-by: Roberto Bergantinos Corpas 
Signed-off-by: Benjamin Coddington 
Signed-off-by: Chuck Lever

SUNRPC: Trace calls to .rpc_call_done

2021-10-20T22:09:54+00:00

Introduce a single tracepoint that can replace simple dprintk call
sites in upper layer "rpc_call_done" callbacks. Example:

   kworker/u24:2-1254  [001]   771.026677: rpc_stats_latency:    task:00000001@00000002 xid=0x16a6f3c0 rpcbindv2 GETPORT backlog=446 rtt=101 execute=555
   kworker/u24:2-1254  [001]   771.026677: rpc_task_call_done:   task:00000001@00000002 flags=ASYNC|DYNAMIC|SOFT|SOFTCONN|SENT runstate=RUNNING|ACTIVE status=0 action=rpcb_getport_done
   kworker/u24:2-1254  [001]   771.026678: rpcb_setport:         task:00000001@00000002 status=0 port=20048

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

Keep read and write fds with each nlm_file

2021-08-23T22:05:31+00:00

We shouldn't really be using a read-only file descriptor to take a write
lock.

Most filesystems will put up with it.  But NFS, for example, won't.

Signed-off-by: J. Bruce Fields 
Signed-off-by: Chuck Lever

nlm: minor nlm_lookup_file argument change

2021-08-23T16:56:03+00:00

It'll come in handy to get the whole nlm_lock.

Signed-off-by: J. Bruce Fields 
Signed-off-by: Chuck Lever

SUNRPC: Make trace_svc_process() display the RPC procedure symbolically

2021-01-25T14:36:23+00:00

The next few patches will employ these strings to help make server-
side trace logs more human-readable. A similar technique is already
in use in kernel RPC client code.

Signed-off-by: Chuck Lever

lockd: Replace PROC() macro with open code

2020-10-02T13:37:41+00:00

Clean up: Follow-up on ten-year-old commit b9081d90f5b9 ("NFS: kill
off complicated macro 'PROC'") by performing the same conversion in
the lockd code. To reduce the chance of error, I copied the original
C preprocessor output and then made some minor edits.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Show pid of lockd for remote locks

2019-07-03T21:52:09+00:00

Use the pid of lockd instead of the remote lock's svid for the fl_pid for
local POSIX locks.  This allows proper enumeration of which local process
owns which lock.  The svid is meaningless to local lock readers.

Signed-off-by: Benjamin Coddington 
Signed-off-by: J. Bruce Fields

lockd: Convert NLM service fl_owner to nlm_lockowner

2019-07-03T21:52:08+00:00

Do as the NLM client: allocate and track a struct nlm_lockowner for use as
the fl_owner for locks created by the NLM sever.  This allows us to keep
the svid within this structure for matching locks, and will allow us to
track the pid of lockd in a future patch.  It should also allow easier
reference of the nlm_host in conflicting locks, and simplify lock hashing
and comparison.

Signed-off-by: Benjamin Coddington 
[bfields@redhat.com: fix type of some error returns]
Signed-off-by: J. Bruce Fields