linux-toradex.git/fs/lockd/xdr.c, branch v4.9.120

lockd: xdr: Remove unused function

2015-01-15T18:46:27+00:00

Remove the function nlm_encode_fh() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist 
Signed-off-by: J. Bruce Fields

nfsd: remove

2014-05-06T21:54:53+00:00

The only real user of this header is fs/nfsd/nfsfh.h, so merge the
two.  Various lockѕ source files used it to indirectly get other
sunrpc or nfs headers, so fix those up.

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

lockd: Move nlmdbg_cookie2a() to svclock.c

2010-12-16T17:37:24+00:00

Clean up.  nlmdbg_cookie2a() is used only in svclock.c.

Signed-off-by: Chuck Lever 
Tested-by: J. Bruce Fields 
Signed-off-by: Trond Myklebust

lockd: Introduce new-style XDR functions for NLMv3

2010-12-16T17:37:21+00:00

We'd like to prevent local buffer overflows caused by malicious or
broken servers.  New xdr_stream style decoders can do that.

For efficiency, we also eventually want to be able to pass xdr_streams
from call_encode() and call_decode() to all XDR encoding functions,
rather than building an xdr_stream in every XDR encoding and decoding
function in the kernel.

To do all of this, rewrite the XDR encoding and decoding functions in
fs/lockd/xdr.c to use xdr_streams.  This makes them more or less
incompatible with server-side XDR helper functions, so break them out
into a separate source file.

Static helper functions are left without the "inline" directive.  This
allows the compiler to choose automatically how to optimize these for
size or speed.

SHARE-related functionality doesn't seem to be used, as those
functions are hiding behind a #define that isn't set anywhere that I
can find.  And, they've been in there forever (at least as far back as
the kernel's git history goes), yet remain unused.  Let's take the
opportunity to bin them.  It should be easy enough for someone to
introduce proper XDR functions if at some point SHARE-related NLM
functionality is desired.

Signed-off-by: Chuck Lever 
Tested-by: J. Bruce Fields 
Signed-off-by: Trond Myklebust

headers: utsname.h redux

2009-09-24T01:13:10+00:00

* remove asm/atomic.h inclusion from linux/utsname.h --
   not needed after kref conversion
 * remove linux/utsname.h inclusion from files which do not need it

NOTE: it looks like fs/binfmt_elf.c do not need utsname.h, however
due to some personality stuff it _is_ needed -- cowardly leave ELF-related
headers and files alone.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds

NSM: Remove include/linux/lockd/sm_inter.h

2009-01-06T16:53:55+00:00

Clean up: The include/linux/lockd/sm_inter.h header is nearly empty
now.  Remove it.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

NLM: Decode "priv" argument of NLMPROC_SM_NOTIFY as an opaque

2009-01-06T16:53:54+00:00

The NLM XDR decoders for the NLMPROC_SM_NOTIFY procedure should treat
their "priv" argument truly as an opaque, as defined by the protocol,
and let the upper layers figure out what is in it.

This will make it easier to modify the contents and interpretation of
the "priv" argument, and keep knowledge about what's in "priv" local
to fs/lockd/mon.c.

For now, the NLM and NSM implementations should behave exactly as they
did before.

The formation of the address of the rebooted host in
nlm_host_rebooted() may look a little strange, but it is the inverse
of how nsm_init_private() forms the private cookie.  Plus, it's
going away soon anyway.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Remove unused fields in the nlm_reboot structure

2008-10-03T21:02:35+00:00

The nlm_reboot structure is used to store information provided by the
NSM_NOTIFY procedure.  This procedure is not specified by the NLM or NSM
protocols, other than to say that the procedure can be used to transmit
information private to a particular NLM/NSM implementation.

For Linux, the callback arguments include the name of the monitored host,
the new NSM state of the host, and a 16-byte private opaque.

As a clean up, remove the unused fields and the server-side XDR logic that
decodes them.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Eliminate harmless mixed sign comparison in nlmdbg_cookie2a()

2008-01-30T07:06:02+00:00

The cookie->len field is unsigned, so the loop index variable in
nlmdbg_cookie2a() should also be unsigned.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

LOCKD: Convert printk's to dprintk's in lockd XDR routines

2007-10-09T21:17:12+00:00

Due to recent edict to remove or replace printk's that might flood the
system log.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust