linux-toradex.git/fs/nfs/blocklayout, branch v3.2.32

pnfsblock: fix partial page buffer wirte

2012-10-17T02:49:21+00:00

commit fe6e1e8d9fad86873eb74a26e80a8f91f9e870b5 upstream.

If applications use flock to protect its write range, generic NFS
will not do read-modify-write cycle at page cache level. Therefore
LD should know how to handle non-sector aligned writes. Otherwise
there will be data corruption.

Signed-off-by: Peng Tao 
Signed-off-by: Trond Myklebust 
[bwh: Backported to Linux 3.2:
 - Adjust context
 - s/wdata->pages\.npages/wdata->npages/
 - s/header->pnfs_error/wdata->pnfs_error/
 - Drop change in missing out_mds exit path]
Signed-off-by: Ben Hutchings

fix page number calculation bug for block layout decode buffer

2012-09-12T02:36:49+00:00

commit 10bd295a0b6488ebe634b72a11d8986bd3af3819 upstream.

Signed-off-by: Jim Rees 
Suggested-by: Andy Adamson 
Suggested-by: Fred Isaman 
Signed-off-by: Trond Myklebust 
Signed-off-by: Ben Hutchings

NFS: Use kcalloc() when allocating arrays

2012-09-12T02:36:48+00:00

commit 7d9dea915fe333357912bce2d624ee848dfbd890 upstream.

Signed-off-by: Trond Myklebust 
Signed-off-by: Ben Hutchings

pnfsblock: limit bio page count

2012-01-26T00:13:37+00:00

commit 74a6eeb44ca6174d9cc93b9b8b4d58211c57bc80 upstream.

One bio can have at most BIO_MAX_PAGES pages. We should limit it bec otherwise
bio_alloc will fail when there are many pages in one read/write_pagelist.

Signed-off-by: Peng Tao 
Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pnfsblock: don't spinlock when freeing block_dev

2012-01-26T00:13:36+00:00

commit 93a3844ee0f843b05a1df4b52e1a19ff26b98d24 upstream.

bl_free_block_dev() may sleep. We can not call it with spinlock held.
Besides, there is no need to take bm_lock as we are last user freeing bm_devlist.

Signed-off-by: Peng Tao 
Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pnfsblock: acquire im_lock in _preload_range

2012-01-26T00:13:36+00:00

commit 39e567ae36fe03c2b446e1b83ee3d39bea08f90b upstream.

When calling _add_entry, we should take the im_lock to protect
agains other modifiers.

Signed-off-by: Peng Tao 
Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pnfsblock: fix writeback deadlock

2011-10-18T16:08:15+00:00

We should check if the sector is already initialized before
trying to grab the page from page cache. Otherwise when two
pages of the same block are written back by two threads each
calling from writepage_locked, it can cause deadlock like bellow.

 [ 1080.972099] INFO: task kswapd0:25 blocked for more than 120 seconds.
 [ 1080.972377] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
 [ 1080.972812] kswapd0         D ffff88000c4926c0     0    25      2 0x00000000
 [ 1080.972816]  ffff88000df276b0 0000000000000046 ffff88000df27640 ffffffff81013ba7
 [ 1080.972821]  ffff88000c492310 ffff88000df27fd8 ffff88000df27fd8 00000000001d3440
 [ 1080.972824]  ffff88000c378000 ffff88000c492310 ffff8800175d3d40 ffff880017fc75a8
 [ 1080.972828] Call Trace:
 [ 1080.972860]  [] ? read_tsc+0x9/0x19
 [ 1080.972877]  [] ? lock_page+0x2b/0x2b
 [ 1080.972899]  [] io_schedule+0x63/0x7e
 [ 1080.972902]  [] sleep_on_page+0xe/0x12
 [ 1080.972905]  [] __wait_on_bit_lock+0x46/0x8f
 [ 1080.972916]  [] ? lock_release_holdtime.part.7+0x6b/0x72
 [ 1080.972919]  [] __lock_page+0x66/0x68
 [ 1080.972928]  [] ? autoremove_wake_function+0x3d/0x3d
 [ 1080.972932]  [] lock_page+0x27/0x2b
 [ 1080.972934]  [] find_lock_page+0x34/0x57
 [ 1080.972937]  [] find_or_create_page+0x34/0x8a
 [ 1080.972947]  [] bl_write_pagelist+0x205/0x6da [blocklayoutdriver]
 [ 1080.972951]  [] ? bl_free_lseg+0x38/0x38 [blocklayoutdriver]
 [ 1080.972995]  [] ? nfs_write_rpcsetup+0x118/0x123 [nfs]
 [ 1080.973033]  [] pnfs_generic_pg_writepages+0x10b/0x1f4 [nfs]
 [ 1080.973089]  [] nfs_pageio_doio+0x1a/0x43 [nfs]
 [ 1080.973098]  [] nfs_pageio_complete+0x16/0x2d [nfs]
 [ 1080.973108]  [] nfs_writepage_locked+0xa0/0xbf [nfs]
 [ 1080.973119]  [] nfs_writepage+0x16/0x2b [nfs]
 [ 1080.973122]  [] ? clear_page_dirty_for_io+0x87/0x9a
 [ 1080.973133]  [] shrink_page_list+0x39b/0x6c8
 [ 1080.973139]  [] shrink_inactive_list+0x22c/0x39e
 [ 1080.973144]  [] ? lock_release_holdtime.part.7+0x6b/0x72
 [ 1080.973148]  [] shrink_zone+0x445/0x588
 [ 1080.973152]  [] balance_pgdat+0x2c2/0x56b
 [ 1080.973170]  [] ? __bitmap_weight+0x34/0x80
 [ 1080.973175]  [] kswapd+0x2be/0x2fa
 [ 1080.973179]  [] ? __init_waitqueue_head+0x4b/0x4b
 [ 1080.973183]  [] ? balance_pgdat+0x56b/0x56b
 [ 1080.973187]  [] kthread+0xa8/0xb0
 [ 1080.973200]  [] kernel_thread_helper+0x4/0x10
 [ 1080.973205]  [] ? __init_kthread_worker+0x5a/0x5a
 [ 1080.973210]  [] ? gs_change+0x13/0x13
 [ 1080.973213] no locks held by kswapd0/25.

Signed-off-by: Peng Tao 
Signed-off-by: Jim Rees 
Cc: stable@kernel.org [3.0]
Signed-off-by: Trond Myklebust

pnfsblock: fix NULL pointer dereference

2011-10-18T16:08:14+00:00

bl_add_page_to_bio returns error pointer. bio should be reset to
NULL in failure cases as the out path always calls bl_submit_bio.

Signed-off-by: Peng Tao 
Signed-off-by: Jim Rees 
Cc: stable@kernel.org [3.0]
Signed-off-by: Trond Myklebust

pnfs: make _set_lo_fail generic

2011-10-18T16:08:13+00:00

file layout and block layout both use it to set mark layout io failure
bit. So make it generic.

Signed-off-by: Peng Tao 
Signed-off-by: Jim Rees 
Cc: stable@kernel.org [3.0]
Signed-off-by: Trond Myklebust

pnfsblock: add missing rpc_put_mount and path_put

2011-10-18T16:08:12+00:00

Reviewed-by: Jeff Layton 
Signed-off-by: Peng Tao 
Signed-off-by: Jim Rees 
Cc: stable@kernel.org [3.0]
Signed-off-by: Trond Myklebust