linux-toradex.git/fs/nfs/callback_proc.c, branch v3.4.86

NFSv4: Further clean-ups of delegation stateid validation

2012-03-06T15:32:44+00:00

Change the name to reflect what we're really doing: testing two
stateids for whether or not they match according the the rules in
RFC3530 and RFC5661.
Move the code from callback_proc.c to nfs4proc.c

Signed-off-by: Trond Myklebust

NFSv4.1: Fix matching of the stateids when returning a delegation

2012-03-06T15:32:44+00:00

nfs41_validate_delegation_stateid is broken if we supply a stateid with
a non-zero sequence id. Instead of trying to match the sequence id,
the function assumes that we always want to error. While this is
true for a delegation callback, it is not true in general.

Also fix a typo in nfs4_callback_recall.

Reported-by: Andy Adamson 
Signed-off-by: Trond Myklebust

SUNRPC: Use RCU to dereference the rpc_clnt.cl_xprt field

2012-03-02T20:36:38+00:00

A migration event will replace the rpc_xprt used by an rpc_clnt.  To
ensure this can be done safely, all references to cl_xprt must now use
a form of rcu_dereference().

Special care is taken with rpc_peeraddr2str(), which returns a pointer
to memory whose lifetime is the same as the rpc_xprt.

Signed-off-by: Trond Myklebust 
[ cel: fix lockdep splats and layering violations ]
[ cel: forward ported to 3.4 ]
[ cel: remove rpc_max_reqs(), add rpc_net_ns() ]
Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

NFSv4.1: Get rid of NFS4CLNT_LAYOUTRECALL

2012-03-01T16:17:50+00:00

The NFS4CLNT_LAYOUTRECALL bit is a long-term impediment to scalability. It
basically stops all other recalls by a given server once any layout recall
is requested.

If the recall is for a different file, then we don't care.
If the recall applies to the same file, then we're in one of two situations:
Either we are in the case of a replay of an existing request, in which case
the session is supposed to deal with matters, or we are dealing with a
completely different request, in which case we should just try to process
it.

Signed-off-by: Trond Myklebust

NFS: search for client session id in proper network namespace

2012-02-06T23:48:04+00:00

Network namespace is taken from request transport and passed as a part of
cb_process_state structure.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

pnfs: clean up initiate_file_draining layout lookup

2012-02-01T00:28:22+00:00

Fixes the following compiler warning:

fs/nfs/callback_proc.c: In function 'do_callback_layoutrecall':
fs/nfs/callback_proc.c:115:26: warning: 'lo' may be used uninitialized in this function

Reported-by: Jim Rees 
Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust

NFSv4.1: fix backchannel slotid off-by-one bug

2012-01-05T15:42:40+00:00

Cc:stable@kernel.org
Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFSv4.1: Return NFS4ERR_BADSESSION to callbacks during session resets

2011-08-04T15:55:35+00:00

If the client is in the process of resetting the session when it receives
a callback, then returning NFS4ERR_DELAY may cause a deadlock with the
DESTROY_SESSION call.

Basically, if the client returns NFS4ERR_DELAY in response to the
CB_SEQUENCE call, then the server is entitled to believe that the
client is busy because it is already processing that call. In that
case, the server is perfectly entitled to respond with a
NFS4ERR_BACK_CHAN_BUSY to any DESTROY_SESSION call.

Fix this by having the client reply with a NFS4ERR_BADSESSION in
response to the callback if it is resetting the session.

Cc: stable@kernel.org [2.6.38+]
Signed-off-by: Trond Myklebust

NFSv4.1: Fix the callback 'highest_used_slotid' behaviour

2011-08-04T15:55:35+00:00

Currently, there is no guarantee that we will call nfs4_cb_take_slot() even
though nfs4_callback_compound() will consistently call
nfs4_cb_free_slot() provided the cb_process_state has set the 'clp' field.
The result is that we can trigger the BUG_ON() upon the next call to
nfs4_cb_take_slot().

This patch fixes the above problem by using the slot id that was taken in
the CB_SEQUENCE operation as a flag for whether or not we need to call
nfs4_cb_free_slot().
It also fixes an atomicity problem: we need to set tbl->highest_used_slotid
atomically with the check for NFS4_SESSION_DRAINING, otherwise we end up
racing with the various tests in nfs4_begin_drain_session().

Cc: stable@kernel.org [2.6.38+]
Signed-off-by: Trond Myklebust

NFS: move pnfs layouts to nfs_server structure

2011-07-12T17:40:27+00:00

Layouts should be tracked per nfs_server (aka superblock)
instead of per struct nfs_client, which may have multiple FSIDs associated
with it.

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust