linux-toradex.git/fs/nfs/callback_xdr.c, branch v6.2-rc8

SUNRPC: Parametrize how much of argsize should be zeroed

2022-09-26T18:02:42+00:00

Currently, SUNRPC clears the whole of .pc_argsize before processing
each incoming RPC transaction. Add an extra parameter to struct
svc_procedure to enable upper layers to reduce the amount of each
operation's argument structure that is zeroed by SUNRPC.

The size of struct nfsd4_compoundargs, in particular, is a lot to
clear on each incoming RPC Call. A subsequent patch will cut this
down to something closer to what NFSv2 and NFSv3 uses.

This patch should cause no behavior changes.

Signed-off-by: Chuck Lever

NFS: remove unneeded check in decode_devicenotify_args()

2022-03-13T16:59:34+00:00

[You don't often get email from khoroshilov@ispras.ru. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.]

Overflow check in not needed anymore after we switch to kmalloc_array().

Signed-off-by: Alexey Khoroshilov 
Fixes: a4f743a6bb20 ("NFSv4.1: Convert open-coded array allocation calls to kmalloc_array()")
Signed-off-by: Trond Myklebust

NFSv4.1: Fix uninitialised variable in devicenotify

2022-01-06T19:00:20+00:00

When decode_devicenotify_args() exits with no entries, we need to
ensure that the struct cb_devicenotifyargs is initialised to
{ 0, NULL } in order to avoid problems in
nfs4_callback_devicenotify().

Reported-by: 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

SUNRPC: Change return value type of .pc_encode

2021-10-13T15:34:49+00:00

Returning an undecorated integer is an age-old trope, but it's
not clear (even to previous experts in this code) that the only
valid return values are 1 and 0. These functions do not return
a negative errno, rpc_stat value, or a positive length.

Document there are only two valid return values by having
.pc_encode return only true or false.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

SUNRPC: Replace the "__be32 *p" parameter to .pc_encode

2021-10-13T15:34:49+00:00

The passed-in value of the "__be32 *p" parameter is now unused in
every server-side XDR encoder, and can be removed.

Note also that there is a line in each encoder that sets up a local
pointer to a struct xdr_stream. Passing that pointer from the
dispatcher instead saves one line per encoder function.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

NFS: Clean up the synopsis of callback process_op()

2021-08-10T18:18:35+00:00

The xdr_stream and rq_arg and rq_res are already accessible via the
@rqstp parameter.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

NFS: Extract the xdr_init_encode/decode() calls from decode_compound

2021-08-10T18:18:35+00:00

Clean up: Move the xdr_init_encode() and xdr_init_decode() calls
into the dispatcher, just like the NFSD and lockd dispatchers.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

NFS: Remove unused callback void decoder

2021-08-10T18:18:35+00:00

Clean up: The callback RPC dispatcher no longer invokes these call
outs, although svc_process_common() relies on seeing a .pc_encode
function.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

NFS: Add a private local dispatcher for NFSv4 callback operations

2021-08-10T18:18:35+00:00

The client's NFSv4 callback service is the only remaining user of
svc_generic_dispatch().

Note that the NFSv4 callback service doesn't use the .pc_encode and
.pc_decode callouts in any substantial way, so they are removed.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Eliminate the RQ_AUTHERR flag

2021-08-10T18:18:35+00:00

Now that there is an alternate method for returning an auth_stat
value, replace the RQ_AUTHERR flag with use of that new method.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker