linux-toradex.git/fs/nfs/delegation.c, branch v3.4.4

NFS: Fix a number of sparse warnings

2012-03-11T19:14:16+00:00

Fix a number of "warning: symbol 'foo' was not declared. Should it be
static?" conditions.

Fix 2 cases of "warning: Using plain integer as NULL pointer"

fs/nfs/delegation.c:263:31: warning: restricted fmode_t degrades to integer
  - We want to allow upgrades to a WRITE delegation, but should otherwise
    consider servers that hand out duplicate delegations to be borken.

Signed-off-by: Trond Myklebust

NFSv4.0: Re-establish the callback channel on NFS4ERR_CB_PATHDOWN

2012-03-10T16:54:36+00:00

When the NFSv4.0 server tells us that it can no-longer talk to us
on the callback channel, we should attempt a new SETCLIENTID in
order to re-transmit the callback channel information.

Note that as long as we do not change the boot verifier, this is
a safe procedure; the server is required to keep our state.

Also move the function nfs_handle_cb_pathdown to fs/nfs/nfs4state.c,
and change the name in order to mark it as being specific to NFSv4.0.

Signed-off-by: Trond Myklebust

NFS: Don't copy read delegation stateids in setattr

2012-03-09T03:37:12+00:00

The server will just return an NFS4ERR_OPENMODE anyway.

Signed-off-by: Trond Myklebust

NFSv4.1 handle DS stateid errors

2012-03-07T15:53:55+00:00

Handle DS READ and WRITE stateid errors by recovering the stateid on the MDS.

NFS4ERR_OLD_STATEID is ignored as the client always sends a
state sequenceid of zero for DS READ and WRITE stateids.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFSv4: Add helpers for basic copying of stateids

2012-03-06T15:32:46+00:00

Signed-off-by: Trond Myklebust

NFSv4: Further clean-ups of delegation stateid validation

2012-03-06T15:32:44+00:00

Change the name to reflect what we're really doing: testing two
stateids for whether or not they match according the the rules in
RFC3530 and RFC5661.
Move the code from callback_proc.c to nfs4proc.c

Signed-off-by: Trond Myklebust

NFSv4.1: Fix matching of the stateids when returning a delegation

2012-03-06T15:32:44+00:00

nfs41_validate_delegation_stateid is broken if we supply a stateid with
a non-zero sequence id. Instead of trying to match the sequence id,
the function assumes that we always want to error. While this is
true for a delegation callback, it is not true in general.

Also fix a typo in nfs4_callback_recall.

Reported-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFS: Properly handle the case where the delegation is revoked

2012-03-06T15:32:43+00:00

If we know that the delegation stateid is bad or revoked, we need to
remove that delegation as soon as possible, and then mark all the
stateids that relied on that delegation for recovery. We cannot use
the delegation as part of the recovery process.

Also note that NFSv4.1 uses a different error code (NFS4ERR_DELEG_REVOKED)
to indicate that the delegation was revoked.

Finally, ensure that setlk() and setattr() can both recover safely from
a revoked delegation.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

NFS: Use the inode->i_version to cache NFSv4 change attribute information

2011-10-18T16:14:34+00:00

Signed-off-by: Trond Myklebust

NFSv4: Don't use the delegation->inode in nfs_mark_return_delegation()

2011-07-25T19:37:29+00:00

nfs_mark_return_delegation() is usually called without any locking, and
so it is not safe to dereference delegation->inode. Since the inode is
only used to discover the nfs_client anyway, it makes more sense to
have the callers pass a valid pointer to the nfs_server as a parameter.

Reported-by: Ian Kent 
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust