linux-toradex.git/fs/nfs/filelayout, branch v4.9.84

NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.

2017-01-19T19:18:05+00:00

commit cfd278c280f997cf2fe4662e0acab0fe465f637b upstream.

Various places assume that if nfs4_fl_prepare_ds() turns a non-NULL 'ds',
then ds->ds_clp will also be non-NULL.

This is not necessasrily true in the case when the process received a fatal signal
while nfs4_pnfs_ds_connect is waiting in nfs4_wait_ds_connect().
In that case ->ds_clp may not be set, and the devid may not recently have been marked
unavailable.

So add a test for ds_clp == NULL and return NULL in that case.

Fixes: c23266d532b4 ("NFS4.1 Fix data server connection race")
Signed-off-by: NeilBrown 
Acked-by: Olga Kornievskaia 
Acked-by: Adamson, Andy 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pNFS/files: filelayout_write_done_cb must call nfs_writeback_update_inode()

2016-07-21T13:46:42+00:00

All write callbacks are required to call nfs_writeback_update_inode() upon
success to ensure that file size changes are recorded, and the attribute
cache is invalidated.

Signed-off-by: Trond Myklebust

pNFS: Files and flexfiles always need to commit before layoutcommit

2016-07-05T23:08:01+00:00

So ensure that we mark the layout for commit once the write is done,
and then ensure that the commit to ds is finished before sending
layoutcommit.

Note that by doing this, we're able to optimise away the commit
for the case of servers that don't need layoutcommit in order to
return updated attributes.

Signed-off-by: Trond Myklebust

pNFS/files: Fix layoutcommit after a commit to DS

2016-07-05T22:52:25+00:00

According to the errata
https://www.rfc-editor.org/errata_search.php?rfc=5661&eid=2751
we should always send layout commit after a commit to DS.

Fixes: bc7d4b8fd091 ("nfs/filelayout: set layoutcommit...")
Signed-off-by: Trond Myklebust

pnfs: pnfs_update_layout needs to consider if strict iomode checking is on

2016-05-26T12:40:56+00:00

As flexfiles has FF_FLAGS_NO_READ_IO, there is a need to generically
support enforcing that a IOMODE_RW segment will not allow READ I/O.

Signed-off-by: Tom Haynes 
Signed-off-by: Anna Schumaker

NFS: Save struct inode * inside nfs_commit_info to clarify usage of i_lock

2016-05-09T13:05:40+00:00

Commit ea2cf22 created nfs_commit_info and saved &inode->i_lock inside
this NFS specific structure.  This obscures the usage of i_lock.
Instead, save struct inode * so later it's clear the spinlock taken is
i_lock.

Should be no functional change.

Signed-off-by: Dave Wysochanski 
Signed-off-by: Anna Schumaker

NFS: Simplify nfs_request_add_commit_list() arguments

2016-01-21T20:54:04+00:00

I noticed that all the callers of this function pass cinfo->mds->list as
an argument in addition to the cinfo structure itself.  Let's get rid of
the extra argument, since it doesn't seem to be adding anything.

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

pNFS/flexfiles: Don't mark the entire layout as failed, when returning it

2015-12-28T19:32:40+00:00

In pNFS/flexfiles, we want to return the layout without necessarily marking
it as having completely failed. We therefore move the call to
pnfs_layout_io_set_failed() out of pnfs_error_mark_layout_for_return(),
and then ensura that pNFS/files layout calls it separately.

Signed-off-by: Trond Myklebust

NFS41: pop some layoutget errors to application

2015-12-28T19:32:36+00:00

For ERESTARTSYS/EIO/EROFS/ENOSPC/E2BIG in layoutget, we
should just bail out instead of hiding the error and
retrying inband IO.

Change all the call sites to pop the error all the way up.

Signed-off-by: Peng Tao 
Signed-off-by: Trond Myklebust

nfs/filelayout: Fix NULL reference caused by double freeing of fh_array

2015-09-17T22:10:28+00:00

If filelayout_decode_layout fail, _filelayout_free_lseg will causes
a double freeing of fh_array.

[ 1179.279800] BUG: unable to handle kernel NULL pointer dereference at           (null)
[ 1179.280198] IP: [] filelayout_free_fh_array.isra.11+0x1d/0x70 [nfs_layout_nfsv41_files]
[ 1179.281010] PGD 0
[ 1179.281443] Oops: 0000 [#1]
[ 1179.281831] Modules linked in: nfs_layout_nfsv41_files(OE) nfsv4(OE) nfs(OE) fscache(E) xfs libcrc32c coretemp nfsd crct10dif_pclmul ppdev crc32_pclmul crc32c_intel auth_rpcgss ghash_clmulni_intel nfs_acl lockd vmw_balloon grace sunrpc parport_pc vmw_vmci parport shpchp i2c_piix4 vmwgfx drm_kms_helper ttm drm serio_raw mptspi scsi_transport_spi mptscsih e1000 mptbase ata_generic pata_acpi [last unloaded: fscache]
[ 1179.283891] CPU: 0 PID: 13336 Comm: cat Tainted: G           OE   4.3.0-rc1-pnfs+ #244
[ 1179.284323] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/20/2014
[ 1179.285206] task: ffff8800501d48c0 ti: ffff88003e3c4000 task.ti: ffff88003e3c4000
[ 1179.285668] RIP: 0010:[]  [] filelayout_free_fh_array.isra.11+0x1d/0x70 [nfs_layout_nfsv41_files]
[ 1179.286612] RSP: 0018:ffff88003e3c77f8  EFLAGS: 00010202
[ 1179.287092] RAX: 0000000000000000 RBX: ffff88001fe78900 RCX: 0000000000000000
[ 1179.287731] RDX: ffffea0000f40760 RSI: ffff88001fe789c8 RDI: ffff88001fe789c0
[ 1179.288383] RBP: ffff88003e3c7810 R08: ffffea0000f40760 R09: 0000000000000000
[ 1179.289170] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88001fe789c8
[ 1179.289959] R13: ffff88001fe789c0 R14: ffff88004ec05a80 R15: ffff88004f935b88
[ 1179.290791] FS:  00007f4e66bb5700(0000) GS:ffffffff81c29000(0000) knlGS:0000000000000000
[ 1179.291580] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1179.292209] CR2: 0000000000000000 CR3: 00000000203f8000 CR4: 00000000001406f0
[ 1179.292731] Stack:
[ 1179.293195]  ffff88001fe78900 00000000000000d0 ffff88001fe78178 ffff88003e3c7868
[ 1179.293676]  ffffffffa0272737 0000000000000001 0000000000000001 ffff88001fe78800
[ 1179.294151]  00000000614fffce ffffffff81727671 ffff88001fe78100 ffff88001fe78100
[ 1179.294623] Call Trace:
[ 1179.295092]  [] filelayout_alloc_lseg+0xa7/0x2d0 [nfs_layout_nfsv41_files]
[ 1179.295625]  [] ? out_of_line_wait_on_bit+0x81/0xb0
[ 1179.296133]  [] pnfs_layout_process+0xae/0x320 [nfsv4]
[ 1179.296632]  [] nfs4_proc_layoutget+0x2b1/0x360 [nfsv4]
[ 1179.297134]  [] pnfs_update_layout+0x853/0xb30 [nfsv4]
[ 1179.297632]  [] ? nfs_get_lock_context+0x74/0x170 [nfs]
[ 1179.298158]  [] filelayout_pg_init_read+0x37/0x50 [nfs_layout_nfsv41_files]
[ 1179.298834]  [] __nfs_pageio_add_request+0x119/0x460 [nfs]
[ 1179.299385]  [] ? nfs_create_request.part.9+0x37/0x2e0 [nfs]
[ 1179.299872]  [] nfs_pageio_add_request+0xa3/0x1b0 [nfs]
[ 1179.300362]  [] readpage_async_filler+0x85/0x260 [nfs]
[ 1179.300907]  [] read_cache_pages+0x91/0xd0
[ 1179.301391]  [] ? nfs_read_completion+0x220/0x220 [nfs]
[ 1179.301867]  [] nfs_readpages+0x128/0x200 [nfs]
[ 1179.302330]  [] __do_page_cache_readahead+0x203/0x280
[ 1179.302784]  [] ? __do_page_cache_readahead+0xd8/0x280
[ 1179.303413]  [] ondemand_readahead+0x1a6/0x2f0
[ 1179.303855]  [] page_cache_sync_readahead+0x31/0x50
[ 1179.304286]  [] generic_file_read_iter+0x4a6/0x5c0
[ 1179.304711]  [] ? __nfs_revalidate_mapping+0x1f6/0x240 [nfs]
[ 1179.305132]  [] nfs_file_read+0x52/0xa0 [nfs]
[ 1179.305540]  [] __vfs_read+0xcc/0x100
[ 1179.305936]  [] vfs_read+0x85/0x130
[ 1179.306326]  [] SyS_read+0x58/0xd0
[ 1179.306708]  [] entry_SYSCALL_64_fastpath+0x12/0x76
[ 1179.307094] Code: c4 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 41 55 41 54 53 8b 07 49 89 f4 85 c0 74 47 48 8b 06 49 89 fd <48> 8b 38 48 85 ff 74 22 31 db eb 0c 48 63 d3 48 8b 3c d0 48 85
[ 1179.308357] RIP  [] filelayout_free_fh_array.isra.11+0x1d/0x70 [nfs_layout_nfsv41_files]
[ 1179.309177]  RSP 
[ 1179.309582] CR2: 0000000000000000

Signed-off-by: Kinglong Mee 
Signed-off-by: Trond Myklebust