linux-toradex.git/fs/nfs, branch v3.6.1

NFS: fsync() must exit with an error if page writeback failed

2012-09-11T19:38:32+00:00

We need to ensure that if the call to filemap_write_and_wait_range()
fails, then we report that error back to the application.

Signed-off-by: Trond Myklebust

NFS: return error from decode_getfh in decode open

2012-09-06T20:01:33+00:00

If decode_getfh failed, nfs4_xdr_dec_open would return 0 since the last
decode_* call must have succeeded.

Cc: stable@vger.kernel.org
Signed-off-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust

NFSv4: Fix buffer overflow checking in __nfs4_get_acl_uncached

2012-09-06T15:11:53+00:00

Pass the checks made by decode_getacl back to __nfs4_get_acl_uncached
so that it knows if the acl has been truncated.

The current overflow checking is broken, resulting in Oopses on
user-triggered nfs4_getfacl calls, and is opaque to the point
where several attempts at fixing it have failed.
This patch tries to clean up the code in addition to fixing the
Oopses by ensuring that the overflow checks are performed in
a single place (decode_getacl). If the overflow check failed,
we will still be able to report the acl length, but at least
we will no longer attempt to cache the acl or copy the
truncated contents to user space.

Reported-by: Sachin Prabhu 
Signed-off-by: Trond Myklebust 
Tested-by: Sachin Prabhu

NFSv4: Fix range checking in __nfs4_get_acl_uncached and __nfs4_proc_set_acl

2012-09-04T18:52:43+00:00

Ensure that the user supplied buffer size doesn't cause us to overflow
the 'pages' array.

Also fix up some confusion between the use of PAGE_SIZE and
PAGE_CACHE_SIZE when calculating buffer sizes. We're not using
the page cache for anything here.

Signed-off-by: Trond Myklebust

NFS: Fix a problem with the legacy binary mount code

2012-09-04T18:52:43+00:00

Apparently, am-utils is still using the legacy binary mountdata interface,
and is having trouble parsing /proc/mounts due to the 'port=' field being
incorrectly set.

The following patch should fix up the regression.

Reported-by: Marius Tolzmann 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

NFS: Fix the initialisation of the readdir 'cookieverf' array

2012-09-04T18:52:42+00:00

When the NFS_COOKIEVERF helper macro was converted into a static
inline function in commit 99fadcd764 (nfs: convert NFS_*(inode)
helpers to static inline), we broke the initialisation of the
readdir cookies, since that depended on doing a memset with an
argument of 'sizeof(NFS_COOKIEVERF(inode))' which therefore
changed from sizeof(be32 cookieverf[2]) to sizeof(be32 *).

At this point, NFS_COOKIEVERF seems to be more of an obfuscation
than a helper, so the best thing would be to just get rid of it.

Also see: https://bugzilla.kernel.org/show_bug.cgi?id=46881

Reported-by: Andi Kleen 
Reported-by: David Binderman 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

NFSv3: Ensure that do_proc_get_root() reports errors correctly

2012-08-20T16:52:42+00:00

If the rpc call to NFS3PROC_FSINFO fails, then we need to report that
error so that the mount fails. Otherwise we can end up with a
superblock with completely unusable values for block sizes, maxfilesize,
etc.

Reported-by: Yuanming Chen 
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust

NFSv4: Ensure that nfs4_alloc_client cleans up on error.

2012-08-20T16:12:29+00:00

Any pointer that was allocated through nfs_alloc_client() needs to be
freed via a call to nfs_free_client().

Reported-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: return -ENOKEY when the upcall fails to map the name

2012-08-16T21:20:06+00:00

This allows the normal error-paths to handle the error, rather than
making a special call to complete_request_key() just for this instance.

Signed-off-by: Bryan Schumaker 
Tested-by: William Dauchy 
Cc: stable@vger.kernel.org [>= 3.4]
Signed-off-by: Trond Myklebust

NFS: Clear key construction data if the idmap upcall fails

2012-08-16T21:20:02+00:00

idmap_pipe_downcall already clears this field if the upcall succeeds,
but if it fails (rpc.idmapd isn't running) the field will still be set
on the next call triggering a BUG_ON().  This patch tries to handle all
possible ways that the upcall could fail and clear the idmap key data
for each one.

Signed-off-by: Bryan Schumaker 
Tested-by: William Dauchy 
Cc: stable@vger.kernel.org [>= 3.4]
Signed-off-by: Trond Myklebust