linux-toradex.git/fs/nfs, branch v4.3

NFS: Fix a tracepoint NULL-pointer dereference

2015-10-06T22:56:25+00:00

Running xfstest generic/013 with the tracepoint nfs:nfs4_open_file
enabled produces a NULL-pointer dereference when calculating fileid and
filehandle of the opened file.  Fix this by checking if state is NULL
before trying to use the inode pointer.

Reported-by: Olga Kornievskaia 
Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

nfs4: reset states to use open_stateid when returning delegation voluntarily

2015-10-02T19:43:07+00:00

When the client goes to return a delegation, it should always update any
nfs4_state currently set up to use that delegation stateid to instead
use the open stateid. It already does do this in some cases,
particularly in the state recovery code, but not currently when the
delegation is voluntarily returned (e.g. in advance of a RENAME).  This
causes the client to try to continue using the delegation stateid after
the DELEGRETURN, e.g. in LAYOUTGET.

Set the nfs4_state back to using the open stateid in
nfs4_open_delegation_recall, just before clearing the
NFS_DELEGATED_STATE bit.

Signed-off-by: Jeff Layton 
Signed-off-by: Trond Myklebust

NFSv4: Fix a nograce recovery hang

2015-10-02T19:43:07+00:00

Since commit 5cae02f42793130e1387f4ec09c4d07056ce9fa5 an OPEN_CONFIRM should
have a privileged sequence in the recovery case to allow nograce recovery to
proceed for NFSv4.0.

Signed-off-by: Benjamin Coddington 
Signed-off-by: Trond Myklebust

NFSv4.1: nfs4_opendata_check_deleg needs to handle NFS4_OPEN_CLAIM_DELEG_CUR_FH

2015-10-02T19:43:07+00:00

We need to warn against broken NFSv4.1 servers that try to hand out
delegations in response to NFS4_OPEN_CLAIM_DELEG_CUR_FH.

Signed-off-by: Trond Myklebust

NFSv4: Don't try to reclaim unused state owners

2015-10-02T19:43:07+00:00

Currently, we don't test if the state owner is in use before we try to
recover it. The problem is that if the refcount is zero, then the
state owner will be waiting on the lru list for garbage collection.
The expectation in that case is that if you bump the refcount, then
you must also remove the state owner from the lru list. Otherwise
the call to nfs4_put_state_owner will corrupt that list by trying
to add our state owner a second time.

Avoid the whole problem by just skipping state owners that hold no
state.

Reported-by: Andrew W Elble 
Signed-off-by: Trond Myklebust

NFS: Fix a write performance regression

2015-10-02T19:43:07+00:00

If all other conditions in nfs_can_extend_write() are met, and there
are no locks, then we should be able to assume close-to-open semantics
and the ability to extend our write to cover the whole page.

With this patch, the xfstests generic/074 test completes in 242s instead
of >1400s on my test rig.

Fixes: bd61e0a9c852 ("locks: convert posix locks to file_lock_context")
Cc: Jeff Layton 
Signed-off-by: Trond Myklebust

NFS: Fix up page writeback accounting

2015-10-02T19:43:07+00:00

Currently, we are crediting all the calls to nfs_writepages_callback()
(i.e. the nfs_writepages() callback) to nfs_writepage(). Aside from
being inconsistent with the behaviour of the equivalent readpage/readpages
accounting, this also means that we cannot distinguish between bulk writes
and single page writebacks (which confuses the 'nfsiostat -p' tool).

Signed-off-by: Trond Myklebust

NFS41: make close wait for layoutreturn

2015-09-23T12:55:32+00:00

If we send a layoutreturn asynchronously before close, the close
might reach server first and layoutreturn would fail with BADSTATEID
because there is nothing keeping the layout stateid alive.

Also do not pretend sending layoutreturn if we are not.

Signed-off-by: Peng Tao 
Signed-off-by: Trond Myklebust

NFS: Skip checking ds_cinfo.buckets when lseg's commit_through_mds is set

2015-09-22T22:09:14+00:00

When lseg's commit_through_mds is set, pnfs client always WARN once
in nfs_direct_select_verf after checking ds_cinfo.nbuckets.

nfs should use the DS verf except commit_through_mds is set for
layout segment where nbuckets is zero.

[17844.666094] ------------[ cut here ]------------
[17844.667071] WARNING: CPU: 0 PID: 21758 at /root/source/linux-pnfs/fs/nfs/direct.c:174 nfs_direct_select_verf+0x5a/0x70 [nfs]()
[17844.668650] Modules linked in: nfs_layout_nfsv41_files(OE) nfsv4(OE) nfs(OE) fscache(E) nfsd(OE) xfs libcrc32c btrfs ppdev coretemp crct10dif_pclmul auth_rpcgss crc32_pclmul crc32c_intel nfs_acl ghash_clmulni_intel lockd vmw_balloon xor vmw_vmci grace raid6_pq shpchp sunrpc parport_pc i2c_piix4 parport vmwgfx drm_kms_helper ttm drm serio_raw mptspi e1000 scsi_transport_spi mptscsih mptbase ata_generic pata_acpi [last unloaded: fscache]
[17844.686676] CPU: 0 PID: 21758 Comm: kworker/0:1 Tainted: G        W  OE   4.3.0-rc1-pnfs+ #245
[17844.687352] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/20/2014
[17844.698502] Workqueue: nfsiod rpc_async_release [sunrpc]
[17844.699212]  0000000000000009 0000000043e58010 ffff8800454fbc10 ffffffff813680c4
[17844.699990]  ffff8800454fbc48 ffffffff8108b49d ffff88004eb20000 ffff88004eb20000
[17844.700844]  ffff880062e26000 0000000000000000 0000000000000001 ffff8800454fbc58
[17844.701637] Call Trace:
[17844.725252]  [] dump_stack+0x19/0x25
[17844.732693]  [] warn_slowpath_common+0x7d/0xb0
[17844.733855]  [] warn_slowpath_null+0x1a/0x20
[17844.735015]  [] nfs_direct_select_verf+0x5a/0x70 [nfs]
[17844.735999]  [] nfs_direct_set_hdr_verf+0x23/0x90 [nfs]
[17844.736846]  [] nfs_direct_write_completion+0x227/0x260 [nfs]
[17844.737782]  [] nfs_pgio_release+0x1c/0x20 [nfs]
[17844.738597]  [] pnfs_generic_rw_release+0x23/0x30 [nfsv4]
[17844.739486]  [] rpc_free_task+0x2a/0x70 [sunrpc]
[17844.740326]  [] rpc_async_release+0x15/0x20 [sunrpc]
[17844.741173]  [] process_one_work+0x21c/0x4c0
[17844.741984]  [] ? process_one_work+0x16d/0x4c0
[17844.742837]  [] worker_thread+0x4a/0x440
[17844.743639]  [] ? process_one_work+0x4c0/0x4c0
[17844.744399]  [] ? process_one_work+0x4c0/0x4c0
[17844.745176]  [] kthread+0xf5/0x110
[17844.745927]  [] ? kthread_create_on_node+0x240/0x240
[17844.747105]  [] ret_from_fork+0x3f/0x70
[17844.747856]  [] ? kthread_create_on_node+0x240/0x240
[17844.748642] ---[ end trace 336a2845d42b83f0 ]---

Signed-off-by: Kinglong Mee 
Signed-off-by: Trond Myklebust

NFSv4.x/pnfs: Don't try to recover stateids twice in layoutget

2015-09-21T02:34:35+00:00

If the current open or layout stateid doesn't match the stateid used
in the layoutget RPC call, then don't try to recover it.

Signed-off-by: Trond Myklebust