linux-toradex.git/fs/nfsd/state.h, branch v3.2.28

nfsd41: use SEQ4_STATUS_BACKCHANNEL_FAULT when cb_sequence is invalid

2011-10-24T08:24:27+00:00

Signed-off-by: Benny Halevy 
Signed-off-by: J. Bruce Fields

nfsd4: do idr preallocation with stateid allocation

2011-10-17T21:50:07+00:00

Move idr preallocation out of stateid initialization, into stateid
allocation, so that we no longer have to handle any errors from the
former.

This is a little subtle due to the way the idr code manages these
preallocated items--document that in comments.

Signed-off-by: J. Bruce Fields

nfsd4: clean up open owners on OPEN failure

2011-10-17T21:33:57+00:00

If process_open1() creates a new open owner, but the open later fails,
the current code will leave the open owner around.  It won't be on the
close_lru list, and the client isn't expected to send a CLOSE, so it
will hang around as long as the client does.

Similarly, if process_open1() removes an existing open owner from the
close lru, anticipating that an open owner that previously had no
associated stateid's now will, but the open subsequently fails, then
we'll again be left with the same leak.

Fix both problems.

Reported-by: Bryan Schumaker 
Signed-off-by: J. Bruce Fields

nfsd4: make is_open_owner boolean

2011-10-17T21:09:37+00:00

Signed-off-by: J. Bruce Fields

nfsd4: cleanup state.h comments

2011-10-10T22:04:46+00:00

These comments are mostly out of date.

Reported-by: Bryan Schumaker

nfsd4: clean up downgrading code

2011-10-10T22:04:45+00:00

In response to some review comments, get rid of the somewhat obscure
for-loop with bitops, and improve a comment.

Reported-by: Steve Dickson 
Signed-off-by: J. Bruce Fields

nfsd4: look up stateid's per clientid

2011-09-26T21:35:28+00:00

Use a separate stateid idr per client, and lookup a stateid by first
finding the client, then looking up the stateid relative to that client.

Also some minor refactoring.

This allows us to improve error returns: we can return expired when the
clientid is not found and bad_stateid when the clientid is found but not
the stateid, as opposed to returning expired for both cases.

I hope this will also help to replace the state lock mostly by a
per-client lock, but that hasn't been done yet.

Signed-off-by: J. Bruce Fields

nfsd4: assume test_stateid always has session

2011-09-26T21:35:27+00:00

Test_stateid is 4.1-only and only allowed after a sequence operation, so
this check is unnecessary.

Cc: Bryan Schumaker 
Signed-off-by: J. Bruce Fields

nfsd4: use idr for stateid's

2011-09-26T21:35:26+00:00

The idr system is designed exactly for generating id and looking up
integer id's.  Thanks to Trond for pointing it out.

Signed-off-by: J. Bruce Fields

nfsd4: move client * to nfs4_stateid, add init_stid helper

2011-09-26T21:35:25+00:00

This will be convenient.

Signed-off-by: J. Bruce Fields