linux-toradex.git/fs/nfsd/state.h, branch v3.6.4

nfsd4: fix security flavor of NFSv4.0 callback

2012-08-20T22:38:36+00:00

Commit d5497fc693a446ce9100fcf4117c3f795ddfd0d2 "nfsd4: move rq_flavor
into svc_cred" forgot to remove cl_flavor from the client, leaving two
places (cl_flavor and cl_cred.cr_flavor) for the flavor to be stored.
After that patch, the latter was the one that was updated, but the
former was the one that the callback used.

Symptoms were a long delay on utime().  This is because the utime()
generated a setattr which recalled a delegation, but the cb_recall was
ignored by the client because it had the wrong security flavor.

Cc: stable@vger.kernel.org
Tested-by: Jamie Heilman 
Reported-by: Jamie Heilman 
Signed-off-by: J. Bruce Fields

NFSd: make boot_time variable per network namespace

2012-07-27T20:49:22+00:00

NFSd's boot_time represents grace period start point in time.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

LockD: pass actual network namespace to grace period management functions

2012-07-27T20:49:22+00:00

Passed network namespace replaced hard-coded init_net

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: J. Bruce Fields

NFSD: TEST_STATEID should not return NFS4ERR_STALE_STATEID

2012-06-20T12:59:40+00:00

According to RFC 5661, the TEST_STATEID operation is not allowed to
return NFS4ERR_STALE_STATEID.  In addition, RFC 5661 says:

15.1.16.5.  NFS4ERR_STALE_STATEID (Error Code 10023)

   A stateid generated by an earlier server instance was used.  This
   error is moot in NFSv4.1 because all operations that take a stateid
   MUST be preceded by the SEQUENCE operation, and the earlier server
   instance is detected by the session infrastructure that supports
   SEQUENCE.

I triggered NFS4ERR_STALE_STATEID while testing the Linux client's
NOGRACE recovery.  Bruce suggested an additional test that could be
useful to client developers.

Lastly, RFC 5661, section 18.48.3 has this:

 o  Special stateids are always considered invalid (they result in the
    error code NFS4ERR_BAD_STATEID).

An explicit check is made for those state IDs to avoid printk noise.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

nfsd4: move principal name into svc_cred

2012-06-01T00:29:55+00:00

Instead of keeping the principal name associated with a request in a
structure that's private to auth_gss and using an accessor function,
move it to svc_cred.

Signed-off-by: J. Bruce Fields

nfsd: add nfsd4_client_tracking_ops struct and a way to set it

2012-03-26T15:49:47+00:00

Abstract out the mechanism that we use to track clients into a set of
client name tracking functions.

This gives us a mechanism to plug in a new set of client tracking
functions without disturbing the callers. It also gives us a way to
decide on what tracking scheme to use at runtime.

For now, this just looks like pointless abstraction, but later we'll
add a new alternate scheme for tracking clients on stable storage.

Note too that this patch anticipates the eventual containerization
of this code by passing in struct net pointers in places. No attempt
is made to containerize the legacy client tracker however.

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd: convert nfs4_client->cl_cb_flags to a generic flags field

2012-03-26T15:49:47+00:00

We'll need a way to flag the nfs4_client as already being recorded on
stable storage so that we don't continually upcall. Currently, that's
recorded in the cl_firststate field of the client struct. Using an
entire u32 to store a flag is rather wasteful though.

The cl_cb_flags field is only using 2 bits right now, so repurpose that
to a generic flags field. Rename NFSD4_CLIENT_KILL to
NFSD4_CLIENT_CB_KILL to make it evident that it's part of the callback
flags. Add a mask that we can use for existing checks that look to see
whether any flags are set, so that the new flags don't interfere.

Convert all references to cl_firstate to the NFSD4_CLIENT_STABLE flag,
and add a new NFSD4_CLIENT_RECLAIM_COMPLETE flag.

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd41: free_session/free_client must be called under the client_lock

2012-03-06T23:13:35+00:00

The session client is manipulated under the client_lock hence
both free_session and nfsd4_del_conns must be called under this lock.

This patch adds a BUG_ON that checks this condition in the
respective functions and implements the missing locks.

nfsd4_{get,put}_session helpers were moved to the C file that uses them
so to prevent use from external files and an unlocked version of
nfsd4_put_session is provided for external use from nfs4xdr.c

Signed-off-by: Benny Halevy 
Signed-off-by: J. Bruce Fields

nfsd4: check for uninitialized slot

2012-02-14T22:01:58+00:00

This fixes an oops when a buggy client tries to use an initial seqid of
0 on a new slot, which we may misinterpret as a replay.

Signed-off-by: J. Bruce Fields

nfsd4: rearrange struct nfsd4_slot

2012-02-14T22:01:29+00:00

Combine two booleans into a single flag field, move the smaller fields
to the end.

(In practice this doesn't make the struct any smaller.  But we'll be
adding another flag here soon.)

Remove some debugging code that doesn't look useful, while we're in the
neighborhood.

Signed-off-by: J. Bruce Fields