linux-toradex.git/fs/nfsd, branch v4.2-rc4

nfsd: wrap too long lines in nfsd4_encode_read

2015-06-22T18:15:05+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

nfsd: fput rd_file from XDR encode context

2015-06-22T18:15:04+00:00

Remove the hack where we fput the read-specific file in generic code.
Instead we can do it in nfsd4_encode_read as that gets called for all
error cases as well.

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

nfsd: take struct file setup fully into nfs4_preprocess_stateid_op

2015-06-22T18:15:03+00:00

This patch changes nfs4_preprocess_stateid_op so it always returns
a valid struct file if it has been asked for that.  For that we
now allocate a temporary struct file for special stateids, and check
permissions if we got the file structure from the stateid.  This
ensures that all callers will get their handling of special stateids
right, and avoids code duplication.

There is a little wart in here because the read code needs to know
if we allocated a file structure so that it can copy around the
read-ahead parameters.  In the long run we should probably aim to
cache full file structures used with special stateids instead.

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

nfsd: refactor nfs4_preprocess_stateid_op

2015-06-19T19:39:52+00:00

Split out two self contained helpers to make the function more readable.

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

nfsd: clean up raparams handling

2015-06-19T19:39:51+00:00

Refactor the raparam hash helpers to just deal with the raparms,
and keep opening/closing files separate from that.

Signed-off-by: Christoph Hellwig 
Signed-off-by: J. Bruce Fields

nfsd: use swap() in sort_pacl_range()

2015-06-19T19:39:50+00:00

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick 
Signed-off-by: J. Bruce Fields

nfsd: Update callback sequnce id only CB_SEQUENCE success

2015-06-04T20:51:30+00:00

When testing pnfs layout, nfsd got error NFS4ERR_SEQ_MISORDERED.
It is caused by nfs return NFS4ERR_DELAY before validate_seqid(),
don't update the sequnce id, but nfsd updates the sequnce id !!!

According to RFC5661 20.9.3,
" If CB_SEQUENCE returns an error, then the state of the slot
(sequence ID, cached reply) MUST NOT change. "

Signed-off-by: Kinglong Mee 
Signed-off-by: J. Bruce Fields

nfsd: Reset cb_status in nfsd4_cb_prepare() at retrying

2015-06-04T20:43:39+00:00

nfsd enters a infinite loop and prints message every 10 seconds:

May 31 18:33:52 test-server kernel: Error sending entire callback!
May 31 18:34:01 test-server kernel: Error sending entire callback!

This is caused by a cb_layoutreturn getting error -10008
(NFS4ERR_DELAY), the client crashing, and then nfsd entering the
infinite loop:

  bc_sendto --> call_timeout --> nfsd4_cb_done --> nfsd4_cb_layout_done
  with error -10008 --> rpc_delay(task, HZ/100) --> bc_sendto ...

Reproduced using xfstests 074 with nfs client's kdump on,
CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set, and client's blkmapd down:

1. nfs client's write operation will get the layout of file,
   and then send getdeviceinfo,
2. but layout segment is not recorded by client because blkmapd is down,
3. client writes data by sending WRITE to server,
4. nfs server recalls the layout of the file before WRITE,
5. network error causes the client reset the session and return NFS4ERR_DELAY,
6. so client's WRITE operation is waiting the reply.
   If the task hangs 120s, the client will crash.
7. so that, the next bc_sendto will fail with TIMEOUT,
   and cb_status is NFS4ERR_DELAY.

Signed-off-by: Kinglong Mee 
Signed-off-by: J. Bruce Fields

nfsd: Remove dead declarations

2015-05-29T15:04:04+00:00

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: J. Bruce Fields

nfsd: work around a gcc-5.1 warning

2015-05-29T15:04:03+00:00

gcc-5.0 warns about a potential uninitialized variable use in nfsd:

fs/nfsd/nfs4state.c: In function 'nfsd4_process_open2':
fs/nfsd/nfs4state.c:3781:3: warning: 'old_deny_bmap' may be used uninitialized in this function [-Wmaybe-uninitialized]
   reset_union_bmap_deny(old_deny_bmap, stp);
   ^
fs/nfsd/nfs4state.c:3760:16: note: 'old_deny_bmap' was declared here
  unsigned char old_deny_bmap;
                ^

This is a false positive, the code path that is warned about cannot
actually be reached.

This adds an initialization for the variable to make the warning go
away.

Signed-off-by: Arnd Bergmann 
Signed-off-by: J. Bruce Fields