linux-toradex.git/fs/nilfs2/btnode.c, branch v2.6.32.2

nilfs2: add zero-fill for new btree node buffers

2009-11-03T03:32:03+00:00

Adds missing initialization of newly allocated b-tree node buffers.
This avoids garbage data to be mixed in b-tree node blocks.

Signed-off-by: Ryusuke Konishi

nilfs2: fix dirty page accounting leak causing hang at write

2009-11-03T03:31:36+00:00

Bruno Prémont and Dunphy, Bill noticed me that NILFS will certainly
hang on ARM-based targets.

I found this was caused by an underflow of dirty pages counter.  A
b-tree cache routine was marking page dirty without adjusting page
account information.

This fixes the dirty page accounting leak and resolves the hang on
arm-based targets.

Reported-by: Bruno Prémont 
Reported-by: Dunphy, Bill 
Signed-off-by: Ryusuke Konishi 
Tested-by: Bruno Prémont 
Cc: stable

nilfs2: fix missing zero-fill initialization of btree node cache

2009-09-29T11:12:56+00:00

This will fix file system corruption which infrequently happens after
mount.  The problem was reported from users with the title "[NILFS
users] Fail to mount NILFS." (Message-ID:
<200908211918.34720.yuri@itinteg.net>), and so forth.  I've also
experienced the corruption multiple times on kernel 2.6.30 and 2.6.31.

The problem turned out to be caused due to discordance between
mapping->nrpages of a btree node cache and the actual number of pages
hung on the cache; if the mapping->nrpages becomes zero even as it has
pages, truncate_inode_pages() returns without doing anything.  Usually
this is harmless except it may cause page leak, but garbage collection
fairly infrequently sees a stale page remained in the btree node cache
of DAT (i.e. disk address translation file of nilfs), and induces the
corruption.

I identified a missing initialization in btree node caches was the
root cause.  This corrects the bug.

I've tested this for kernel 2.6.30 and 2.6.31.

Reported-by: Yuri Chislov 
Signed-off-by: Ryusuke Konishi 
Cc: stable

const: mark remaining address_space_operations const

2009-09-22T14:17:24+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

nilfs2: fix preempt count underflow in nilfs_btnode_prepare_change_key

2009-08-31T03:03:06+00:00

This will fix the following preempt count underflow reported from
users with the title "[NILFS users] segctord problem" (Message-ID:
<949415.6494.qm@web58808.mail.re1.yahoo.com> and Message-ID:
):

 WARNING: at kernel/sched.c:4890 sub_preempt_count+0x95/0xa0()
 Hardware name: HP Compaq 6530b (KR980UT#ABC)
 Modules linked in: bridge stp llc bnep rfcomm l2cap xfs exportfs nilfs2 cowloop loop vboxnetadp vboxnetflt vboxdrv btusb bluetooth uvcvideo videodev v4l1_compat v4l2_compat_ioctl32 arc4 snd_hda_codec_analog ecb iwlagn iwlcore rfkill lib80211 mac80211 snd_hda_intel snd_hda_codec ehci_hcd uhci_hcd usbcore snd_hwdep snd_pcm tg3 cfg80211 psmouse snd_timer joydev libphy ohci1394 snd_page_alloc hp_accel lis3lv02d ieee1394 led_class i915 drm i2c_algo_bit video backlight output i2c_core dm_crypt dm_mod
 Pid: 4197, comm: segctord Not tainted 2.6.30-gentoo-r4-64 #7
 Call Trace:
  [] ? sub_preempt_count+0x95/0xa0
  [] warn_slowpath_common+0x78/0xd0
  [] warn_slowpath_null+0xf/0x20
  [] sub_preempt_count+0x95/0xa0
  [] nilfs_btnode_prepare_change_key+0x11b/0x190 [nilfs2]
  [] nilfs_btree_assign_p+0x19d/0x1e0 [nilfs2]
  [] nilfs_btree_assign+0xbd/0x130 [nilfs2]
  [] nilfs_bmap_assign+0x47/0x70 [nilfs2]
  [] nilfs_segctor_do_construct+0x956/0x20f0 [nilfs2]
  [] ? _spin_unlock_irqrestore+0x12/0x40
  [] ? __up_write+0xe0/0x150
  [] ? up_write+0x9/0x10
  [] ? nilfs_bmap_test_and_clear_dirty+0x43/0x60 [nilfs2]
  [] ? nilfs_mdt_fetch_dirty+0x27/0x60 [nilfs2]
  [] nilfs_segctor_construct+0x8c/0xd0 [nilfs2]
  [] nilfs_segctor_thread+0x15c/0x3a0 [nilfs2]
  [] ? nilfs_construction_timeout+0x0/0x10 [nilfs2]
  [] ? add_timer+0x13/0x20
  [] ? __wake_up_common+0x5a/0x90
  [] ? autoremove_wake_function+0x0/0x40
  [] ? nilfs_segctor_thread+0x0/0x3a0 [nilfs2]
  [] ? nilfs_segctor_thread+0x0/0x3a0 [nilfs2]
  [] kthread+0x56/0x90
  [] child_rip+0xa/0x20
  [] ? kthread+0x0/0x90
  [] ? child_rip+0x0/0x20

This problem was caused due to a missing radix_tree_preload() call in
the retry path of nilfs_btnode_prepare_change_key() function.

Reported-by: Eric A 
Reported-by: Jerome Poulin 
Signed-off-by: Ryusuke Konishi 
Tested-by: Jerome Poulin 
Cc: stable@kernel.org

nilfs2: add sync_page method to page caches of meta data

2009-06-10T14:41:12+00:00

This applies block_sync_page() function to the sync_page method of
page caches for meta data files, gc page caches, and btree node
buffers.  This is a companion patch of ("nilfs2: enable sync_page
mothod") which applied the function for data pages.

This allows lock_page() for those meta data to unplug pending bio
requests.

Signed-off-by: Ryusuke Konishi

nilfs2: use device's backing_dev_info for btree node caches

2009-06-10T14:41:12+00:00

Previously, default_backing_dev_info was used for the mapping of btree
node caches.  This uses device dependent backing_dev_info to allow
detailed control of the device for the btree node pages.

Signed-off-by: Ryusuke Konishi

nilfs2: B-tree node cache

2009-04-07T15:31:13+00:00

This adds routines for B-tree node buffers.

Signed-off-by: Seiji Kihara 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds