linux-toradex.git/fs/nilfs2/super.c, branch v2.6.32.33

nilfs2: fix sync silent failure

2010-05-26T21:29:21+00:00

commit 973bec34bfc1bc2465646181653d67f767d418c8 upstream.

As of 32a88aa1, __sync_filesystem() will return 0 if s_bdi is not set.
And nilfs does not set s_bdi anywhere.  I noticed this problem by the
warning introduced by the recent commit 5129a469 ("Catch filesystem
lacking s_bdi").

 WARNING: at fs/super.c:959 vfs_kern_mount+0xc5/0x14e()
 Hardware name: PowerEdge 2850
 Modules linked in: nilfs2 loop tpm_tis tpm tpm_bios video shpchp pci_hotplug output dcdbas
 Pid: 3773, comm: mount.nilfs2 Not tainted 2.6.34-rc6-debug #38
 Call Trace:
  [] warn_slowpath_common+0x60/0x90
  [] warn_slowpath_null+0xd/0x10
  [] vfs_kern_mount+0xc5/0x14e
  [] do_kern_mount+0x32/0xbd
  [] do_mount+0x671/0x6d0
  [] ? __get_free_pages+0x1f/0x21
  [] ? copy_mount_options+0x2b/0xe2
  [] ? strndup_user+0x48/0x67
  [] sys_mount+0x61/0x8f
  [] sysenter_do_call+0x12/0x32

This ensures to set s_bdi for nilfs and fixes the sync silent failure.

Signed-off-by: Ryusuke Konishi 
Acked-by: Jens Axboe 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

const: mark remaining export_operations const

2009-09-22T14:17:24+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

const: mark remaining super_operations const

2009-09-22T14:17:24+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

nilfs2: remove individual gfp constants for each metadata file

2009-09-14T09:27:15+00:00

This gets rid of NILFS_CPFILE_GFP, NILFS_SUFILE_GFP, NILFS_DAT_GFP,
and NILFS_IFILE_GFP.  All of these constants refer to NILFS_MDT_GFP,
and can be removed.

Signed-off-by: Ryusuke Konishi

nilfs2: add more check routines in mount process

2009-09-14T09:27:14+00:00

nilfs2: Add more safeguard routines and protections in mount process,
which also makes nilfs2 report consistency error messages when
checkpoint number is invalid.

Signed-off-by: Zhu Yanhai 
Signed-off-by: Ryusuke Konishi

nilfs2: An unassigned variable is assigned to a never used structure member

2009-09-14T09:27:14+00:00

nilfs2: In procedure 'nilfs_get_sb()', when a nilfs filesysttem is
mounted for the first time, local variable 'nilfs->ns_last_cno' is
used before loading the latest checkpoint number from disk (in
'nilfs_fill_super'). 'nilfs->ns_last_cno' is assigned to 'sd.cno', but
'sd.cno' has never been used in the procedure.

Signed-off-by: Zhang Qiang 
Signed-off-by: Ryusuke Konishi

nilfs2: stop using periodic write_super callback

2009-09-14T09:27:14+00:00

This removes nilfs_write_super and commit super block in nilfs
internal thread, instead of periodic write_super callback.

VFS layer calls ->write_super callback periodically.  However,
it looks like that calling back is ommited when disk I/O is busy.
And when cleanerd (nilfs GC) is runnig, disk I/O tend to be busy thus
nilfs superblock is not synchronized as nilfs designed.

To avoid it, syncing superblock by nilfs thread instead of pdflush.

Signed-off-by: Jiro SEKIBA 
Signed-off-by: Ryusuke Konishi

nilfs2: clean up nilfs_write_super

2009-09-14T09:27:14+00:00

Separate conditions that check if syncing super block and alternative
super block are required as inline functions to reuse the conditions.

Signed-off-by: Jiro SEKIBA 
Signed-off-by: Ryusuke Konishi

nilfs2: fix disorder of nilfs_write_super in nilfs_sync_fs

2009-09-14T09:27:14+00:00

This fixes disorder of nilfs_write_super in nilfs_sync_fs.  Commiting
super block must be the end of the function so that every changes are
reflected.

->sync_fs() is not called frequently so this makes nilfs_sync_fs call
nilfs_commit_super instead of nilfs_write_super.

Signed-off-by: Jiro SEKIBA 
Signed-off-by: Ryusuke Konishi

nilfs2: remove redundant super block commit

2009-09-14T09:27:13+00:00

This removes redundant super block commit.

nilfs_write_super will call nilfs_commit_super to store super block
into block device.  However, nilfs_put_super will call
nilfs_commit_super right after calling nilfs_write_super.  So calling
nilfs_write_super in nilfs_put_super would be redundant.

Signed-off-by: Jiro SEKIBA 
Signed-off-by: Ryusuke Konishi