linux-toradex.git/fs/nilfs2, branch v2.6.32.2

nilfs2: deleted inconsistent comment in nilfs_load_inode_block()

2009-11-15T08:17:46+00:00

The comment says, "Caller of this function MUST lock s_inode_lock",
however just above the comment, it locks s_inode_lock in the function.

Signed-off-by: Jiro SEKIBA 
Signed-off-by: Ryusuke Konishi

nilfs2: fix lock order reversal in chcp operation

2009-11-13T01:33:24+00:00

Will fix the following lock order reversal lockdep detected:

=======================================================
[ INFO: possible circular locking dependency detected ]
2.6.32-rc6 #7
-------------------------------------------------------
chcp/30157 is trying to acquire lock:
 (&nilfs->ns_mount_mutex){+.+.+.}, at: [] nilfs_cpfile_change_cpmode+0x46/0x752 [nilfs2]

but task is already holding lock:
 (&nilfs->ns_segctor_sem){++++.+}, at: [] nilfs_transaction_begin+0xba/0x110 [nilfs2]

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #2 (&nilfs->ns_segctor_sem){++++.+}:
       [] __lock_acquire+0x109c/0x139d
       [] lock_acquire+0x89/0xa0
       [] down_read+0x31/0x45
       [] nilfs_attach_checkpoint+0x8f/0x16b [nilfs2]
       [] nilfs_get_sb+0x3e7/0x653 [nilfs2]
       [] vfs_kern_mount+0x8b/0x124
       [] do_kern_mount+0x37/0xc3
       [] do_mount+0x64d/0x69d
       [] sys_mount+0x66/0x95
       [] sysenter_do_call+0x12/0x32

-> #1 (&type->s_umount_key#31/1){+.+.+.}:
       [] __lock_acquire+0x109c/0x139d
       [] lock_acquire+0x89/0xa0
       [] down_write_nested+0x34/0x52
       [] sget+0x22e/0x389
       [] nilfs_get_sb+0x187/0x653 [nilfs2]
       [] vfs_kern_mount+0x8b/0x124
       [] do_kern_mount+0x37/0xc3
       [] do_mount+0x64d/0x69d
       [] sys_mount+0x66/0x95
       [] sysenter_do_call+0x12/0x32

-> #0 (&nilfs->ns_mount_mutex){+.+.+.}:
       [] __lock_acquire+0xe27/0x139d
       [] lock_acquire+0x89/0xa0
       [] mutex_lock_nested+0x41/0x23e
       [] nilfs_cpfile_change_cpmode+0x46/0x752 [nilfs2]
       [] nilfs_ioctl+0x11a/0x7da [nilfs2]
       [] vfs_ioctl+0x27/0x6e
       [] do_vfs_ioctl+0x491/0x4db
       [] sys_ioctl+0x45/0x5f
       [] sysenter_do_call+0x12/0x32

Signed-off-by: Ryusuke Konishi

nilfs2: fix missing cleanup of gc cache on error cases

2009-11-08T10:04:25+00:00

This fixes an -rc1 regression brought by the commit:
1cf58fa840472ec7df6bf2312885949ebb308853 ("nilfs2: shorten freeze
period due to GC in write operation v3").

Although the patch moved out a function call of
nilfs_ioctl_move_blocks() to nilfs_ioctl_clean_segments() from
nilfs_ioctl_prepare_clean_segments(), it didn't move corresponding
cleanup job needed for the error case.

This will move the missing cleanup job to the destination function.

Signed-off-by: Ryusuke Konishi 
Acked-by: Jiro SEKIBA

nilfs2: fix kernel oops in error case of nilfs_ioctl_move_blocks

2009-11-08T10:01:35+00:00

This fixes a kernel oops reported by Markus Trippelsdorf in the email
titled "[NILFS users] kernel Oops while running nilfs_cleanerd".

The oops was caused by a bug of error path in
nilfs_ioctl_move_blocks() function, which was inlined in
nilfs_ioctl_clean_segments().

nilfs_ioctl_move_blocks checks duplication of blocks which will be
moved in garbage collection.  But, the check should have be done
within nilfs_ioctl_move_inode_block() to prevent list corruption among
buffers storing the target blocks.

To fix the kernel oops, this moves forward the duplication check
before the list insertion.

I also tested this for stable trees [2.6.30, 2.6.31].

Reported-by: Markus Trippelsdorf 
Signed-off-by: Ryusuke Konishi 
Cc: stable

nilfs2: add zero-fill for new btree node buffers

2009-11-03T03:32:03+00:00

Adds missing initialization of newly allocated b-tree node buffers.
This avoids garbage data to be mixed in b-tree node blocks.

Signed-off-by: Ryusuke Konishi

nilfs2: fix irregular checkpoint creation due to data flush

2009-11-03T03:32:03+00:00

When nilfs flushes out dirty data to reduce memory pressure, creation
of checkpoints is wrongly postponed.  This bug causes irregular
checkpoint creation especially in small footprint systems.

To correct this issue, a timer for the checkpoint creation has to be
continued if a log writer does not create a checkpoint.

This will do the correction.

Signed-off-by: Ryusuke Konishi

nilfs2: fix dirty page accounting leak causing hang at write

2009-11-03T03:31:36+00:00

Bruno Prémont and Dunphy, Bill noticed me that NILFS will certainly
hang on ARM-based targets.

I found this was caused by an underflow of dirty pages counter.  A
b-tree cache routine was marking page dirty without adjusting page
account information.

This fixes the dirty page accounting leak and resolves the hang on
arm-based targets.

Reported-by: Bruno Prémont 
Reported-by: Dunphy, Bill 
Signed-off-by: Ryusuke Konishi 
Tested-by: Bruno Prémont 
Cc: stable

const: constify remaining file_operations

2009-10-01T23:11:11+00:00

[akpm@linux-foundation.org: fix KVM]
Signed-off-by: Alexey Dobriyan 
Acked-by: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

nilfs2: fix missing initialization of i_dir_start_lookup member

2009-09-29T11:32:13+00:00

The i_dir_start_lookup field in nilfs_inode_info objects should be
cleared when the objects are allocated, but the the initialization was
missing in case of reading from disk.  This adds the initialization.

Since the variable just gives a start page on directory lookups, the
bug was nonfatal until now.

Signed-off-by: Ryusuke Konishi

nilfs2: fix missing zero-fill initialization of btree node cache

2009-09-29T11:12:56+00:00

This will fix file system corruption which infrequently happens after
mount.  The problem was reported from users with the title "[NILFS
users] Fail to mount NILFS." (Message-ID:
<200908211918.34720.yuri@itinteg.net>), and so forth.  I've also
experienced the corruption multiple times on kernel 2.6.30 and 2.6.31.

The problem turned out to be caused due to discordance between
mapping->nrpages of a btree node cache and the actual number of pages
hung on the cache; if the mapping->nrpages becomes zero even as it has
pages, truncate_inode_pages() returns without doing anything.  Usually
this is harmless except it may cause page leak, but garbage collection
fairly infrequently sees a stale page remained in the btree node cache
of DAT (i.e. disk address translation file of nilfs), and induces the
corruption.

I identified a missing initialization in btree node caches was the
root cause.  This corrects the bug.

I've tested this for kernel 2.6.30 and 2.6.31.

Reported-by: Yuri Chislov 
Signed-off-by: Ryusuke Konishi 
Cc: stable