linux-toradex.git/fs/notify/dnotify, branch v4.16-rc6

dnotify: Handle errors from fsnotify_add_mark_locked() in fcntl_dirnotify()

2017-10-31T16:41:04+00:00

fsnotify_add_mark_locked() can fail but we do not check its return
value. This didn't matter before commit 9dd813c15b2c "fsnotify: Move
mark list head from object into dedicated structure" as none of possible
failures could happen for dnotify but after that commit -ENOMEM can be
returned. Handle this error properly in fcntl_dirnotify() as
otherwise we just hit BUG_ON(dn_mark->dn) in dnotify_free_mark().

Reviewed-by: Amir Goldstein 
Reported-by: syzkaller
Fixes: 9dd813c15b2c101168808d4f5941a29985758973
Signed-off-by: Jan Kara

fsnotify: make dnotify_fsnotify_ops const

2017-08-30T14:02:48+00:00

Make this const as it is never modified.

Signed-off-by: Bhumika Goyal 
Signed-off-by: Jan Kara

fsnotify: Move ->free_mark callback to fsnotify_ops

2017-04-10T15:37:36+00:00

Pointer to ->free_mark callback unnecessarily occupies one long in each
fsnotify_mark although they are the same for all marks from one
notification group. Move the callback pointer to fsnotify_ops.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Add group pointer in fsnotify_init_mark()

2017-04-10T15:37:36+00:00

Currently we initialize mark->group only in fsnotify_add_mark_lock().
However we will need to access fsnotify_ops of corresponding group from
fsnotify_put_mark() so we need mark->group initialized earlier. Do that
in fsnotify_init_mark() which has a consequence that once
fsnotify_init_mark() is called on a mark, the mark has to be destroyed
by fsnotify_put_mark().

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_find_{inode|vfsmount}_mark()

2017-04-10T15:37:36+00:00

These are very thin wrappers, just remove them. Drop
fs/notify/vfsmount_mark.c as it is empty now.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_set_mark_{,ignored_}mask_locked()

2017-04-10T15:37:36+00:00

These helpers are now only a simple assignment and just obfuscate
what is going on. Remove them.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Pass fsnotify_iter_info into handle_event handler

2017-04-10T15:37:36+00:00

Pass fsnotify_iter_info into ->handle_event() handler so that it can
release and reacquire SRCU lock via fsnotify_prepare_user_wait() and
fsnotify_finish_user_wait() functions.  These functions also make sure
current marks are appropriately pinned so that iteration protected by
srcu in fsnotify() stays safe.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Move locking into fsnotify_recalc_mask()

2017-04-10T15:37:35+00:00

Move locking of locks protecting a list of marks into
fsnotify_recalc_mask(). This reduces code churn in the following patch
which changes the lock protecting the list of marks.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Move object pointer to fsnotify_mark_connector

2017-04-10T15:37:35+00:00

Move pointer to inode / vfsmount from mark itself to the
fsnotify_mark_connector structure. This is another step on the path
towards decoupling inode / vfsmount lifetime from notification mark
lifetime.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: constify 'data' passed to ->handle_event()

2016-12-05T23:58:31+00:00

Signed-off-by: Al Viro