linux-toradex.git/fs/ocfs2/cluster, branch v3.12.11

ocfs2: fix a tiny race case when firing callbacks

2013-09-11T22:56:51+00:00

In o2hb_shutdown_slot() and o2hb_check_slot(), since event is defined as
local, it is only valid during the call stack.  So the following tiny race
case may happen in a multi-volumes mounted environment:

o2hb-vol1                         o2hb-vol2
1) o2hb_shutdown_slot
allocate local event1
2) queue_node_event
add event1 to global o2hb_node_events
                                  3) o2hb_shutdown_slot
                                  allocate local event2
                                  4) queue_node_event
                                  add event2 to global o2hb_node_events
                                  5) o2hb_run_event_list
                                  delete event1 from o2hb_node_events
6) o2hb_run_event_list
event1 empty, return
7) o2hb_shutdown_slot
event1 lifecycle ends
                                  8) o2hb_fire_callbacks
                                  event1 is already *invalid*

This patch lets it wait on o2hb_callback_sem when another thread is firing
callbacks.  And for performance consideration, we only call
o2hb_run_event_list when there is an event queued.

Signed-off-by: Joyce 
Signed-off-by: Joseph Qi 
Cc: Joel Becker 
Cc: Mark Fasheh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: avoid possible NULL pointer dereference in o2net_accept_one()

2013-09-11T22:56:50+00:00

Since o2nm_get_node_by_num() may return NULL, we add this check in
o2net_accept_one() to avoid possible NULL pointer dereference.

Signed-off-by: Joseph Qi 
Cc: Mark Fasheh 
Cc: Joel Becker 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: adjust code style for o2net_handler_tree_lookup()

2013-09-11T22:56:50+00:00

Code in o2net_handler_tree_lookup() may be corrupted by mistake.  So
adjust it to promote readability.

Signed-off-by: Joseph Qi 
Cc: Mark Fasheh 
Cc: Joel Becker 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: use list_for_each_entry() instead of list_for_each()

2013-09-11T22:56:36+00:00

[dan.carpenter@oracle.com: fix up some NULL dereference bugs]
Signed-off-by: Dong Fang 
Cc: Mark Fasheh 
Cc: Joel Becker 
Cc: Jeff Liu 
Signed-off-by: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/ocfs2/cluster/tcp.c: fix possible null pointer dereferences

2013-09-11T22:56:34+00:00

Fix some possible null pointer dereferences that were detected by the
static code analyser, smatch.

Signed-off-by: Sunil Mushran 
Reported-by: Dan Carpenter 
Reported-by: Guozhonghua 
Cc: Sunil Mushran 
Cc: Joseph Qi 
Cc: Mark Fasheh 
Cc: Joel Becker 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: fix NULL pointer dereference when traversing o2hb_all_regions

2013-07-03T23:07:25+00:00

There may exist NULL pointer dereference in config_item_name() when one
volume (say Volume A) unmounts while another (say Volume B) mounting.

     Volume A                          Volume B

  already Mounted.
  Unmounting, call
  o2hb_heartbeat_group_drop_item()
    -> config_item_put(item)
    set reg(A)->item.ci_name to NULL
    in function config_item_cleanup().

                                    begin mounting, call
                                    o2hb_region_pin() and tranverse all
                                    regions. When reading
                                    reg(A)->item.ci_name, it causes
                                    NULL pointer dereference.

  call o2hb_region_release() and
  del reg(A) from list.

So we should skip accessing regions that is going to release when
tranverse o2hb_all_regions.

Signed-off-by: Yiwen Jiang 
Signed-off-by: joyce 
Acked-by: Joel Becker 
Cc: Mark Fasheh 
Cc: Sunil Mushran 
Cc: Jie Liu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: adjust switch_case syntax at o2net_state_change()

2013-07-03T23:07:25+00:00

Adjust switch..case syntax at o2net_state_change to meet the kernel coding
standard.

s/printk/pr_info/.

[akpm@linux-foundation.org: revert pr_foo() change]
Signed-off-by: Jie Liu 
Acked-by: Joel Becker 
Cc: Gurudas Pai 
Cc: Mark Fasheh 
Cc: Noboru Iwamatsu 
Cc: Srinivas Eeeda 
Cc: Sunil Mushran 
Cc: Tao Ma 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: fix a comments typo at o2quo_hb_still_up()

2013-07-03T23:07:24+00:00

Fix a comment typo in o2quo_hb_still_up()

Signed-off-by: Jie Liu 
Cc: Gurudas Pai 
Cc: Joel Becker 
Cc: Mark Fasheh 
Cc: Noboru Iwamatsu 
Cc: Srinivas Eeeda 
Cc: Sunil Mushran 
Cc: Tao Ma 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: consolidate o2hb_global_hearbeat_mode_set() naming convention

2013-07-03T23:07:24+00:00

s/o2hb_global_hearbeat_mode_set/o2hb_global_heartbeat_mode_set/ to make
the signature of those routines in a consistent manner with others for
heartbeating.

Signed-off-by: Jie Liu 
Acked-by: Sunil Mushran 
Cc: Gurudas Pai 
Cc: Joel Becker 
Cc: Mark Fasheh 
Cc: Noboru Iwamatsu 
Cc: Srinivas Eeeda 
Cc: Tao Ma 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ocfs2: submit disk heartbeat bio using WRITE_SYNC

2013-07-03T23:07:24+00:00

Under heavy I/O load, writing the disk heartbeat can be forced to wait for
minutes, and this causes the node to be fenced.

This patch tries to use WRITE_SYNC in submitting the heartbeat bio, so
that writing the heartbeat will have a priority over other requests.

Signed-off-by: Noboru Iwamatsu 
Acked-by: Tao Ma 
Acked-by: Sunil Mushran 
Cc: Srinivas Eeeda 
Reviewed-by: Jie Liu 
Tested-by: Gurudas Pai 
Cc: Joel Becker 
Cc: Mark Fasheh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds