linux-toradex.git/fs/proc/root.c, branch v2.6.34

some clean up in fs/proc

2010-03-03T18:00:18+00:00

EXPORT_SYMBOL(proc_symlink);
EXPORT_SYMBOL(proc_mkdir);
EXPORT_SYMBOL(create_proc_entry);
EXPORT_SYMBOL(proc_create_data);
EXPORT_SYMBOL(remove_proc_entry);

Those EXPORT_SYMBOL shouldn't be in fs/proc/root.c,
should be in fs/proc/generic.c.

Signed-off-by: Helight.Xu 
Signed-off-by: Al Viro

Convert obvious places to deactivate_locked_super()

2009-05-09T14:49:40+00:00

Signed-off-by: Al Viro

vfs: simple_set_mnt() should return void

2009-03-27T18:44:03+00:00

simple_set_mnt() is defined as returning 'int' but always returns 0.
Callers assume simple_set_mnt() never fails and don't properly cleanup if
it were to _ever_ fail.  For instance, get_sb_single() and get_sb_nodev()
should:

        up_write(sb->s_unmount);
        deactivate_super(sb);

if simple_set_mnt() fails.

Since simple_set_mnt() never fails, would be cleaner if it did not
return anything.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Sukadev Bhattiprolu 
Acked-by: Serge Hallyn 
Cc: Al Viro 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Al Viro

proc: stop using BKL

2009-01-05T09:27:44+00:00

There are four BKL users in proc: de_put(), proc_lookup_de(),
proc_readdir_de(), proc_root_readdir(),

1) de_put()
-----------
de_put() is classic atomic_dec_and_test() refcount wrapper -- no BKL
needed. BKL doesn't matter to possible refcount leak as well.

2) proc_lookup_de()
-------------------
Walking PDE list is protected by proc_subdir_lock(), proc_get_inode() is
potentially blocking, all callers of proc_lookup_de() eventually end up
from ->lookup hooks which is protected by directory's ->i_mutex -- BKL
doesn't protect anything.

3) proc_readdir_de()
--------------------
"." and ".." part doesn't need BKL, walking PDE list is under
proc_subdir_lock, calling filldir callback is potentially blocking
because it writes to luserspace. All proc_readdir_de() callers
eventually come from ->readdir hook which is under directory's
->i_mutex -- BKL doesn't protect anything.

4) proc_root_readdir_de()
-------------------------
proc_root_readdir_de is ->readdir hook, see (3).

Since readdir hooks doesn't use BKL anymore, switch to
generic_file_llseek, since it also takes directory's i_mutex.

Signed-off-by: Alexey Dobriyan

proc: remove fs/proc/proc_misc.c

2008-10-23T14:54:05+00:00

Now that everything was moved to their more or less expected places,
apply rm(1).

Signed-off-by: Alexey Dobriyan

proc: proc_init_inodecache() can't fail

2008-10-23T09:27:50+00:00

kmem_cache creation code will panic, don't return anything.

Signed-off-by: Alexey Dobriyan

proc: introduce proc_create_data to setup de->data

2008-04-29T15:06:20+00:00

This set of patches fixes an proc ->open'less usage due to ->proc_fops flip in
the most part of the kernel code.  The original OOPS is described in the
commit 2d3a4e3666325a9709cc8ea2e88151394e8f20fc:

    Typical PDE creation code looks like:

    	pde = create_proc_entry("foo", 0, NULL);
    	if (pde)
    		pde->proc_fops = &foo_proc_fops;

    Notice that PDE is first created, only then ->proc_fops is set up to
    final value. This is a problem because right after creation
    a) PDE is fully visible in /proc , and
    b) ->proc_fops are proc_file_operations which do not have ->open callback. So, it's
       possible to ->read without ->open (see one class of oopses below).

    The fix is new API called proc_create() which makes sure ->proc_fops are
    set up before gluing PDE to main tree. Typical new code looks like:

    	pde = proc_create("foo", 0, NULL, &foo_proc_fops);
    	if (!pde)
    		return -ENOMEM;

    Fix most networking users for a start.

    In the long run, create_proc_entry() for regular files will go.

In addition to this, proc_create_data is introduced to fix reading from
proc without PDE->data. The race is basically the same as above.

create_proc_entries is replaced in the entire kernel code as new method
is also simply better.

This patch:

The problem is the same as for de->proc_fops.  Right now PDE becomes visible
without data set.  So, the entry could be looked up without data.  This, in
most cases, will simply OOPS.

proc_create_data call is created to address this issue.  proc_create now
becomes a wrapper around it.

Signed-off-by: Denis V. Lunev 
Cc: "Eric W. Biederman" 
Cc: "J. Bruce Fields" 
Cc: Alessandro Zummo 
Cc: Alexey Dobriyan 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Benjamin Herrenschmidt 
Cc: Bjorn Helgaas 
Cc: Chris Mason 
Acked-by: David Howells 
Cc: Dmitry Torokhov 
Cc: Geert Uytterhoeven 
Cc: Grant Grundler 
Cc: Greg Kroah-Hartman 
Cc: Haavard Skinnemoen 
Cc: Heiko Carstens 
Cc: Ingo Molnar 
Cc: James Bottomley 
Cc: Jaroslav Kysela 
Cc: Jeff Garzik 
Cc: Jeff Mahoney 
Cc: Jesper Nilsson 
Cc: Karsten Keil 
Cc: Kyle McMartin 
Cc: Len Brown 
Cc: Martin Schwidefsky 
Cc: Mathieu Desnoyers 
Cc: Matthew Wilcox 
Cc: Mauro Carvalho Chehab 
Cc: Mikael Starvik 
Cc: Nadia Derbey 
Cc: Neil Brown 
Cc: Paul Mackerras 
Cc: Peter Osterlund 
Cc: Pierre Peiffer 
Cc: Russell King 
Cc: Takashi Iwai 
Cc: Tony Luck 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: remove proc_root from drivers

2008-04-29T15:06:18+00:00

Remove proc_root export.  Creation and removal works well if parent PDE is
supplied as NULL -- it worked always that way.

So, one useless export removed and consistency added, some drivers created
PDEs with &proc_root as parent but removed them as NULL and so on.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: remove proc_root_driver

2008-04-29T15:06:18+00:00

Use creation by full path: "driver/foo".

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: remove proc_root_fs

2008-04-29T15:06:18+00:00

Use creation by full path instead: "fs/foo".

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds