linux-toradex.git/fs/reiserfs/journal.c, branch v5.17

reiserfs: don't use congestion_wait()

2021-11-18T10:52:22+00:00

Block devices do not, in general, report congestion any more, so this
congestion_wait() is effectively just a sleep.

It isn't entirely clear what is being waited for, but as we only wait
when j_async_throttle is elevated, it seems reasonable to stop waiting
when j_async_throttle becomes zero - or after the same timeout.

So change to use wait_event_event_timeout() for waiting, and
wake_up_var() to signal an end to waiting.

Link: https://lore.kernel.org/r/163712368225.13692.3419908086400748349@noble.neil.brown.name
Signed-off-by: NeilBrown 
Signed-off-by: Jan Kara

reiserfs: add check for invalid 1st journal block

2021-05-17T13:07:54+00:00

syzbot reported divide error in reiserfs.
The problem was in incorrect journal 1st block.

Syzbot's reproducer manualy generated wrong superblock
with incorrect 1st block. In journal_init() wasn't
any checks about this particular case.

For example, if 1st journal block is before superblock
1st block, it can cause zeroing important superblock members
in do_journal_end().

Link: https://lore.kernel.org/r/20210517121545.29645-1-paskripkin@gmail.com
Reported-by: syzbot+0ba9909df31c6a36974d@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin 
Signed-off-by: Jan Kara

fs/reiserfs/journal.c: delete useless variables

2021-04-21T14:29:05+00:00

The value of 'cn' is not used, so just delete it.

Link: https://lore.kernel.org/r/1618278196-17749-1-git-send-email-tiantao6@hisilicon.com
Signed-off-by: Tian Tao 
Signed-off-by: Jan Kara

reiserfs: delete duplicated words

2020-08-05T08:29:57+00:00

Delete repeated words in fs/reiserfs/.
{from, not, we, are}

Link: https://lore.kernel.org/r/20200805024925.12281-1-rdunlap@infradead.org
Signed-off-by: Randy Dunlap 
To: linux-fsdevel@vger.kernel.org
Cc: Jan Kara 
Cc: Jeff Mahoney 
Cc: Andrew Morton 
Cc: reiserfs-devel@vger.kernel.org
Signed-off-by: Jan Kara

block: remove __bdevname

2020-03-24T13:57:07+00:00

There is no good reason for __bdevname to exist.  Just open code
printing the string in the callers.  For three of them the format
string can be trivially merged into existing printk statements,
and in init/do_mounts.c we can at least do the scnprintf once at
the start of the function, and unconditional of CONFIG_BLOCK to
make the output for tiny configfs a little more helpful.

Acked-by: Theodore Ts'o  # for ext4
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

fs/reiserfs: remove unused macros

2020-01-21T16:23:05+00:00

these macros are never used from introduced. better to
remove them.

Link: https://lore.kernel.org/r/1579602338-57079-1-git-send-email-alex.shi@linux.alibaba.com
Signed-off-by: Alex Shi 
Cc: Andrew Morton 
Cc: Jan Kara 
Cc: Bharath Vedartham 
Cc: Hariprasad Kelam 
Cc: Jason Yan 
Cc: zhengbin 
Cc: Jia-Ju Bai 
Cc: reiserfs-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jan Kara

fs/reiserfs/journal.c: remove set but not used variable

2019-09-26T00:51:40+00:00

Fix the following gcc warning:

fs/reiserfs/journal.c: In function flush_used_journal_lists:
fs/reiserfs/journal.c:1791:6: warning: variable ret set but not used
[-Wunused-but-set-variable]

Link: http://lkml.kernel.org/r/20190827032932.46622-1-yanaijie@huawei.com
Signed-off-by: Jason Yan 
Cc: zhengbin 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/reiserfs/journal.c: remove set but not used variables

2019-09-26T00:51:40+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

fs/reiserfs/journal.c: In function flush_older_commits:
fs/reiserfs/journal.c:894:15: warning: variable first_trans_id set but not used [-Wunused-but-set-variable]
fs/reiserfs/journal.c: In function flush_journal_list:
fs/reiserfs/journal.c:1354:38: warning: variable last set but not used [-Wunused-but-set-variable]
fs/reiserfs/journal.c: In function do_journal_release:
fs/reiserfs/journal.c:1916:6: warning: variable flushed set but not used [-Wunused-but-set-variable]
fs/reiserfs/journal.c: In function do_journal_end:
fs/reiserfs/journal.c:3993:6: warning: variable old_start set but not used [-Wunused-but-set-variable]

Link: http://lkml.kernel.org/r/1566379929-118398-2-git-send-email-zhengbin13@huawei.com
Signed-off-by: zhengbin 
Reported-by: Hulk Robot 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs: reiserfs: remove unnecessary check of bh in remove_from_transaction()

2019-09-26T00:51:39+00:00

On lines 3430-3434, bh has been assured to be non-null:
    cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr);
    if (!cn || !cn->bh) {
        return ret;
    }
    bh = cn->bh;

Thus, the check of bh on line 3447 is unnecessary and can be removed.
Thank Andrew Morton for good advice.

Link: http://lkml.kernel.org/r/20190727084019.11307-1-baijiaju1990@gmail.com
Signed-off-by: Jia-Ju Bai 
Reviewed-by: Jan Kara 
Cc: Arnd Bergmann 
Cc: Hariprasad Kelam 
Cc: Bharath Vedartham 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/reiserfs/journal.c: change return type of dirty_one_transaction

2019-07-17T02:23:24+00:00

Change return type of dirty_one_transaction from int to void.  As this
function always return success.

Fixes below issue reported by coccicheck:

  fs/reiserfs/journal.c:1690:5-8: Unneeded variable: "ret".  Return "0" on line 1719

Link: http://lkml.kernel.org/r/20190702175430.GA5882@hari-Inspiron-1545
Signed-off-by: Hariprasad Kelam 
Reviewed-by: Jan Kara 
Cc: Arnd Bergmann 
Cc: Bharath Vedartham 
Cc: Hariprasad Kelam 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds