linux-toradex.git/fs/reiserfs/prints.c, branch v4.2.6

fs/reiserfs: replace not-standard %Lu/%Ld

2014-08-08T22:57:21+00:00

Fixes checkpatch warnings:

"WARNING: %Ld/%Lu are not-standard C, use %lld/%llu"

Signed-off-by: Fabian Frederick 
Cc: Jeff Mahoney 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

reiserfs: balance_leaf refactor, move state variables into tree_balance

2014-05-07T16:31:06+00:00

This patch pushes the rest of the state variables in balance_leaf into
the tree_balance structure so we can use them when we split balance_leaf
into separate functions.

Signed-off-by: Jeff Mahoney 
Signed-off-by: Jan Kara

reiserfs: cleanup, remove unnecessary parens

2014-05-06T21:18:16+00:00

The reiserfs code is littered with extra parens in places where the authors
may not have been certain about precedence of & vs ->. This patch cleans them
out.

Signed-off-by: Jeff Mahoney 
Signed-off-by: Jan Kara

reiserfs: cleanup, reformat comments to normal kernel style

2014-05-06T20:52:19+00:00

This patch reformats comments in the reiserfs code to fit in 80 columns and
to follow the style rules.

There is no functional change but it helps make my eyes bleed less.

Signed-off-by: Jeff Mahoney 
Signed-off-by: Jan Kara

reiserfs: cleanup, rename key and item accessors to more friendly names

2014-05-06T20:51:44+00:00

This patch does a quick search and replace:
B_N_PITEM_HEAD() -> item_head()
B_N_PDELIM_KEY() -> internal_key()
B_N_PKEY() -> leaf_key()
B_N_PITEM() -> item_body()

And the item_head version:
B_I_PITEM() -> ih_item_body()
I_ENTRY_COUNT() -> ih_entry_count()

And the treepath variants:
get_ih() -> tp_item_head()
PATH_PITEM_HEAD() -> tp_item_head()
get_item() -> tp_item_body()

... which makes the code much easier on the eyes.

I've also removed a few unused macros.

Checkpatch will complain about the 80 character limit for do_balan.c.
I've addressed that in a later patchset to split up balance_leaf().

Signed-off-by: Jeff Mahoney 
Signed-off-by: Jan Kara

reiserfs: locking, handle nested locks properly

2013-08-08T21:34:46+00:00

The reiserfs write lock replaced the BKL and uses similar semantics.

Frederic's locking code makes a distinction between when the lock is nested
and when it's being acquired/released, but I don't think that's the right
distinction to make.

The right distinction is between the lock being released at end-of-use and
the lock being released for a schedule. The unlock should return the depth
and the lock should restore it, rather than the other way around as it is now.

This patch implements that and adds a number of places where the lock
should be dropped.

Signed-off-by: Jeff Mahoney

move private bits of reiserfs_fs.h to fs/reiserfs/reiserfs.h

2012-03-21T01:29:43+00:00

Signed-off-by: Al Viro

reiserfs: make sure va_end() is always called after va_start().

2011-01-13T16:03:15+00:00

A call to va_start() must always be followed by a call to va_end() in the
same function.  In fs/reiserfs/prints.c::print_block() this is not always
the case.  If 'bh' is NULL we'll return without calling va_end().

One could add a call to va_end() before the 'return' statement, but it's
nicer to just move the call to va_start() after the test for 'bh' being
NULL.

Signed-off-by: Jesper Juhl 
Acked-by: Edward Shishkin 
Cc: Jeff Mahoney 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kill-the-bkl/reiserfs: move the concurrent tree accesses checks per superblock

2009-09-14T05:18:25+00:00

When do_balance() balances the tree, a trick is performed to
provide the ability for other tree writers/readers to check whether
do_balance() is executing concurrently (requires CONFIG_REISERFS_CHECK).

This is done to protect concurrent accesses to the tree. The trick
is the following:

When do_balance is called, a unique global variable called cur_tb
takes a pointer to the current tree to be rebalanced.
Once do_balance finishes its work, cur_tb takes the NULL value.

Then, concurrent tree readers/writers just have to check the value
of cur_tb to ensure do_balance isn't executing concurrently.
If it is, then it proves that schedule() occured on do_balance(),
which then relaxed the bkl that protected the tree.

Now that the bkl has be turned into a mutex, this check is still
fine even though do_balance() becomes preemptible: the write lock
will not be automatically released on schedule(), so the tree is
still protected.

But this is only fine if we have a single reiserfs mountpoint.
Indeed, because the bkl is a global lock, it didn't allowed
concurrent executions between a tree reader/writer in a mount point
and a do_balance() on another tree from another mountpoint.

So assuming all these readers/writers weren't supposed to be
reentrant, the current check now sometimes detect false positives with
the current per-superblock mutex which allows this reentrancy.

This patch keeps the concurrent tree accesses check but moves it
per superblock, so that only trees from a same mount point are
checked to be not accessed concurrently.

[ Impact: fix spurious panic while running several reiserfs mount-points ]

Cc: Jeff Mahoney 
Cc: Chris Mason 
Cc: Ingo Molnar 
Cc: Alexander Beregalov 
Signed-off-by: Frederic Weisbecker

reiserfs: strip trailing whitespace

2009-03-30T19:16:39+00:00

This patch strips trailing whitespace from the reiserfs code.

Signed-off-by: Jeff Mahoney 
Signed-off-by: Linus Torvalds