linux-toradex.git/fs/sysfs/file.c, branch v2.6.19.2

sysfs: update obsolete comment in sysfs_update_file

2006-10-18T19:49:54+00:00

And the obsolete comment should be updated (or totally removed).

Signed-off-by: Hidetoshi Seto 
Signed-off-by: Greg Kroah-Hartman

sysfs: remove duplicated dput in sysfs_update_file

2006-10-18T19:49:54+00:00

Following function can drops d_count twice against one reference
by lookup_one_len.


/**
 * sysfs_update_file - update the modified timestamp on an object attribute.
 * @kobj: object we're acting for.
 * @attr: attribute descriptor.
 */
int sysfs_update_file(struct kobject * kobj, const struct attribute * attr)
{
        struct dentry * dir = kobj->dentry;
        struct dentry * victim;
        int res = -ENOENT;

        mutex_lock(&dir->d_inode->i_mutex);
        victim = lookup_one_len(attr->name, dir, strlen(attr->name));
        if (!IS_ERR(victim)) {
                /* make sure dentry is really there */
                if (victim->d_inode &&
                    (victim->d_parent->d_inode == dir->d_inode)) {
                        victim->d_inode->i_mtime = CURRENT_TIME;
                        fsnotify_modify(victim);

                        /**
                         * Drop reference from initial sysfs_get_dentry().
                         */
                        dput(victim);
                        res = 0;
                } else
                        d_drop(victim);

                /**
                 * Drop the reference acquired from sysfs_get_dentry() above.
                 */
                dput(victim);
        }
        mutex_unlock(&dir->d_inode->i_mutex);

        return res;
}


PCI-hotplug (drivers/pci/hotplug/pci_hotplug_core.c) is only user of
this function. I confirmed that dentry of /sys/bus/pci/slots/XXX/*
have negative d_count value.

This patch removes unnecessary dput().

Signed-off-by: Hidetoshi Seto 
Acked-by: Maneesh Soni 
Signed-off-by: Greg Kroah-Hartman

[PATCH] pr_debug: sysfs: use size_t length modifier in pr_debug format arguments

2006-10-03T15:04:19+00:00

sysfs: use size_t length modifier in pr_debug format arguments

Signed-off-by: Zach Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysfs: Allow sysfs attribute files to be pollable

2006-04-14T18:41:24+00:00

It works like this:
  Open the file
  Read all the contents.
  Call poll requesting POLLERR or POLLPRI (so select/exceptfds works)
  When poll returns,
     close the file and go to top of loop.
   or lseek to start of file and go back to the 'read'.

Events are signaled by an object manager calling
   sysfs_notify(kobj, dir, attr);

If the dir is non-NULL, it is used to find a subdirectory which
contains the attribute (presumably created by sysfs_create_group).

This has a cost of one int  per attribute, one wait_queuehead per kobject,
one int per open file.

The name "sysfs_notify" may be confused with the inotify
functionality.  Maybe it would be nice to support inotify for sysfs
attributes as well?

This patch also uses sysfs_notify to allow /sys/block/md*/md/sync_action
to be pollable

Signed-off-by: Neil Brown 
Signed-off-by: Greg Kroah-Hartman

[PATCH] sysfs: zero terminate sysfs write buffers

2006-04-02T20:03:31+00:00

No one should be writing a PAGE_SIZE worth of data to a normal sysfs
file, so properly terminate the buffer.

Thanks to Al Viro for pointing out my supidity here.

Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds

[PATCH] Make most file operations structs in fs/ const

2006-03-28T17:16:06+00:00

This is a conversion to make the various file_operations structs in fs/
const.  Basically a regexp job, with a few manual fixups

The goal is both to increase correctness (harder to accidentally write to
shared datastructures) and reducing the false sharing of cachelines with
things that get dirty in .data (while .rodata is nicely read only and thus
cache clean)

Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysfs: fix problem with duplicate sysfs directories and files

2006-03-20T21:42:59+00:00

The following patch checks for existing sysfs_dirent before
preparing new one while creating sysfs directories and files.

Signed-off-by: Maneesh Soni 
Signed-off-by: Greg Kroah-Hartman

[PATCH] sysfs: kzalloc conversion

2006-03-20T21:42:58+00:00

this converts fs/sysfs to kzalloc() usage.
compile tested with make allyesconfig

Signed-off-by: Eric Sesterhenn 
Signed-off-by: Greg Kroah-Hartman

[PATCH] mutex subsystem, semaphore to mutex: VFS, ->i_sem

2006-01-09T23:59:24+00:00

This patch converts the inode semaphore to a mutex. I have tested it on
XFS and compiled as much as one can consider on an ia64. Anyway your
luck with it might be different.

Modified-by: Ingo Molnar 

(finished the conversion)

Signed-off-by: Jes Sorensen 
Signed-off-by: Ingo Molnar

[PATCH] sysfs: fix sysfs_chmod_file

2005-07-29T20:12:49+00:00

o sysfs_chmod_file() must update the new iattr field in sysfs_dirent else
  the mode change will not be persistent in case of inode evacuation from
  cache.

Signed-off-by: Maneesh Soni 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds