linux-toradex.git/fs/sysfs/file.c, branch v3.12.43 Linux kernel for Apalis and Colibri modules sysfs: file.c: fix up broken string warnings 2013-08-21T23:37:42+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:37:42+00:00 07ac62a604a8bfb23b1b8c1a07f29f6752bacdb7 This fixes the coding style warnings in fs/sysfs/file.c for broken strings across lines. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes the coding style warnings in fs/sysfs/file.c for broken
strings across lines.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: fix up uaccess.h coding style warnings 2013-08-21T23:34:59+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:34:59+00:00 060cc749e9c50dfc8d1a8696aa0da520aa714977 This fixes the uaccess.h warnings in the sysfs.c files. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes the uaccess.h warnings in the sysfs.c files.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: fix up 80 column coding style issues 2013-08-21T23:33:34+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:33:34+00:00 ddfd6d074e0fadd14b6670394a6a7fb6a955de18 This fixes up the 80 column coding style issues in the sysfs .c files. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes up the 80 column coding style issues in the sysfs .c files.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: fix up space coding style issues 2013-08-21T23:28:26+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:28:26+00:00 1b18dc2beb31f588db1c75901b0112324c72124f This fixes up all of the space-related coding style issues for the sysfs code. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This fixes up all of the space-related coding style issues for the sysfs
code.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: remove trailing whitespace 2013-08-21T23:21:17+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:21:17+00:00 ab9bf4be4dd58f8ae1961180e008b7e3022f08b5 This removes all trailing whitespace errors in the sysfs code. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This removes all trailing whitespace errors in the sysfs code.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: fix placement of EXPORT_SYMBOL() 2013-08-21T23:17:47+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2013-08-21T23:17:47+00:00 1b866757fc4cb135674f46c96909e900fcea91a2 The export should happen after the function, not at the bottom of the file, so fix that up. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The export should happen after the function, not at the bottom of the
file, so fix that up.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs_notify is only possible on file attributes 2013-06-07T23:05:50+00:00 Nick Dyer nick.dyer@itdev.co.uk 2013-06-07T14:45:13+00:00 fc60bb8339b66183f40ea9a001538c958f6d2c9e If sysfs_notify is called on a binary attribute, bad things can happen, so prevent it. Note, no in-kernel usage of this is currently present, but in the future, it's good to be safe. Changes in V2: - Also ignore sysfs_notify on dirs, links - Use WARN_ON rather than silently failing - Compiled and tested (huge apologies about first submission) Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
If sysfs_notify is called on a binary attribute, bad things can
happen, so prevent it.

Note, no in-kernel usage of this is currently present, but in the
future, it's good to be safe.

Changes in V2:
- Also ignore sysfs_notify on dirs, links
- Use WARN_ON rather than silently failing
- Compiled and tested (huge apologies about first submission)

Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: Mark sysfs_attr_ns static 2012-11-27T00:25:36+00:00 Josh Triplett josh@joshtriplett.org 2012-11-19T05:27:50+00:00 1f20dfdaedcec4298a0a71fd396ec4828b332483 Nothing outside of fs/sysfs/file.c references this function, so mark it static. Signed-off-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Nothing outside of fs/sysfs/file.c references this function, so mark it static.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sysfs: Complain bitterly about attempts to remove files from nonexistent directories. 2012-01-24T20:12:32+00:00 Eric W. Biederman ebiederm@xmission.com 2012-01-14T05:32:59+00:00 ce597919361dcec97341151690e780eade2a9cf4 Recently an OOPS was observed from the usb serial io_ti driver when it tried to remove sysfs directories. Upon investigation it turns out this driver was always buggy and that a recent sysfs change had stopped guarding itself against removing attributes from sysfs directories that had already been removed. :( Historically we have been silent about attempting to files from nonexistent sysfs directories and have politely returned error codes. That has resulted in people writing broken code that ignores the error codes. Issue a kernel WARNING and a stack backtrace to make it clear in no uncertain terms that abusing sysfs is not ok, and the callers need to fix their code. This change transforms the io_ti OOPS into a more comprehensible error message and stack backtrace. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Reported-by: Wolfgang Frisch <wfpub@roembden.net> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Recently an OOPS was observed from the usb serial io_ti driver when it tried to remove
sysfs directories.  Upon investigation it turns out this driver was always buggy
and that a recent sysfs change had stopped guarding itself against removing attributes
from sysfs directories that had already been removed. :(

Historically we have been silent about attempting to files from nonexistent sysfs
directories and have politely returned error codes.  That has resulted in people writing
broken code that ignores the error codes.

Issue a kernel WARNING and a stack backtrace to make it clear in no uncertain
terms that abusing sysfs is not ok, and the callers need to fix their code.

This change transforms the io_ti OOPS into a more comprehensible error message
and stack backtrace.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Reported-by: Wolfgang Frisch <wfpub@roembden.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
sysfs: propagate umode_t 2012-01-04T03:55:03+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-25T03:44:53+00:00 faef2b6c9960b5ae288899f461a2218ec6bb7928 Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>