linux-toradex.git/fs/ufs/namei.c, branch v4.4.72

Merge branch 'for-linus' into for-next

2015-06-17T18:44:05+00:00

ufs: don't touch mtime/ctime of directory being moved

2015-06-16T06:08:34+00:00

See "ext2: Do not update mtime of a moved directory" (and followup in
"ext2: fix unbalanced kmap()/kunmap()") for background; this is UFS
equivalent - the same problem exists here.

Signed-off-by: Al Viro

ufs: don't bother with lock_ufs()/unlock_ufs() for directory access

2015-06-16T06:08:31+00:00

We are already serialized by ->i_mutex and operations on different
directories are independent.  These calls are just rudiments of
blind BKL conversion and they should've been removed back then.

Signed-off-by: Al Viro

ufs: Fix possible deadlock when looking up directories

2015-06-16T06:08:12+00:00

Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) made ufs
create inodes with I_NEW flag set. However ufs_mkdir() never cleared
this flag. Thus if someone ever tried to lookup the directory by inode
number, he would deadlock waiting for I_NEW to be cleared. Luckily this
mostly happens only if the filesystem is exported over NFS since
otherwise we have the inode attached to dentry and don't look it up by
inode number. In rare cases dentry can get freed without inode being
freed and then we'd hit the deadlock even without NFS export.

Fix the problem by clearing I_NEW before instantiating new directory
inode.

Fixes: e4502c63f56aeca887ced37f24e0def1ef11cec8
Reported-by: Fabian Frederick 
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro

ufs: Fix warning from unlock_new_inode()

2015-06-16T06:08:07+00:00

Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) introduced
unlock_new_inode() call into ufs_add_nondir(). However that function
gets called also from ufs_link() which hands it already initialized
inode and thus unlock_new_inode() complains. The problem is harmless but
annoying.

Fix the problem by opencoding necessary stuff in ufs_link()

Fixes: e4502c63f56aeca887ced37f24e0def1ef11cec8
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro

fs/ufs: revert "ufs: fix deadlocks introduced by sb mutex merge"

2015-06-14T15:31:51+00:00

This reverts commit 9ef7db7f38d0 ("ufs: fix deadlocks introduced by sb
mutex merge") That patch tried to solve commit 0244756edc4b98c ("ufs: sb
mutex merge + mutex_destroy") which is itself partially reverted due to
multiple deadlocks.

Signed-off-by: Fabian Frederick 
Suggested-by: Jan Kara 
Cc: Ian Campbell 
Cc: Evgeniy Dushistov 
Cc: Alexey Khoroshilov 
Cc: Roger Pau Monne 
Cc: Ian Jackson 
Cc: Al Viro 
Cc: 
Signed-off-by: Andrew Morton

ufs: switch to simple_follow_link()

2015-05-11T02:18:25+00:00

Signed-off-by: Al Viro

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15T19:06:57+00:00

that's the bulk of filesystem drivers dealing with inodes of their own

Signed-off-by: David Howells 
Signed-off-by: Al Viro

ufs: deal with nfsd/iget races

2014-09-27T01:17:52+00:00

Signed-off-by: Al Viro

ufs: fix deadlocks introduced by sb mutex merge

2014-09-07T17:26:39+00:00

Commit 0244756edc4b ("ufs: sb mutex merge + mutex_destroy") introduces
deadlocks in ufs_new_inode() and ufs_free_inode().
Most callers of that functions acqure the mutex by themselves and
ufs_{new,free}_inode() do that via lock_ufs(),
i.e we have an unavoidable double lock.

The patch proposes to resolve the issue by making sure that
ufs_{new,free}_inode() are not called with the mutex held.

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org # 3.16
Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Al Viro