linux-toradex.git/fs/xfs/xfs_attr.c, branch v3.2.37

xfs: remove buffers from the delwri list in xfs_buf_stale

2011-10-12T02:15:10+00:00

For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either
directly before or after it, or are guaranteed by the surrounding
conditionals that we are never called on delwri buffers.  Simply
this situation by moving the call to xfs_buf_delwri_dequeue into
xfs_buf_stale.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: remove XFS_BUF_STALE and XFS_BUF_SUPER_STALE

2011-10-12T02:15:10+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: simplify xfs_trans_ijoin* again

2011-10-12T02:15:08+00:00

There is no reason to keep a reference to the inode even if we unlock
it during transaction commit because we never drop a reference between
the ijoin and commit.  Also use this fact to merge xfs_trans_ijoin_ref
back into xfs_trans_ijoin - the third argument decides if an unlock
is needed now.

I'm actually starting to wonder if allowing inodes to be unlocked
at transaction commit really is worth the effort.  The only real
benefit is that they can be unlocked earlier when commiting a
synchronous transactions, but that could be solved by doing the
log force manually after the unlock, too.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: rename xfs_bmapi to xfs_bmapi_write

2011-10-12T02:15:04+00:00

Now that all the read-only users of xfs_bmapi have been converted to
use xfs_bmapi_read(), we can remove all the read-only handling cases
from xfs_bmapi().

Once this is done, rename xfs_bmapi to xfs_bmapi_write to reflect
the fact it is for allocation only. This enables us to kill the
XFS_BMAPI_WRITE flag as well.

Also clean up xfs_bmapi_write to the style used in the newly added
xfs_bmapi_read/delay functions.

Signed-off-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: introduce xfs_bmapi_read()

2011-10-12T02:15:03+00:00

xfs_bmapi() currently handles both extent map reading and
allocation. As a result, the code is littered with "if (wr)"
branches to conditionally do allocation operations if required.
This makes the code much harder to follow and causes significant
indent issues with the code.

Given that read mapping is much simpler than allocation, we can
split out read mapping from xfs_bmapi() and reuse the logic that
we have already factored out do do all the hard work of handling the
extent map manipulations. The results in a much simpler function for
the common extent read operations, and will allow the allocation
code to be simplified in another commit.

Once xfs_bmapi_read() is implemented, convert all the callers of
xfs_bmapi() that are only reading extents to use the new function.

Signed-off-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: Check the return value of xfs_buf_get()

2011-10-12T02:15:01+00:00

Check the return value of xfs_buf_get() and fail appropriately.

Signed-off-by: Chandra Seetharaman 
Signed-off-by: Alex Elder

xfs: avoid synchronous transactions when deleting attr blocks

2011-10-12T02:15:01+00:00

Currently xfs_attr_inactive causes a synchronous transactions if we are
removing a file that has any extents allocated to the attribute fork, and
thus makes XFS extremely slow at removing files with out of line extended
attributes. The code looks a like a relict from the days before the busy
extent list, but with the busy extent list we avoid reusing data and attr
extents that have been freed but not commited yet, so this code is just
as superflous as the synchronous transactions for data blocks.

Signed-off-by: Christoph Hellwig 
Reported-by: Bernd Schubert 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: let xfs_bwrite callers handle the xfs_buf_relse

2011-10-12T02:15:00+00:00

Remove the xfs_buf_relse from xfs_bwrite and let the caller handle it to
mirror the delwri and read paths.

Also remove the mount pointer passed to xfs_bwrite, which is superflous now
that we have a mount pointer in the buftarg.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: call xfs_buf_delwri_queue directly

2011-10-12T02:14:59+00:00

Unify the ways we add buffers to the delwri queue by always calling
xfs_buf_delwri_queue directly.  The xfs_bdwrite functions is removed and
opencoded in its callers, and the two places setting XBF_DELWRI while a
buffer is locked and expecting xfs_buf_unlock to pick it up are converted
to call xfs_buf_delwri_queue directly, too.  Also replace the
XFS_BUF_UNDELAYWRITE macro with direct calls to xfs_buf_delwri_dequeue
to make the explicit queuing/dequeuing more obvious.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: Remove the macro XFS_BUF_ERROR and family

2011-07-25T19:57:46+00:00

Remove the definitions and usage of the macros XFS_BUF_ERROR,
XFS_BUF_GETERROR and XFS_BUF_ISERROR.

Signed-off-by: Chandra Seetharaman 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Alex Elder