linux-toradex.git/fs/xfs/xfs_attr_leaf.c, branch v3.2.37

xfs: fix attr2 vs large data fork assert

2011-11-29T19:03:12+00:00

With Dmitry fsstress updates I've seen very reproducible crashes in
xfs_attr_shortform_remove because xfs_attr_shortform_bytesfit claims that
the attributes would not fit inline into the inode after removing an
attribute.  It turns out that we were operating on an inode with lots
of delalloc extents, and thus an if_bytes values for the data fork that
is larger than biggest possible on-disk storage for it which utterly
confuses the code near the end of xfs_attr_shortform_bytesfit.

Fix this by always allowing the current attribute fork, like we already
do for the attr1 format, given that delalloc conversion will take care
for moving either the data or attribute area out of line if it doesn't
fit at that point - or making the point moot by merging extents at this
point.

Also document the function better, and clean up some loose bits.

Reviewed-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: introduce xfs_bmapi_read()

2011-10-12T02:15:03+00:00

xfs_bmapi() currently handles both extent map reading and
allocation. As a result, the code is littered with "if (wr)"
branches to conditionally do allocation operations if required.
This makes the code much harder to follow and causes significant
indent issues with the code.

Given that read mapping is much simpler than allocation, we can
split out read mapping from xfs_bmapi() and reuse the logic that
we have already factored out do do all the hard work of handling the
extent map manipulations. The results in a much simpler function for
the common extent read operations, and will allow the allocation
code to be simplified in another commit.

Once xfs_bmapi_read() is implemented, convert all the callers of
xfs_bmapi() that are only reading extents to use the new function.

Signed-off-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: Check the return value of xfs_trans_get_buf()

2011-10-12T02:15:01+00:00

Check the return value of xfs_trans_get_buf() and fail
appropriately.

Signed-off-by: Chandra Seetharaman 
Signed-off-by: Alex Elder

xfs: byteswap constants instead of variables

2011-07-08T12:36:05+00:00

Micro-optimize various comparisms by always byteswapping the constant
instead of the variable, which allows to do the swap at compile instead
of runtime.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Alex Elder 
Reviewed-by: Dave Chinner

xfs: use KM_NOFS for allocations during attribute list operations

2010-12-23T00:57:37+00:00

When listing attributes, we are doiing memory allocations under the
inode ilock using only KM_SLEEP. This allows memory allocation to
recurse back into the filesystem and do writeback, which may the
ilock we already hold on the current inode. THis will deadlock.
Hence use KM_NOFS for such allocations outside of transaction
context to ensure that reclaim recursion does not occur.

Reported-by: Nick Piggin 
Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig

xfs: remove unused delta tracking code in xfs_bmapi

2010-07-26T18:16:39+00:00

This code was introduced four years ago in commit
3e57ecf640428c01ba1ed8c8fc538447ada1715b without any review and has
been unused since.  Remove it just as the rest of the code introduced
in that commit to reduce that stack usage and complexity in this central
piece of code.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner

xfs: remove unneeded #include statements

2010-07-26T18:16:33+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner

xfs: drop dmapi hooks

2010-07-26T18:16:33+00:00

Dmapi support was never merged upstream, but we still have a lot of hooks
bloating XFS for it, all over the fast pathes of the filesystem.

This patch drops over 700 lines of dmapi overhead.  If we'll ever get HSM
support in mainline at least the namespace events can be done much saner
in the VFS instead of the individual filesystem, so it's not like this
is much help for future work.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner

xfs: remove duplicate buffer flags

2010-01-21T19:44:36+00:00

Currently we define aliases for the buffer flags in various
namespaces, which only adds confusion.  Remove all but the XBF_
flags to clean this up a bit.

Note that we still abuse XFS_B_ASYNC/XBF_ASYNC for some non-buffer
uses, but I'll clean that up later.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

xfs: convert attr to use unsigned names

2010-01-19T23:47:48+00:00

To be consistent with the directory code, the attr code should use
unsigned names. Convert the names from the vfs at the highest level
to unsigned, and ænsure they are consistenly used as unsigned down
to disk.

Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig