linux-toradex.git/fs/xfs/xfs_mru_cache.c, branch v4.4.81

xfs: xfs_mru_cache_insert() should use GFP_NOFS

2015-03-25T03:57:53+00:00

xfs_mru_cache_insert() can be called from within transaction context
during block allocation like so:

write(2)
  ....
    xfs_get_blocks
      xfs_iomap_write_direct
        start transaction
        xfs_bmapi_write
          xfs_bmapi_allocate
            xfs_bmap_btalloc
              xfs_bmap_btalloc_filestreams
                xfs_filestream_new_ag
                  xfs_filestream_pick_ag
                    xfs_mru_cache_insert
                      radix_tree_preload(GFP_KERNEL)

In this case, GFP_KERNEL is incorrect and can potentially lead to
deadlocks in memory reclaim. It should use GFP_NOFS allocations to
avoid lock recursion problems.

[dchinner: rewrote commit message]

Signed-off-by: Byoungyoung Lee 
Signed-off-by: Sanidhya Kashyap 
Reviewed-by: Dave Chinner 
Signed-off-by: Dave Chinner

xfs: mark all internal workqueues as freezable

2014-09-09T01:44:46+00:00

Workqueues must be explicitly set as freezable to ensure they are frozen
in the assocated part of the hibernation/suspend sequence. Freezing of
workqueues and kernel threads is important to ensure that modifications
are not made on-disk after the hibernation image has been created.
Otherwise, the in-memory state can become inconsistent with what is on
disk and eventually lead to filesystem corruption. We have reports of
free space btree corruptions that occur immediately after restore from
hibernate that suggest the xfs-eofblocks workqueue could be causing
such problems if it races with hibernation.

Mark all of the internal XFS workqueues as freezable to ensure nothing
changes on-disk once the freezer infrastructure freezes kernel threads
and creates the hibernation image.

Signed-off-by: Brian Foster 
Reported-by: Carlos E. R. 
Reviewed-by: Dave Chinner 
Signed-off-by: Dave Chinner

xfs: global error sign conversion

2014-06-25T04:58:08+00:00

Convert all the errors the core XFs code to negative error signs
like the rest of the kernel and remove all the sign conversion we
do in the interface layers.

Errors for conversion (and comparison) found via searches like:

$ git grep " E" fs/xfs
$ git grep "return E" fs/xfs
$ git grep " E[A-Z].*;$" fs/xfs

Negation points found via searches like:

$ git grep "= -[a-z,A-Z]" fs/xfs
$ git grep "return -[a-z,A-D,F-Z]" fs/xfs
$ git grep " -[a-z].*;" fs/xfs

[ with some bits I missed from Brian Foster ]

Signed-off-by: Dave Chinner 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: embedd mru_elem into parent structure

2014-04-22T21:11:51+00:00

There is no need to do a separate allocation for each mru element, just
embedd the structure into the parent one in the user.  Besides saving
a memory allocation and the infrastructure required for it this also
simplifies the API.

While we do major surgery on xfs_mru_cache.c also de-typedef it and
make struct mru_cache private to the implementation file.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Dave Chinner

xfs: handle duplicate entries in xfs_mru_cache_insert

2014-04-22T21:11:50+00:00

The radix tree code can detect and reject duplicate keys at insert
time.  Make xfs_mru_cache_insert handle this case so that future
changes to the filestream allocator can take advantage of this.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Dave Chinner

xfs: convert to alloc_workqueue()

2011-02-01T10:42:43+00:00

Convert from create[_singlethread]_workqueue() to alloc_workqueue().

* xfsdatad_workqueue and xfsconvertd_workqueue are identity converted.
  Using higher concurrency limit might be useful but given the
  complexity of workqueue usage in xfs, proceeding cautiously seems
  better.

* xfs_mru_reap_wq is converted to non-ordered workqueue with max
  concurrency of 1 as the work items don't require any specific
  ordering and already have proper synchronization.  It seems it was
  singlethreaded to save worker threads, which is no longer a concern.

Signed-off-by: Tejun Heo 
Cc: Alex Elder 
Cc: xfs-masters@oss.sgi.com
Cc: Christoph Hellwig

workqueue: convert cancel_rearming_delayed_work[queue]() users to cancel_delayed_work_sync()

2010-12-15T09:56:11+00:00

cancel_rearming_delayed_work[queue]() has been superceded by
cancel_delayed_work_sync() quite some time ago.  Convert all the
in-kernel users.  The conversions are completely equivalent and
trivial.

Signed-off-by: Tejun Heo 
Acked-by: "David S. Miller" 
Acked-by: Greg Kroah-Hartman 
Acked-by: Evgeniy Polyakov 
Cc: Jeff Garzik 
Cc: Benjamin Herrenschmidt 
Cc: Mauro Carvalho Chehab 
Cc: netdev@vger.kernel.org
Cc: Anton Vorontsov 
Cc: David Woodhouse 
Cc: "J. Bruce Fields" 
Cc: Neil Brown 
Cc: Alex Elder 
Cc: xfs-masters@oss.sgi.com
Cc: Christoph Lameter 
Cc: Pekka Enberg 
Cc: Andrew Morton 
Cc: netfilter-devel@vger.kernel.org
Cc: Trond Myklebust 
Cc: linux-nfs@vger.kernel.org

xfs: Kill filestreams cache flush

2010-01-15T21:34:22+00:00

The filestreams cache flush is not needed in the sync code as it
does not affect data writeback, and it is now not used by the growfs
code, either, so kill it.

Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: add more statics & drop some unused functions

2009-08-31T19:46:20+00:00

A lot more functions could be made static, but they need
forward declarations; this does some easy ones, and also
found a few unused functions in the process.

Signed-off-by: Eric Sandeen 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Felix Blyakher

[XFS] streamline init/exit path

2008-07-28T06:59:25+00:00

Currently the xfs module init/exit code is a mess. It's farmed out over a
lot of function with very little error checking. This patch makes sure we
propagate all initialization failures properly and clean up after them.
Various runtime initializations are replaced with compile-time
initializations where possible to make this easier. The exit path is
similarly consolidated.

There's now split out function to create/destroy the kmem zones and
alloc/free the trace buffers. I've also changed the ktrace allocations to
KM_MAYFAIL and handled errors resulting from that.

And yes, we really should replace the XFS_*_TRACE ifdefs with a single
XFS_TRACE..

SGI-PV: 976035

SGI-Modid: xfs-linux-melb:xfs-kern:31354a

Signed-off-by: Christoph Hellwig 
Signed-off-by: Niv Sardi 
Signed-off-by: Lachlan McIlroy