linux-toradex.git/fs/xfs/xfs_sysfs.c, branch v4.10

xfs: fix max_retries _show and _store functions

2017-01-04T04:34:17+00:00

max_retries _show and _store functions should test against cfg->max_retries,
not cfg->retry_timeout

Signed-off-by: Carlos Maiolino 
Reviewed-by: Eric Sandeen 
Signed-off-by: Darrick J. Wong

xfs: add some 'static' annotations

2016-10-20T04:42:30+00:00

sparse reported that several variables and a function were not
forward-declared anywhere and therefore should be 'static'.

Found with sparse by running 'make C=2 CF=-D__CHECK_ENDIAN__ fs/xfs/'

Signed-off-by: Eric Biggers 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Dave Chinner

xfs: normalize "infinite" retries in error configs

2016-09-13T21:51:30+00:00

As it stands today, the "fail immediately" vs. "retry forever"
values for max_retries and retry_timeout_seconds in the xfs metadata
error configurations are not consistent.

A retry_timeout_seconds of 0 means "retry forever," but a
max_retries of 0 means "fail immediately."

retry_timeout_seconds < 0 is disallowed, while max_retries == -1
means "retry forever."

Make this consistent across the error configs, such that a value of
0 means "fail immediately" (i.e. wait 0 seconds, or retry 0 times),
and a value of -1 always means "retry forever."

This makes retry_timeout a signed long to accommodate the -1, even
though it stores jiffies.  Given our limit of a 1 day maximum
timeout, this should be sufficient even at much higher HZ values
than we have available today.

Signed-off-by: Eric Sandeen 
Reviewed-by: Dave Chinner 
Signed-off-by: Dave Chinner

xfs: fix xfs_error_get_cfg for negative errnos

2016-07-20T00:48:51+00:00

xfs_error_get_cfg() is called with bp->b_error as an arg, which is
negative, so the switch statement won't ever find any matches.

This results in only the default error handler having any effect, as
EIO/ENOSPC/ENODEV get ignored due to the wrong sign.

It seems simplest to always flip the error sign to positive, so that
we can handle either negative errors in bp->b_error, or possibly a
positive errno via something like xfs_error_get_cfg(EIO) - this
future-proofs the function.

Signed-off-by: Eric Sandeen 
Reviewed-by: Carlos Maiolino 
Signed-off-by: Dave Chinner

xfs: add "fail at unmount" error handling configuration

2016-05-18T01:11:27+00:00

If we take "retry forever" literally on metadata IO errors, we can
hang at unmount, once it retries those writes forever. This is the
default behavior, unfortunately.

Add an error configuration option for this behavior and default it
to "fail" so that an unmount will trigger actuall errors, a shutdown
and allow the unmount to succeed. It will be noisy, though, as it
will log the errors and shutdown that occurs.

To fix this, we need to mark the filesystem as being in the process
of unmounting. Do this with a mount flag that is added at the
appropriate time (i.e. before the blocking AIL sync). We also need
to add this flag if mount fails after the initial phase of log
recovery has been run.

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: add configuration handlers for specific errors

2016-05-18T01:09:28+00:00

now most of the infrastructure is in place, we can start adding
support for configuring specific errors such as ENODEV, ENOSPC, EIO,
etc. Add these error configurations and configure them all to have
appropriate behaviours. That is, all will be configured to retry
forever by default, except for ENODEV, which is an unrecoverable
error, so it will be configured to not retry on error

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: add configuration of error failure speed

2016-05-18T01:08:15+00:00

On reception of an error, we can fail immediately, perform some
bound amount of retries or retry indefinitely. The current behaviour
we have is to retry forever.

However, we'd like the ability to choose how long the filesystem
should try after an error, it can either fail immediately, retry a
few times, or retry forever. This is implemented by using
max_retries sysfs attribute, to hold the amount of times we allow
the filesystem to retry after an error. Being -1 a special case
where the filesystem will retry indefinitely.

Add both a maximum retry count and a retry timeout so that we can
bound by time and/or physical IO attempts.

Finally, plumb these into xfs_buf_iodone error processing so that
the error behaviour follows the selected configuration.

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: introduce table-based init for error behaviors

2016-05-18T01:06:44+00:00

Before we start expanding the number of error classes and errors we
can configure behaviour for, we need a simple and clear way to
define the default behaviour that we initialized each mount with.
Introduce a table based method for keeping the initial configuration
in, and apply that to the existing initialization code.

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: add configurable error support to metadata buffers

2016-05-18T01:05:33+00:00

With the error configuration handle for async metadata write errors
in place, we can now add initial support to the IO error processing
in xfs_buf_iodone_error().

Add an infrastructure function to look up the configuration handle,
and rearrange the error handling to prepare the way for different
error handling conigurations to be used.

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner

xfs: introduce metadata IO error class

2016-05-18T01:01:00+00:00

Now we have the basic infrastructure, add the first error class so
we can build up the infrastructure in a meaningful way. Add the
metadata async write IO error class and sysfs entry, and introduce a
default configuration that matches the existing "retry forever"
behavior for async write metadata buffers.

Signed-off-by: Dave Chinner 
Signed-off-by: Carlos Maiolino 
Reviewed-by: Brian Foster 
Signed-off-by: Dave Chinner