linux-toradex.git/fs/xfs, branch v2.6.23.2

Revert "[XFS] Avoid replaying inode buffer initialisation log items if on-disk version is newer."

2007-10-01T14:59:03+00:00

This reverts commit b394e43e995d08821588a22561c6a71a63b4ff27.

Lachlan McIlroy says:
    It tried to fix an issue where log replay is replaying an inode cluster
    initialisation transaction that should not be replayed because the inode
    cluster on disk is more up to date.  Since we don't log file sizes (we
    rely on inode flushing to get them to disk) then we can't just replay
    all the transations in the log and expect the inode to be completely
    restored.  We lose file size updates.  Unfortunately this fix is causing
    more (serious) problems than it is fixing.

SGI-PV: 969656
SGI-Modid: xfs-linux-melb:xfs-kern:29804a

Signed-off-by: Lachlan McIlroy 
Signed-off-by: Tim Shimmin

[XFS] fix valid but harmless sparse warning

2007-09-20T09:40:40+00:00

The new xlog_recover_do_reg_buffer checks call be16_to_cpu on di_gen which
is a 32bit value so sparse rightly complains. Fortunately the warning is
harmless because we don't care for the value, but only whether it's
non-NULL. Due to that fact we can simply kill the endian swaps on this and
the previous di_mode check entirely.

SGI-PV: 969656
SGI-Modid: xfs-linux-melb:xfs-kern:29709a

Signed-off-by: Christoph Hellwig 
Signed-off-by: Lachlan McIlroy 
Signed-off-by: Tim Shimmin

[XFS] fix filestreams on 32-bit boxes

2007-09-20T09:40:19+00:00

xfs_filestream_mount() sets up an mru cache with:
  err = xfs_mru_cache_create(&mp->m_filestream, lifetime, grp_count,
  (xfs_mru_cache_free_func_t)xfs_fstrm_free_func);
but that cast is causing problems...
  typedef void (*xfs_mru_cache_free_func_t)(unsigned long, void*);
but:
  void xfs_fstrm_free_func( xfs_ino_t ino, fstrm_item_t *item)
so on a 32-bit box, it's casting (32, 32) args into (64, 32) and I assume
it's getting garbage for *item, which subsequently causes an explosion.
With this change the filestreams xfsqa tests don't oops on my 32-bit box.

SGI-PV: 967795
SGI-Modid: xfs-linux-melb:xfs-kern:29510a

Signed-off-by: Eric Sandeen 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] Avoid replaying inode buffer initialisation log items if on-disk version is newer.

2007-09-18T10:16:00+00:00

SGI-PV: 969656
SGI-Modid: xfs-linux-melb:xfs-kern:29676a

Signed-off-by: Lachlan McIlroy 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] Ensure file size updates have been completed before writing inode to disk.

2007-09-18T10:12:51+00:00

SGI-PV: 968767
SGI-Modid: xfs-linux-melb:xfs-kern:29675a

Signed-off-by: Lachlan McIlroy 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] On-demand reaping of the MRU cache

2007-09-17T06:42:02+00:00

Instead of running the mru cache reaper all the time based on a timeout,
we should only run it when the cache has active objects. This allows CPUs
to sleep when there is no activity rather than be woken repeatedly just to
check if there is anything to do.

SGI-PV: 968554
SGI-Modid: xfs-linux-melb:xfs-kern:29305a

Signed-off-by: David Chinner 
Signed-off-by: Donald Douwsma 
Signed-off-by: Tim Shimmin

[XFS] fix nasty quota hashtable allocation bug

2007-09-05T04:51:04+00:00

This git mod: 77e4635ae191774526ed695482a151ac986f3806
converted to a "greedy" allocation interface, but for the quota hashtables
it switched from allocating XFS_QM_HASHSIZE (nr of elements)
xfs_dqhash_t's to allocating only XFS_QM_HASHSIZE *bytes* - quite a lot
smaller! Then when we converted hsize "back" to nr of elements (the
division line) hsize went to 0. This was leading to oopses when running
any quota tests on the Fedora 8 test kernel, but the problem has been
there for almost a year.

SGI-PV: 968837
SGI-Modid: xfs-linux-melb:xfs-kern:29354a

Signed-off-by: Eric Sandeen 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] fix sparse shadowed variable warnings

2007-09-05T04:50:26+00:00

- in xfs_probe_cluster rename the inner len to pg_len. There's no harm
  here because the outer len isn't used after the inner len comes into
  existence but it keeps the code clean.
- in xfs_da_do_buf remove the inner i because they don't overlap
  and they are both the same type.

SGI-PV: 968555
SGI-Modid: xfs-linux-melb:xfs-kern:29311a

Signed-off-by: Christoph Hellwig 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] fix ASSERT and ASSERT_ALWAYS

2007-09-05T04:49:30+00:00

- remove the != 0 inside the unlikely in ASSERT_ALWAYS because sparse now
  complains about comparisons between pointers and 0
- add a standalone ASSERT implementation because defining it to
  ASSERT_ALWAYS means the string is expanded before the token passing
  stringification. This way we get the actual content of the
  assertion in the assfail message and don't overflow sparse's
  stringification buffer leading to sparse error messages.

SGI-PV: 968555
SGI-Modid: xfs-linux-melb:xfs-kern:29310a

Signed-off-by: Christoph Hellwig 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] Fix sparse warning in kmem_shake_allow

2007-09-05T04:48:00+00:00

We can't return a masked result of a __bitwise type. Compare it to 0 first
to keep the behaviour without the warning.

SGI-PV: 968555
SGI-Modid: xfs-linux-melb:xfs-kern:29309a

Signed-off-by: Christoph Hellwig 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin