linux-toradex.git/fs, branch v2.6.21

reiserfs: fix xattr root locking/refcount bug

2007-04-24T15:23:09+00:00

The listxattr() and getxattr() operations are only protected by a read
lock.  As a result, if either of these operations run in parallel, a race
condition exists where the xattr_root will end up being cached twice, which
results in the leaking of a reference and a BUG() on umount.

This patch refactors get_xa_root(), __get_xa_root(), and create_xa_root(),
into one get_xa_root() function that takes the appropriate locking around
the entire critical section.

Reported, diagnosed and tested by Andrea Righi 

Signed-off-by: Jeff Mahoney 
Cc: Andrea Righi 
Cc: "Vladimir V. Saveliev" 
Cc: Edward Shishkin 
Cc: Alex Zarochentsev 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

v9fs: don't use primary fid when removing file

2007-04-24T15:23:08+00:00

v9fs_insert uses v9fs_fid_lookup (which also locks the fid) to get the
primary fid associated with the dentry and destroys the v9fs_fid struct
after removing the file.  If another process called v9fs_fid_lookup on the
same dentry, it may wait undefinitely for the fid's lock (as the struct is
freed).

This patch changes v9fs_remove to use a cloned fid, so the primary fid is
not locked and freed.

Signed-off-by: Latchesar Ionkov 
Cc: Eric Van Hensbergen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

NFS: Fix race in nfs_set_page_dirty

2007-04-21T05:56:30+00:00

Protect nfs_set_page_dirty() against races with nfs_inode_add_request.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

NFS: Fix the 'desynchronized value of nfs_i.ncommit' error

2007-04-21T05:56:29+00:00

Redirtying a request that is already marked for commit will screw up the
accounting for NR_UNSTABLE_NFS as well as nfs_i.ncommit.
Ensure that all requests on the commit queue are labelled with the
PG_NEED_COMMIT flag, and avoid moving them onto the dirty list inside
nfs_page_mark_flush().

Also inline nfs_mark_request_dirty() into nfs_page_mark_flush() for
atomicity reasons. Avoid dropping the spinlock until we're done marking the
request in the radix tree and have added it to the ->dirty list.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

NFS: Don't clear PG_writeback until after we've processed unstable writes

2007-04-21T05:56:29+00:00

Ensure that we don't release the PG_writeback lock until after the page has
either been redirtied, or queued on the nfs_inode 'commit' list.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

NFS: clean up the unstable write code

2007-04-21T05:56:29+00:00

Get rid of the inlined #ifdefs.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

ufs proper handling of zero link case

2007-04-17T23:36:27+00:00

This patch should fix or partly fix this bug:
http://bugzilla.kernel.org/show_bug.cgi?id=8276

The problem is:

- if we see "zero link case" during reading inode operation, we call
  ufs_error(which remount fs readonly), but not "mark" inode as bad (1)

- in readonly case we do not fill some data structures, which are used in
  read and write case (2)

- VFS call ufs_delete_inode if link count is zero (3)

so (1)->(3)->(2) cause oops, this patch should fix such scenario

Signed-off-by: Evgeniy Dushistov 
Cc: Jim Paris 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

exec.c: fix coredump to pipe problem and obscure "security hole"

2007-04-17T23:36:26+00:00

The patch checks for "|" in the pattern not the output and doesn't nail a
pid on to a piped name (as it is a program name not a file)

Also fixes a very very obscure security corner case.  If you happen to have
decided on a core pattern that starts with the program name then the user
can run a program called "|myevilhack" as it stands.  I doubt anyone does
this.

Signed-off-by: Alan Cox 
Confirmed-by: Christopher S. Aker 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

NFS: Fix a list corruption problem

2007-04-15T23:48:11+00:00

We must remove the request from whatever list it is currently on before we
can add it to the dirty list.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

NFS: Ensure PG_writeback is cleared when writeback fails

2007-04-15T04:46:48+00:00

If the writebacks are cancelled via nfs_cancel_dirty_list, or due to the
memory allocation failing in nfs_flush_one/nfs_flush_multi, then we must
ensure that the PG_writeback flag is cleared.

Also ensure that we actually own the PG_writeback flag whenever we
schedule a new writeback by making nfs_set_page_writeback() return the
value of test_set_page_writeback().
The PG_writeback page flag ends up replacing the functionality of the
PG_FLUSHING nfs_page flag, so we rip that out too.

Signed-off-by: Trond Myklebust 
Cc: Peter Zijlstra 
Signed-off-by: Linus Torvalds