linux-toradex.git/fs, branch v2.6.33.2

GFS2: Skip check for mandatory locks when unlocking

2010-04-01T23:02:15+00:00

commit 720e7749279bde0d08684b1bb4e7a2eedeec6394 upstream.

gfs2_lock() will skip locks on file which have mode set to 02666. This is a problem in cases where the mode of the file is changed after a process has obtained a lock on the file. Such a lock will be skipped and will result in a BUG in locks_remove_flock().

gfs2_lock() should skip the check for mandatory locks when unlocking a file.

Signed-off-by: Sachin Prabhu 
Signed-off-by: Steven Whitehouse 
Signed-off-by: Greg Kroah-Hartman

quota: Fix warning when a delayed write happens before quota is enabled

2010-04-01T23:02:12+00:00

commit 0a5a9c725512461d19397490f3adf29931dca1f2 upstream.

If a delayed-allocation write happens before quota is enabled, the
kernel spits out a warning:
WARNING: at fs/quota/dquot.c:988 dquot_claim_space+0x77/0x112()

because the fact that user has some delayed allocation is not recorded
in quota structure.

Make dquot_initialize() update amount of reserved space for user if it sees
inode has some space reserved. Also make sure that reserved quota space does
not go negative and we warn about the filesystem bug just once.

Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

quota: manage reserved space when quota is not active [v2]

2010-04-01T23:02:12+00:00

commit c469070aea5a0ada45a836937c776fd3083dae2b upstream.

Since we implemented generic reserved space management interface,
then it is possible to account reserved space even when quota
is not active (similar to i_blocks/i_bytes).

Without this patch following testcase result in massive comlain from
WARN_ON in dquot_claim_space()

TEST_CASE:
mount /dev/sdb /mnt -oquota
dd if=/dev/zero of=/mnt/test bs=1M count=1
quotaon /mnt
# fs_reserved_spave == 1Mb
# quota_reserved_space == 0, because quota was disabled
dd if=/dev/zero of=/mnt/test seek=1 bs=1M count=1
# fs_reserved_spave == 2Mb
# quota_reserved_space == 1Mb
sync  # ->dquot_claim_space() -> WARN_ON

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

nilfs2: fix hang-up of cleaner after log writer returned with error

2010-04-01T23:01:50+00:00

commit 110d735a0ae69bdd11af9acb6ea3b979137eb118 upstream.

According to the report from Andreas Beckmann (Message-ID:
<4BA54677.3090902@abeckmann.de>), nilfs in 2.6.33 kernel got stuck
after a disk full error.

This turned out to be a regression by log writer updates merged at
kernel 2.6.33.  nilfs_segctor_abort_construction, which is a cleanup
function for erroneous cases, was skipping writeback completion for
some logs.

This fixes the bug and would resolve the hang issue.

Reported-by: Andreas Beckmann 
Signed-off-by: Ryusuke Konishi 
Tested-by: Ryusuke Konishi 
Signed-off-by: Greg Kroah-Hartman

fs/partition/msdos: fix unusable extended partition for > 512B sector

2010-04-01T23:01:47+00:00

commit 8e0cc811e0f8029a7225372fb0951fab102c012f upstream.

Smaller size than a minimum blocksize can't be used, after all it's
handled like 0 size.

For extended partition itself, this makes sure to use bigger size than one
logical sector size at least.

Signed-off-by: OGAWA Hirofumi 
Cc: Daniel Taylor 
Cc: "H. Peter Anvin" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

fs/partitions/msdos: add support for large disks

2010-04-01T23:01:47+00:00

commit 3fbf586cf7f245392142e5407c2a56f1cff979b6 upstream.

In order to use disks larger than 2TiB on Windows XP, it is necessary to
use 4096-byte logical sectors in an MBR.

Although the kernel storage and functions called from msdos.c used
"sector_t" internally, msdos.c still used u32 variables, which results in
the ability to handle XP-compatible large disks.

This patch changes the internal variables to "sector_t".

Daniel said: "In the near future, WD will be releasing products that need
this patch".

[hirofumi@mail.parknet.co.jp: tweaks and fix]
Signed-off-by: Daniel Taylor 
Signed-off-by: OGAWA Hirofumi 
Cc: "H. Peter Anvin" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

NFS: Prevent another deadlock in nfs_release_page()

2010-04-01T23:01:33+00:00

commit d812e575822a2b7ab1a7cadae2571505ec6ec2bd upstream.

We should not attempt to free the page if __GFP_FS is not set. Otherwise we
can deadlock as per

  http://bugzilla.kernel.org/show_bug.cgi?id=15578

Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

NFS: Avoid a deadlock in nfs_release_page

2010-04-01T23:01:33+00:00

commit bb6fbc4548b9ae7ebbd06ef72f00229df259d217 upstream.

J.R. Okajima reports the following deadlock:

INFO: task kswapd0:305 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kswapd0       D 0000000000000001     0   305      2 0x00000000
 ffff88001f21d4f0 0000000000000046 ffff88001fdea680 ffff88001f21c000
 ffff88001f21dfd8 ffff88001f21c000 ffff88001f21dfd8 ffff88001f21dfd8
 ffff88001fdea040 0000000000014c00 0000000000000001 ffff88001fdea040
Call Trace:
 [] io_schedule+0x4d/0x70
 [] sync_page+0x65/0xa0
 [] __wait_on_bit_lock+0x52/0xb0
 [] ? sync_page+0x0/0xa0
 [] __lock_page+0x64/0x70
 [] ? wake_bit_function+0x0/0x40
 [] truncate_inode_pages_range+0x344/0x4a0
 [] truncate_inode_pages+0x10/0x20
 [] generic_delete_inode+0x15e/0x190
 [] generic_drop_inode+0x5d/0x80
 [] iput+0x78/0x80
 [] nfs_dentry_iput+0x38/0x50
 [] dentry_iput+0x84/0x110
 [] d_kill+0x2e/0x60
 [] dput+0x7a/0x170
 [] path_put+0x15/0x40
 [] __put_nfs_open_context+0xa4/0xb0
 [] ? nfs_free_request+0x0/0x50
 [] put_nfs_open_context+0xb/0x10
 [] nfs_free_request+0x29/0x50
 [] kref_put+0x8e/0xe0
 [] nfs_release_request+0x14/0x20
 [] nfs_find_and_lock_request+0x89/0xa0
 [] nfs_wb_page+0x80/0x110
 [] nfs_release_page+0x70/0x90
 [] try_to_release_page+0x5e/0x80
 [] shrink_page_list+0x638/0x860
 [] shrink_zone+0x63e/0xc40

We can fix this by making the call to put_nfs_open_context() happen when we
actually remove the write request from the inode (which is done by the
nfsiod thread in this case).

Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

NFSv4: Don't ignore the NFS_INO_REVAL_FORCED flag in nfs_revalidate_inode()

2010-04-01T23:01:33+00:00

commit b4d2314bb88b07e5a04e6c75b442a1dfcd60e340 upstream.

If the NFS_INO_REVAL_FORCED flag is set, that means that we don't yet have
an up to date attribute cache. Even if we hold a delegation, we must
put a GETATTR on the wire.

Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

coredump: suppress uid comparison test if core output files are pipes

2010-04-01T23:01:18+00:00

commit 76595f79d76fbe6267a51b3a866a028d150f06d4 upstream.

Modify uid check in do_coredump so as to not apply it in the case of
pipes.

This just got noticed in testing.  The end of do_coredump validates the
uid of the inode for the created file against the uid of the crashing
process to ensure that no one can pre-create a core file with different
ownership and grab the information contained in the core when they
shouldn' tbe able to.  This causes failures when using pipes for a core
dumps if the crashing process is not root, which is the uid of the pipe
when it is created.

The fix is simple.  Since the check for matching uid's isn't relevant for
pipes (a process can't create a pipe that the uermodehelper code will open
anyway), we can just just skip it in the event ispipe is non-zero

Reverts a pipe-affecting change which was accidentally made in

: commit c46f739dd39db3b07ab5deb4e3ec81e1c04a91af
: Author:     Ingo Molnar 
: AuthorDate: Wed Nov 28 13:59:18 2007 +0100
: Commit:     Linus Torvalds 
: CommitDate: Wed Nov 28 10:58:01 2007 -0800
:
:     vfs: coredumping fix

Signed-off-by: Neil Horman 
Cc: Andi Kleen 
Cc: Oleg Nesterov 
Cc: Alan Cox 
Cc: Al Viro 
Cc: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Cc: maximilian attems 
Signed-off-by: Greg Kroah-Hartman