linux-toradex.git/fs, branch v3.7-rc4

NFS4: nfs4_opendata_access should return errno

2012-11-02T22:51:54+00:00

Return errno - not an NFS4ERR_. This worked because NFS4ERR_ACCESS == EACCES.

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust

NFSv4: Initialise the NFSv4.1 slot table highest_used_slotid correctly

2012-11-01T16:02:03+00:00

Signed-off-by: Trond Myklebust

NFS: add nfs_sb_deactive_async to avoid deadlock

2012-10-31T20:26:26+00:00

Use nfs_sb_deactive_async instead of nfs_sb_deactive when in a workqueue
context.  This avoids a deadlock where rpc_shutdown_client loops forever
in a workqueue kworker context, trying to kill all RPC tasks associated with
the client, while one or more of these tasks have already been assigned to the
same kworker (and will never run rpc_exit_task).

This approach is needed because RPC tasks that have already been assigned
to a kworker by queue_work cannot be canceled, as explained in the comment
for workqueue.c:insert_wq_barrier.

Signed-off-by: Weston Andros Adamson 
[Trond: add module_get/put.]
Signed-off-by: Trond Myklebust

nfs: Show original device name verbatim in /proc/*/mount{s,info}

2012-10-31T20:26:26+00:00

Since commit c7f404b ('vfs: new superblock methods to override
/proc/*/mount{s,info}'), nfs_path() is used to generate the mounted
device name reported back to userland.

nfs_path() always generates a trailing slash when the given dentry is
the root of an NFS mount, but userland may expect the original device
name to be returned verbatim (as it used to be).  Make this
canonicalisation optional and change the callers accordingly.

[jrnieder@gmail.com: use flag instead of bool argument]
Reported-and-tested-by: Chris Hiestand 
Reference: http://bugs.debian.org/669314
Signed-off-by: Ben Hutchings 
Cc:  # v2.6.39+
Signed-off-by: Jonathan Nieder 
Signed-off-by: Trond Myklebust

nfsv3: Make v3 mounts fail with ETIMEDOUTs instead EIO on mountd timeouts

2012-10-31T20:26:25+00:00

In very busy v3 environment, rpc.mountd can respond to the NULL
procedure but not the MNT procedure in a timely manner causing
the MNT procedure to time out. The problem is the mount system
call returns EIO which causes the mount to fail, instead of
ETIMEDOUT, which would cause the mount to be retried.

This patch sets the RPC_TASK_SOFT|RPC_TASK_TIMEOUT flags to
the rpc_call_sync() call in nfs_mount() which causes
ETIMEDOUT to be returned on timed out connections.

Signed-off-by: Steve Dickson 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

nfs: Check whether a layout pointer is NULL before free it

2012-10-31T20:26:25+00:00

The new layout pointer in pnfs_find_alloc_layout() may be NULL because of
out of memory. we must do some check work, otherwise pnfs_free_layout_hdr()
will go wrong because it can not deal with a NULL pointer.

Signed-off-by: Yanchuan Nian 
Signed-off-by: Trond Myklebust

NFS: fix bug in legacy DNS resolver.

2012-10-31T20:25:59+00:00

The DNS resolver's use of the sunrpc cache involves a 'ttl' number
(relative) rather that a timeout (absolute).  This confused me when
I wrote
  commit c5b29f885afe890f953f7f23424045cdad31d3e4
     "sunrpc: use seconds since boot in expiry cache"

and I managed to break it.  The effect is that any TTL is interpreted
as 0, and nothing useful gets into the cache.

This patch removes the use of get_expiry() - which really expects an
expiry time - and uses get_uint() instead, treating the int correctly
as a ttl.

This fixes a regression that has been present since 2.6.37, causing
certain NFS accesses in certain environments to incorrectly fail.

Reported-by: Chuck Lever 
Tested-by: Chuck Lever 
Cc: stable@vger.kernel.org
Signed-off-by: NeilBrown 
Signed-off-by: Trond Myklebust

NFSv4: nfs4_locku_done must release the sequence id

2012-10-31T19:10:04+00:00

If the state recovery machinery is triggered by the call to
nfs4_async_handle_error() then we can deadlock.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

NFSv4.1: We must release the sequence id when we fail to get a session slot

2012-10-31T19:08:18+00:00

If we do not release the sequence id in cases where we fail to get a
session slot, then we can deadlock if we hit a recovery scenario.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

NFS: Wait for session recovery to finish before returning

2012-10-31T17:13:28+00:00

Currently, we will schedule session recovery and then return to the
caller of nfs4_handle_exception.  This works for most cases, but causes
a hang on the following test case:

	Client				Server
	------				------
	Open file over NFS v4.1
	Write to file
					Expire client
	Try to lock file

The server will return NFS4ERR_BADSESSION, prompting the client to
schedule recovery.  However, the client will continue placing lock
attempts and the open recovery never seems to be scheduled.  The
simplest solution is to wait for session recovery to run before retrying
the lock.

Signed-off-by: Bryan Schumaker 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org