linux-toradex.git/include/linux/amba/pl08x.h, branch v3.0.79

ARM: PL08x: cleanup comments

2011-01-17T00:55:43+00:00

Cleanup the formatting of comments, remove some which don't make sense
anymore.

Signed-off-by: Russell King 
[fix conflict with 96a608a4]
Signed-off-by: Dan Williams

ARM: PL08x: fix a warning

2011-01-15T01:51:11+00:00

drivers/dma/amba-pl08x.c: In function 'pl08x_start_txd':
drivers/dma/amba-pl08x.c:205: warning: dereferencing 'void *' pointer

We never dereference llis_va aside from assigning it to a struct
pl08x_lli pointer or calculating the address of array element 0.

Signed-off-by: Dan Williams

ARM: PL08x: fix locking between prepare function and submit function

2011-01-05T03:16:14+00:00

The PL08x driver holds on to the channel lock with interrupts disabled
between the prepare and the subsequent submit API functions.  This
means that the locking state when the prepare function returns is
dependent on whether it suceeeds or not.

It did this to ensure that the physical channel wasn't released, and
as it used to add the descriptor onto the pending list at prepare time
rather than submit time.

Now that we have reorganized the code to remove those reasons, we can
now safely release the spinlock at the end of preparation and reacquire
it in our submit function.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: introduce 'phychan_hold' to hold on to physical channels

2011-01-05T03:16:14+00:00

Introduce 'phychan_hold' to hold on to physical DMA channels while we're
preparing a new descriptor for it.  This will be incremented when we
allocate a physical channel and set the MUX registers during the
preparation of the TXD, and will only be decremented when the TXD is
submitted.

This prevents the physical channel being given up before the new TXD
is placed on the queue.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: rename 'desc_list' as 'pend_list'

2011-01-05T03:16:14+00:00

This 'desc_list' is actually a list of pending descriptors, so name
it after its function (pending list) rather than what it contains
(descriptors).

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: shrink srcbus/dstbus in txd structure

2011-01-05T03:16:13+00:00

We only need to store the dma address.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: allow AHB master port selection to be configured

2011-01-05T03:16:13+00:00

Platforms need to be able to control which AHB master interface is used,
as each AHB master interface may be asymetric.  Allow the interfaces
used for fetching LLIs, memory, and each peripheral to be configured
individually.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: move default cctl into txd structure

2011-01-05T03:16:12+00:00

Rather than modifying platform data while preparing a transfer, copy
the cctl value into the txd structure and modify the value there.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: move ccfg into txd structure

2011-01-05T03:16:12+00:00

The ccfg register is used to configure the channel parameters - the type
and direction of transfer, the flow control signal and IRQ mask enables.
The type and direction of transfer is known in the relevent prep_*
function where a txd is created.  The IRQ mask enables are always set,
and the flow control signals are always set when we start processing a
txd according to phychan->signal.

If we store the ccfg value in the txd structure, we can avoid modifying
platform data - and even having it in platform data at all.

So, remove it from platform data too.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams

ARM: PL08x: avoid duplicating registers in txd and phychan structures

2011-01-05T03:16:12+00:00

As we now have all the code accessing the phychan {csrc,cdst,clli,cctl,
ccfg} members in one function, there's no point storing the data into
the struct.  Get rid of the struct members.  Re-order the register dump
in the dev_dbg() to reflect the order we write the registers to the DMA
device.

The txd {csrc,cdst,clli,cctl} values are duplicates of the lli[0]
values, so there's no point duplicating these either.  Program the DMAC
registers directly from the lli[0] values.

Signed-off-by: Russell King 
Acked-by: Linus Walleij 
Signed-off-by: Dan Williams