linux-toradex.git/include/linux/avf, branch v6.9-rc5

intel: add bit macro includes where needed

2023-12-18T19:15:43+00:00

This series is introducing the use of FIELD_GET and FIELD_PREP which
requires bitfield.h to be included. Fix all the includes in this one
change, and rearrange includes into alphabetical order to ease
readability and future maintenance.

virtchnl.h and it's usage was modified to have it's own includes as it
should. This required including bits.h for virtchnl.h.

Reviewed-by: Marcin Szycik 
Signed-off-by: Jesse Brandeburg 
Signed-off-by: Tony Nguyen

iavf: enable symmetric-xor RSS for Toeplitz hash function

2023-12-14T06:07:17+00:00

Allow the user to set the symmetric Toeplitz hash function via:

    # ethtool -X eth0 hfunc toeplitz symmetric-xor

The driver will reject any new RSS configuration if a field other than
(IP src/dst and L4 src/dst ports) is requested for hashing.

The symmetric RSS will not be supported on PFs not advertising the ADV RSS
Offload flag (ADV_RSS_SUPPORT()), for example the E700 series (i40e).

Reviewed-by: Madhu Chittim 
Signed-off-by: Ahmed Zaki 
Link: https://lore.kernel.org/r/20231213003321.605376-9-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski

ice: refactor RSS configuration

2023-12-14T06:07:17+00:00

Refactor the driver to use a communication data structure for RSS
config. To do so we introduce the new ice_rss_hash_cfg struct, and then
pass it as an argument to several functions.

Also introduce enum ice_rss_cfg_hdr_type to specify a more granular and
flexible RSS configuration:

ICE_RSS_OUTER_HEADERS - take outer layer as RSS input set
ICE_RSS_INNER_HEADERS - take inner layer as RSS input set
ICE_RSS_INNER_HEADERS_W_OUTER_IPV4 - take inner layer as RSS input set for
                                     packet with outer IPV4
ICE_RSS_INNER_HEADERS_W_OUTER_IPV6 - take inner layer as RSS input set for
                                     packet with outer IPV6
ICE_RSS_ANY_HEADERS - try with outer first then inner (same as the
		      behaviour without this change)

Finally, move the virtchnl_rss_algorithm enum to be with the other RSS
related structures in the virtchnl.h file.

There should be no functional change due to this patch.

Reviewed-by: Wojciech Drewek 
Signed-off-by: Qi Zhang 
Co-developed-by: Jesse Brandeburg 
Signed-off-by: Jesse Brandeburg 
Co-developed-by: Ahmed Zaki 
Signed-off-by: Ahmed Zaki 
Link: https://lore.kernel.org/r/20231213003321.605376-6-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski

virtchnl: Add header dependencies

2023-10-05T16:13:42+00:00

The  uses BIT, struct_size and ETH_ALEN macros
but does not include appropriate header files that defines them.
Add these dependencies so this header file can be included anywhere.

Signed-off-by: Ivan Vecera 
Reviewed-by: Przemek Kitszel 
Reviewed-by: Jesse Brandeburg 
Reviewed-by: Aleksandr Loktionov 
Signed-off-by: Tony Nguyen

virtchnl: Add CRC stripping capability

2023-09-13T15:50:49+00:00

Some VFs may want to disable CRC stripping on incoming packets so create
an offload for that. The VF already sends information about configuring
its RX queues so use that structure to indicate that the CRC stripping
should be enabled or not.

Signed-off-by: Paul M Stillwell Jr 
Reviewed-by: Jesse Brandeburg 
Reviewed-by: Paul Menzel 
Signed-off-by: Ahmed Zaki 
Signed-off-by: Tony Nguyen

virtchnl: fix fake 1-elem arrays for structures allocated as `nents`

2023-08-16T16:14:14+00:00

Finally, fix 3 structures which are allocated technically correctly,
i.e. the calculated size equals to the one that struct_size() would
return, except for sizeof(). For &virtchnl_vlan_filter_list_v2, use
the same approach when there are no enough space as taken previously
for &virtchnl_vlan_filter_list, i.e. let the maximum size be calculated
automatically instead of trying to guestimate it using maths.

Signed-off-by: Alexander Lobakin 
Reviewed-by: Kees Cook 
Tested-by: Rafal Romanowski 
Signed-off-by: Tony Nguyen

virtchnl: fix fake 1-elem arrays in structures allocated as `nents + 1`

2023-08-16T16:05:04+00:00

There are five virtchnl structures, which are allocated and checked in
the code as `nents + 1`, meaning that they always have memory for one
excessive element regardless of their actual number. This comes from
that their sizeof() includes space for 1 element and then they get
allocated via struct_size() or its open-coded equivalents, passing
the actual number of elements.
Expand virtchnl_struct_size() to handle such structures and replace
those 1-elem arrays with proper flex ones. Also fix several places
which open-code %IAVF_VIRTCHNL_VF_RESOURCE_SIZE. Finally, let the
virtchnl_ether_addr_list size be computed automatically when there's
no enough space for the whole list, otherwise we have to open-code
reverse struct_size() logics.

Signed-off-by: Alexander Lobakin 
Reviewed-by: Kees Cook 
Tested-by: Rafal Romanowski 
Signed-off-by: Tony Nguyen

virtchnl: fix fake 1-elem arrays in structs allocated as `nents + 1` - 1

2023-08-16T15:56:56+00:00

The two most problematic virtchnl structures are virtchnl_rss_key and
virtchnl_rss_lut. Their "flex" arrays have the type of u8, thus, when
allocating / checking, the actual size is calculated as `sizeof +
nents - 1 byte`. But their sizeof() is not 1 byte larger than the size
of such structure with proper flex array, it's two bytes larger due to
the padding. That said, their size is always 1 byte larger unless
there are no tail elements -- then it's +2 bytes.
Add virtchnl_struct_size() macro which will handle this case (and later
other cases as well). Make its calling conv the same as we call
struct_size() to allow it to be drop-in, even though it's unlikely to
become possible to switch to generic API. The macro will calculate a
proper size of a structure with a flex array at the end, so that it
becomes transparent for the compilers, but add the difference from the
old values, so that the real size of sorta-ABI-messages doesn't change.
Use it on the allocation side in IAVF and the receiving side (defined
as static inline in virtchnl.h) for the mentioned two structures.

Signed-off-by: Alexander Lobakin 
Reviewed-by: Kees Cook 
Tested-by: Rafal Romanowski 
Signed-off-by: Tony Nguyen

virtchnl: i40e/iavf: rename iwarp to rdma

2023-01-25T16:55:19+00:00

Since the latest Intel hardware does both IWARP and ROCE, rename the
term IWARP in the virtchnl header to be RDMA. Do this for both upper and
lower case instances. Many of the non-virtchnl.h changes were done with
regular expression replacements using perl like:
perl -p -i -e 's/_IWARP/_RDMA/' 
perl -p -i -e 's/_iwarp/_rdma/' 
and I had to pick up a few instances manually.

The virtchnl.h header has some comments and clarity added around when to
use certain defines.

note: had to fix a checkpatch warning for a long line by wrapping one of
the lines I changed.

Signed-off-by: Jesse Brandeburg 
Tested-by: Jakub Andrysiak 
Signed-off-by: Tony Nguyen

virtchnl: do structure hardening

2023-01-25T16:55:19+00:00

The virtchnl interface can have a bunch of "soft" defined structures
hardened by using explicit sizes for declarations, and then referring to
the enum type that uses them in a comment. None of these changes should
change any of the structure sizes.

Also, remove a duplicate line in a switch statement and let two cases
uses the same code.

Signed-off-by: Jesse Brandeburg 
Tested-by: Marek Szlosek 
Signed-off-by: Tony Nguyen