linux-toradex.git/include/linux/bio.h, branch v3.14.3

block: Fix for_each_bvec()

2014-05-06T14:59:36+00:00

commit b7aa84d9cb9f26da1a9312c3e39dbd1a3c25a426 upstream.

Commit 4550dd6c6b062 introduced for_each_bvec() which iterates over each
bvec attached to a bio or bip. However, the macro fails to check bi_size
before dereferencing which can lead to crashes while counting/mapping
integrity scatterlist segments.

Signed-off-by: Martin K. Petersen 
Cc: Kent Overstreet 
Cc: Nicholas Bellinger 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: Fix cloning of discard/write same bios

2014-02-11T15:40:45+00:00

Immutable biovecs changed the way bio segments are treated in such a way that
bio_for_each_segment() cannot now do what we want for discard/write same bios,
since bi_size means something completely different for them.

Fortunately discard and write same bios never have more than a single biovec, so
bio_for_each_segment() is unnecessary and not terribly meaningful for them, but
we still have to special case them in a few places.

Signed-off-by: Kent Overstreet 
Tested-by: Richard W.M. Jones 
Signed-off-by: Jens Axboe

fs: Add prototype declaration to appropriate header file include/linux/bio.h

2014-02-09T20:56:23+00:00

Add prototype declaration to header file include/linux/bio.h because it
is used by more than one file.

This eliminates the following warning in bio-integrity.c:
fs/bio-integrity.c:214:14: warning: no previous prototype for ‘bio_integrity_tag_size’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: Jens Axboe

block: Kill bio_pair_split()

2013-11-24T06:33:57+00:00

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe

block: Introduce new bio_split()

2013-11-24T06:33:57+00:00

The new bio_split() can split arbitrary bios - it's not restricted to
single page bios, like the old bio_split() (previously renamed to
bio_pair_split()). It also has different semantics - it doesn't allocate
a struct bio_pair, leaving it up to the caller to handle completions.

Then convert the existing bio_pair_split() users to the new bio_split()
- and also nvme, which was open coding bio splitting.

(We have to take that BUG_ON() out of bio_integrity_trim() because this
bio_split() needs to use it, and there's no reason it has to be used on
bios marked as cloned; BIO_CLONED doesn't seem to have clearly
documented semantics anyways.)

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe 
Cc: Martin K. Petersen 
Cc: Matthew Wilcox 
Cc: Keith Busch 
Cc: Vishal Verma 
Cc: Jiri Kosina 
Cc: Neil Brown

block: Rename bio_split() -> bio_pair_split()

2013-11-24T06:33:56+00:00

This is prep work for introducing a more general bio_split().

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe 
Cc: NeilBrown 
Cc: Alasdair Kergon 
Cc: Lars Ellenberg 
Cc: Peter Osterlund 
Cc: Sage Weil

block: Generic bio chaining

2013-11-24T06:33:56+00:00

This adds a generic mechanism for chaining bio completions. This is
going to be used for a bio_split() replacement, and it turns out to be
very useful in a fair amount of driver code - a fair number of drivers
were implementing this in their own roundabout ways, often painfully.

Note that this means it's no longer to call bio_endio() more than once
on the same bio! This can cause problems for drivers that save/restore
bi_end_io. Arguably they shouldn't be saving/restoring bi_end_io at all
- in all but the simplest cases they'd be better off just cloning the
bio, and immutable biovecs is making bio cloning cheaper. But for now,
we add a bio_endio_nodec() for these cases.

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe

dm: Refactor for new bio cloning/splitting

2013-11-24T06:33:55+00:00

We need to convert the dm code to the new bvec_iter primitives which
respect bi_bvec_done; they also allow us to drastically simplify dm's
bio splitting code.

Also, it's no longer necessary to save/restore the bvec array anymore -
driver conversions for immutable bvecs are done, so drivers should never
be modifying it.

Also kill bio_sector_offset(), dm was the only user and it doesn't make
much sense anymore.

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe 
Cc: Alasdair Kergon 
Cc: dm-devel@redhat.com
Reviewed-by: Mike Snitzer

block: Add bio_clone_fast()

2013-11-24T06:33:54+00:00

bio_clone() just got more expensive - however, most users of bio_clone()
don't actually need to modify the biovec. If they aren't modifying the
biovec, and they can guarantee that the original bio isn't freed before
the clone (also true in most cases), we can just point the clone at the
original bio's biovec.

Signed-off-by: Kent Overstreet

block: Kill bio_iovec_idx(), __bio_iovec()

2013-11-24T06:33:53+00:00

bio_iovec_idx() and __bio_iovec() don't have any valid uses anymore -
previous users have been converted to bio_iovec_iter() or other methods.

__BVEC_END() has to go too - the bvec array can't be used directly for
the last biovec because we might only be using the first portion of it,
we have to iterate over the bvec array with bio_for_each_segment() which
checks against the current value of bi_iter.bi_size.

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe