linux-toradex.git/include/linux/err.h, branch v4.13-rc4

make IS_ERR_VALUE() complain about non-pointer-sized arguments

2016-05-27T23:03:22+00:00

Now that the allmodconfig x86-64 build is clean wrt IS_ERR_VALUE() uses
on integers, add a cast to a pointer and back to the argument, so that
any new mis-uses of IS_ERR_VALUE() will cause warnings like

   warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

so that we don't re-introduce any bogus uses.

Signed-off-by: Linus Torvalds

err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2016-01-16T19:17:24+00:00

IS_ERR_VALUE() already contains it and so we need to add this only to
the !ptr check.  That will allow users of IS_ERR_OR_NULL(), to not add
this compiler flag.

Signed-off-by: Viresh Kumar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

err.h: use bool for IS_ERR and IS_ERR_OR_NULL

2014-04-03T23:21:06+00:00

Use the more natural return of bool for these tests.

No difference observed in .o files produced by gcc for x86.

Remove the dentry description of kernel pointers left over from the 90's
and 2002's cleanup move of parts of fs.h to err.h.

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

PTR_RET is now PTR_ERR_OR_ZERO

2013-07-15T01:55:00+00:00

True, it's often used in return statements, but after much bikeshedding
it's probably better to have an explicit name.

(I tried just putting the IS_ERR check inside PTR_ERR itself and gcc
usually generated no more code.  But that clashes current expectations
of how PTR_ERR behaves, so having a separate function is better).

Suggested-by: Julia Lawall 
Suggested-by: "Michael S. Tsirkin" 
Cc: Julia Lawall 
Cc: "Michael S. Tsirkin" 
Signed-off-by: Rusty Russell

err.h: IS_ERR() can accept __user pointers

2013-07-03T23:07:41+00:00

Sparse generates a false positive when you pass a __user or __iomem
pointer to the IS_ERR() functions.

  drivers/rtc/rtc-ds1286.c:344:36: sparse: incorrect type in argument 1 (different address spaces)
  drivers/rtc/rtc-ds1286.c:344:36:    expected void const *ptr
  drivers/rtc/rtc-ds1286.c:344:36:    got unsigned int [noderef] [usertype] *rtcregs

We can silence these by adding a __force here and upgrading to Sparse
v0.4.5-rc1 or later.

This change has no effect when using current Sparse releases.

Signed-off-by: Dan Carpenter 
Acked-by: Christopher Li 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

include/linux/err.h: add a function to cast error-pointers to a return value

2011-03-23T00:44:11+00:00

PTR_RET() can be used if you have an error-pointer and are only interested
in the eventual error value, but not the pointer.  Yields the usual 0 for
no error, -ESOMETHING otherwise.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

err.h: add __must_check to error pointer handlers

2010-05-25T15:07:02+00:00

Add __must_check to error pointer handlers to have the compiler warn about
mistakes like:

	if (err)
		ERR_PTR(err);

It found two bugs:

Mar 12 Nikula Jani [PATCH] enclosure: fix error path - actually return ERR_PTR() on error
Mar 12 Nikula Jani [PATCH] sunrpc: fix error path - actually return ERR_PTR() on error

Signed-off-by: Jani Nikula 
Cc: Phil Carmody 
Cc: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

err.h: add helper function to simplify pointer error checking

2009-12-15T16:53:27+00:00

There are quite a few instances in the kernel of checks of pointers both
against NULL and against the errno range, handling both cases identically.
This additional helper function would simplify such code.

[akpm@linux-foundation.org: build fix]
Signed-off-by: Phil Carmody 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Add an ERR_CAST() function to complement ERR_PTR and co.

2008-02-07T16:42:25+00:00

Add an ERR_CAST() function to complement ERR_PTR and co.  for the purposes
of casting an error entyped as one pointer type to an error of another
pointer type whilst making it explicit as to what is going on.

This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct.

Signed-off-by: David Howells 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] consistently use MAX_ERRNO in __syscall_return

2006-09-27T15:26:18+00:00

Consistently use MAX_ERRNO when checking for errors in __syscall_return().

[ralf@linux-mips.org: build fix]
Signed-off-by: Randy Dunlap 
Signed-off-by: Ralf Baechle 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds