linux-toradex.git/include/linux/ethtool.h, branch v2.6.35-rc3

net: fix ethtool coding style errors and warnings

2010-04-08T04:54:42+00:00

Fix coding style errors and warnings output while running checkpatch.pl
on the files net/core/ethtool.c and include/linux/ethtool.h

Signed-off-by: chavey 
Signed-off-by: David S. Miller

netdev: ethtool RXHASH flag

2010-03-31T06:51:08+00:00

This adds ethtool and device feature flag to allow control
of receive hashing offload.

Signed-off-by: Stephen Hemminger 
Acked-by: Jeff Garzik 
Signed-off-by: David S. Miller

ethtool: Add direct access to ops->get_sset_count

2010-03-05T22:00:17+00:00

On 03/04/2010 09:26 AM, Ben Hutchings wrote:
> On Thu, 2010-03-04 at 00:51 -0800, Jeff Kirsher wrote:
>> From: Jeff Garzik
>>
>> This patch is an alternative approach for accessing string
>> counts, vs. the drvinfo indirect approach.  This way the drvinfo
>> space doesn't run out, and we don't break ABI later.
> [...]
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -214,6 +214,10 @@ static noinline int ethtool_get_drvinfo(struct net_device *dev, void __user *use
>>   	info.cmd = ETHTOOL_GDRVINFO;
>>   	ops->get_drvinfo(dev,&info);
>>
>> +	/*
>> +	 * this method of obtaining string set info is deprecated;
>> +	 * consider using ETHTOOL_GSSET_INFO instead
>> +	 */
>
> This comment belongs on the interface (ethtool.h) not the
> implementation.

Debatable -- the current comment is located at the callsite of
ops->get_sset_count(), which is where an implementor might think to add
a new call.  Not all the numeric fields in ethtool_drvinfo are obtained
from ->get_sset_count().

Hence the "some" in the attached patch to include/linux/ethtool.h,
addressing your comment.

> [...]
>> +static noinline int ethtool_get_sset_info(struct net_device *dev,
>> +                                          void __user *useraddr)
>> +{
> [...]
>> +	/* calculate size of return buffer */
>> +	for (i = 0; i<  64; i++)
>> +		if (sset_mask&  (1ULL<<  i))
>> +			n_bits++;
> [...]
>
> We have a function for this:
>
> 	n_bits = hweight64(sset_mask);

Agreed.

I've attached a follow-up patch, which should enable my/Jeff's kernel
patch to be applied, followed by this one.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

ethtool: Add direct access to ops->get_sset_count

2010-03-05T22:00:17+00:00

This patch is an alternative approach for accessing string
counts, vs. the drvinfo indirect approach.  This way the drvinfo
space doesn't run out, and we don't break ABI later.

Signed-off-by: Jeff Garzik 
Signed-off-by: Peter P Waskiewicz Jr 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

Revert "ethtool: Add n-tuple string length to drvinfo and return it"

2010-02-26T13:12:02+00:00

This reverts commit c79c5ffdce14abb4de3878c5aa8c3c6e5093c69b.

As Jeff points out we can't break the user visible interface
like this, we need to add this into the reserved[] thing.

Signed-off-by: David S. Miller

ethtool: Add n-tuple string length to drvinfo and return it

2010-02-26T12:18:43+00:00

The drvinfo struct should include the number of strings that
get_rx_ntuple will return.  It will be variable if an underlying
driver implements its own get_rx_ntuple routine, so userspace
needs to know how much data is coming.

Signed-off-by: Peter P Waskiewicz Jr 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

ethtool: Fix includes build break

2010-02-15T06:38:54+00:00

Based upon a patch by Oliver Hartkopp .

Signed-off-by: David S. Miller

ethtool: Introduce n-tuple filter programming support

2010-02-11T04:03:05+00:00

This patchset enables the ethtool layer to program n-tuple
filters to an underlying device.  The idea is to allow capable
hardware to have static rules applied that can assist steering
flows into appropriate queues.

Hardware that is known to support these types of filters today
are ixgbe and niu.

Signed-off-by: Peter P Waskiewicz Jr 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

tg3: Add some VPD preprocessor constants

2009-12-03T21:18:04+00:00

This patch cleans up the VPD code by creating preprocessor definitions
and using them in the place of hardcoded constants.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

ethtool: Add Direct Attach support to connector port reporting

2009-11-29T08:34:00+00:00

This patch allows a base driver to specify Direct Attach as the
type of port through the ethtool interface.

Signed-off-by: Peter P Waskiewicz Jr 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller