linux-toradex.git/include/linux/firmware/cirrus, branch v5.19-rc3

firmware: cirrus: cs_dsp: Avoid padding bytes in cs_dsp_coeff_ctl

2022-04-25T12:59:02+00:00

Change the order of members in struct cs_dsp_coeff_ctl to avoid
the compiler having to insert alignment padding bytes. On a x86_64
build this saves 16 bytes per control.

- Pointers are collected to the top of the struct (with the exception of
  priv, as noted below), so that they are inherently aligned.
- The set and enable bitflags are placed together so they can be merged.
- priv is placed at the end of the struct - it is for use by the
  client so it is helpful to make it stand out, and since the compiler
  will always pad the struct size to an alignment multiple putting a
  pointer last won't introduce any more padding.
- struct cs_dsp_alg_region is placed at the end, right before priv, for
  the same reasoning as priv.

Signed-off-by: Richard Fitzgerald 
Reviewed-by: Charles Keepax 
Link: https://lore.kernel.org/r/20220425095159.3044527-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Allow creation of event controls

2021-11-17T22:16:28+00:00

Some firmwares contain controls intended to convey firmware state back
to the host. Whilst more infrastructure will probably be needed for
these in time, as a first step allow creation of the controls, so said
firmwares arn't completely rejected.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-10-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add offset to cs_dsp read/write

2021-11-17T22:16:27+00:00

Provide a mechanism to access only part of a control through the cs_dsp
interface.

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-9-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Clarify some kernel doc comments

2021-11-17T22:16:26+00:00

Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-8-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add pre_run callback

2021-11-17T22:16:22+00:00

The code already has a post_run callback, add a matching pre_run
callback to the client_ops that is called before execution is started.
This callback provides a convenient place for the client code to
set DSP controls or hardware that requires configuration before
the DSP core actually starts execution. Note that placing this callback
before cs_dsp_coeff_sync_controls is important to ensure that any
control values are then correctly synced out to the chip.

Co-authored-by: Simon Trimmer 
Signed-off-by: Simon Trimmer 
Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-4-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: Add version checks on coefficient loading

2021-11-17T22:16:21+00:00

The firmware coefficient files contain version information that is
currently ignored by the cs_dsp code. This information specifies which
version of the firmware the coefficient were generated for. Add a check
into the code which prints a warning in the case the coefficient and
firmware differ in version, in many cases this will be ok but it is not
always, so best to let the user know there is a potential issue.

Co-authored-by: Simon Trimmer 
Signed-off-by: Simon Trimmer 
Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211117132300.1290-3-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: tidy includes in cs_dsp.c and cs_dsp.h

2021-11-15T19:25:24+00:00

This patch removes unused included header files and moves others into
cs_dsp.h to ensure that types referenced in the header file are properly
described to prevent compiler warnings.

Signed-off-by: Simon Trimmer 
Acked-by: Charles Keepax 
Link: https://lore.kernel.org/r/20211115120215.56824-1-simont@opensource.cirrus.com
Signed-off-by: Mark Brown

firmware: cs_dsp: add driver to support firmware loading on Cirrus Logic DSPs

2021-09-27T12:00:42+00:00

wm_adsp originally provided firmware loading on some audio DSP and was
implemented as an ASoC codec driver. However, the firmware loading now
covers a wider range of DSP cores and peripherals containing them,
beyond just audio. So it needs to be available to non-audio drivers. All
the core firmware loading support has been moved into a new driver
cs_dsp, leaving only the ASoC-specific parts in wm_adsp.

Signed-off-by: Simon Trimmer 
Signed-off-by: Charles Keepax 
Link: https://lore.kernel.org/r/20210913160057.103842-17-simont@opensource.cirrus.com
Signed-off-by: Mark Brown