linux-toradex.git/include/linux/fsnotify_backend.h, branch v4.14-rc3

fsnotify: Move ->free_mark callback to fsnotify_ops

2017-04-10T15:37:36+00:00

Pointer to ->free_mark callback unnecessarily occupies one long in each
fsnotify_mark although they are the same for all marks from one
notification group. Move the callback pointer to fsnotify_ops.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Add group pointer in fsnotify_init_mark()

2017-04-10T15:37:36+00:00

Currently we initialize mark->group only in fsnotify_add_mark_lock().
However we will need to access fsnotify_ops of corresponding group from
fsnotify_put_mark() so we need mark->group initialized earlier. Do that
in fsnotify_init_mark() which has a consequence that once
fsnotify_init_mark() is called on a mark, the mark has to be destroyed
by fsnotify_put_mark().

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_find_{inode|vfsmount}_mark()

2017-04-10T15:37:36+00:00

These are very thin wrappers, just remove them. Drop
fs/notify/vfsmount_mark.c as it is empty now.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_detach_group_marks()

2017-04-10T15:37:36+00:00

The function is already mostly contained in what
fsnotify_clear_marks_by_group() does. Just update that function to not
select marks when all of them should be destroyed and remove
fsnotify_detach_group_marks().

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Rename fsnotify_clear_marks_by_group_flags()

2017-04-10T15:37:36+00:00

The _flags() suffix in the function name was more confusing than
explaining so just remove it. Also rename the argument from 'flags' to
'type' to better explain what the function expects.

Reviewed-by: Miklos Szeredi 
Suggested-by: Amir Goldstein 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Inline fsnotify_clear_{inode|vfsmount}_mark_group()

2017-04-10T15:37:36+00:00

Inline these helpers as they are very thin. We still keep them as we
don't want to expose details about how list type is determined.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_recalc_{inode|vfsmount}_mask()

2017-04-10T15:37:36+00:00

These helpers are just very thin wrappers now. Remove them.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_set_mark_{,ignored_}mask_locked()

2017-04-10T15:37:36+00:00

These helpers are now only a simple assignment and just obfuscate
what is going on. Remove them.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Pass fsnotify_iter_info into handle_event handler

2017-04-10T15:37:36+00:00

Pass fsnotify_iter_info into ->handle_event() handler so that it can
release and reacquire SRCU lock via fsnotify_prepare_user_wait() and
fsnotify_finish_user_wait() functions.  These functions also make sure
current marks are appropriately pinned so that iteration protected by
srcu in fsnotify() stays safe.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Provide framework for dropping SRCU lock in ->handle_event

2017-04-10T15:37:36+00:00

fanotify wants to drop fsnotify_mark_srcu lock when waiting for response
from userspace so that the whole notification subsystem is not blocked
during that time. This patch provides a framework for safely getting
mark reference for a mark found in the object list which pins the mark
in that list. We can then drop fsnotify_mark_srcu, wait for userspace
response and then safely continue iteration of the object list once we
reaquire fsnotify_mark_srcu.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara