linux-toradex.git/include/linux/gpio/driver.h, branch v6.10

gpiolib: Discourage to use formatting strings in line names

2024-05-07T07:43:17+00:00

Currently the documentation for line names allows to use %u inside
the alternative name. This is broken in character device approach
from day 1 and being in use solely in sysfs.

Character device interface has a line number as a part of its address,
so the users better rely on it. Hence remove the misleading documentation.

On top of that, there are no in-kernel users (out of 6, if I'm correct)
for such names and moreover if one exists it won't help in distinguishing
lines with the same naming as '%u' will also be in them and we will get
a warning in gpiochip_set_desc_names() for such cases.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Reviewed-by: Kent Gibson 
Link: https://lore.kernel.org/r/20240505141420.627398-1-andy.shevchenko@gmail.com
Signed-off-by: Bartosz Golaszewski

gpiolib: Add stubs for GPIO lookup functions

2024-03-26T11:44:56+00:00

The gpio_device_find_by_() functions do not have stubs which means that if
they are referenced from code with an optiona dependency on gpiolib then
the code will fail to link. Add stubs for lookups via fwnode and label. I
have not added a stub for plain gpio_device_find() since it seems harder to
see a use case for that which does not depend on gpiolib.

With the addition of the GPIO reset controller (which lacks a gpiolib
dependency) to the arm64 defconfig this is causing build breaks for arm64
virtconfig in -next:

aarch64-linux-gnu-ld: drivers/reset/core.o: in function `__reset_add_reset_gpio_lookup':
 /build/stage/linux/drivers/reset/core.c:861:(.text+0xccc): undefined reference to `gpio_device_find_by_fwnode'

Signed-off-by: Mark Brown 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Bartosz Golaszewski

Merge tag 'v6.8-rc7' into gpio/for-next

2024-03-05T18:24:34+00:00

Linux 6.8-rc7

gpio: provide for_each_hwgpio()

2024-02-26T15:43:51+00:00

We only provide iterators for requested GPIOs to provider drivers. In
order to allow them to display debug information about all GPIOs, let's
provide a variant for iterating over all GPIOs.

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Linus Walleij

gpio: constify opaque pointer "data" in gpio_device_find()

2024-02-17T19:02:22+00:00

The opaque pointer "data" in each match function used by
gpio_device_find() is a pointer to const, thus the same argument passed
to gpio_device_find() can adjusted similarly.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Bartosz Golaszewski

gpiolib: add gpio_device_get_label() stub for !GPIOLIB

2024-02-13T10:02:53+00:00

Add empty stub of gpio_device_get_label() when GPIOLIB is not enabled.

Cc: 
Fixes: d1f7728259ef ("gpiolib: provide gpio_device_get_label()")
Suggested-by: kernel test robot 
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Bartosz Golaszewski

gpiolib: add gpio_device_get_base() stub for !GPIOLIB

2024-02-13T10:02:52+00:00

Add empty stub of gpio_device_get_base() when GPIOLIB is not enabled.

Cc: 
Fixes: 8c85a102fc4e ("gpiolib: provide gpio_device_get_base()")
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Bartosz Golaszewski

gpiolib: add gpiod_to_gpio_device() stub for !GPIOLIB

2024-02-13T10:02:47+00:00

Add empty stub of gpiod_to_gpio_device() when GPIOLIB is not enabled.

Cc: 
Fixes: 370232d096e3 ("gpiolib: provide gpiod_to_gpio_device()")
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Bartosz Golaszewski

gpio: constify opaque pointer in gpio_device_find() match function

2024-02-12T09:18:31+00:00

The match function used in gpio_device_find() should not modify the
contents of passed opaque pointer, because such modification would not
be necessary for actual matching and it could lead to quite unreadable,
spaghetti code.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Mika Westerberg 
Reviewed-by: Linus Walleij 
Reviewed-by: Andy Shevchenko 
[Bartosz: fix coding style in header]
Signed-off-by: Bartosz Golaszewski

gpio: improve the API contract for setting direction

2024-01-29T10:45:49+00:00

If a GPIO driver returns a positive integer from one of the direction
setter callbacks, we'll end up propagating it to user-space. Whether we
should sanitize the values returned by callbacks is a different question
but let's first improve the documentation and fortify the contract with
GPIO providers.

Reported-by: José Guilherme de Castro Rodrigues 
Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Kent Gibson